From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40EA1DDA20 for ; Mon, 6 Jan 2025 16:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736182569; cv=none; b=hCzLgD02AJ5yPKcywe9n0UZrdM1XQeTwj9AapXx3U4jOdPE4cNG1P0jhqz+L2GKDIR+yk5oDfhN8ginRbq9qQyC/Z6BwoCX/bP3RsKX6ctP5SJDOWEWs1RFy6eOPIY4mhmCWDqXkdTkdY1y+UwO0mIefTHRcwivYnT3P/FER0iQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736182569; c=relaxed/simple; bh=VEIyuQQYk0DTnq+G5GpCzYdCYj/iN14eBTLLzbexIfg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qB9wYp7RGTSV6rbTg8tYLH/rEMVHqLmx2vputzA+mO1Mv/1Q9UvNGvDNJWnxvniyQynsqEEoAJVScbewiUd6+k0puHAVLq8deipYzKSAfqAk0RYFsDFEgsPUlyVSTyhtoMdJPW55PRbJtSRRiRFQ/rSfTBdkEk3XqIJ6R7wndEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rYkk71T3; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rYkk71T3" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ee709715d9so16899830a91.3 for ; Mon, 06 Jan 2025 08:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736182567; x=1736787367; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KMsHepO8ZvN5niVdUS/0Yy0aUBnPp80SWoLTHbVLdY0=; b=rYkk71T3iZs3Vzs7JydxS3HH6SYk3hrfnbrNlXTOWEL9gffPzWtswJh1B94SfY7/zB +SySx5mHean2S+KVrWnCrRAtpt9WH57uc9ARRMa7du65V7VUQ82FVKunJl0hhBARa+N9 50unPvQuaw9uOVRbrDvltdFqWn7DoMuVqcqJmZXJnWm/TqnCuyXX0UzHE57nZTz2JmUF OiU9JbiDTgHZufhCUPCIFqaR1BpTKkxrc55d7tB308UFojaSz9mX+7Qyi252ZEGhsYg2 LKyp6JmC2Hi9WmVu32kHyFjiWSjoWJnBqtl5t7fsn8HQwimzFnrjQwx3rqjeQMV56sR1 Kb2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736182567; x=1736787367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KMsHepO8ZvN5niVdUS/0Yy0aUBnPp80SWoLTHbVLdY0=; b=WFryK66eCCghuiz3hsNMB3pnoM/Ek0q19YVODaFarhNZ115x/OOrrkaPFjAA0cVxTy rhetqmUtTJMiTClUHwTY3Dnqz8iIC+4fXWZPwSV7Y/7b7KN63MO/bKxl0q41/5QPnbR8 3/zFvtK0QIVVwWI+qe+cGeV/8oQTknMvJAr0K93iXKe2GwmwBEXvoOHNWNLtALP0wj4z dHm+5kDbGYNeNt/+ZWKxNb9HHfVf4bs2W/W1mWag0ClC4Y+5o8uBraQPFc8GDNi/lVbo BYZomEifukxMTR0d6DvEPTeUZIkf1ErFV9HDUO0kn5Qav+pJXeELZdIT0VpKjhiMAd4t Wm3w== X-Forwarded-Encrypted: i=1; AJvYcCXja0LCtGuvVpsPsE5+T5tzt81JZPpK8vT9SGON7rvtlE2O5FFYFevkL5ZplKBgFVUELKt1GRn4PXC3z08=@vger.kernel.org X-Gm-Message-State: AOJu0YwnuTYarxzNdG4DgTkQ0jpAQ3E7O+z+fxH6iCdkoj5TYY0oBT9A Xglh8VJpcrqO7TE+GLK43HvWJSgmrw9u1vOH6BmTJziOej0g6EFkkbGXD2b1dJPrbZdESVj5vef b X-Gm-Gg: ASbGncuRE5+4uV4bZz9ZtzpWXbFkx54PyLz2Yz5ZQY2FCMZ4B8z5c3ucFaPCu4Y4NmK wtzxF6PpeZpQl0DRDIp324i6zLAci6W4LyrAh2A+kg/2RtJTAdNlvx3lFHIbj/abr7wAqfaIC3m 6gvZKzPibrfiTedP6rsNfOd4810MFEyBLzC4jpS15RM4A6mfGZlP+dhgRPztW+mp5qGxBwgP1eM OPVRfQVfHzCHMG9Kr16gwwL9fJcJtrjS/Sb4SUM+810UPmIlwfGFw9ehorh X-Google-Smtp-Source: AGHT+IHXuIuhH4k8CgCmwf3Va0ZyrJ7eaYRruTnMkffQlqEgmEjKebr27R3FBZEKFb/zkqd6aeDklA== X-Received: by 2002:a17:90b:4ed0:b0:2ea:37b4:5373 with SMTP id 98e67ed59e1d1-2f452e22604mr90317235a91.10.1736182567169; Mon, 06 Jan 2025 08:56:07 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:8b9d:9aad:a333:f49c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed641ed7sm35922965a91.23.2025.01.06.08.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 08:56:06 -0800 (PST) Date: Mon, 6 Jan 2025 09:56:03 -0700 From: Mathieu Poirier To: Beleswar Padhi Cc: andersson@kernel.org, afd@ti.com, hnagalla@ti.com, u-kumar1@ti.com, jan.kiszka@siemens.com, christophe.jaillet@wanadoo.fr, jkangas@redhat.com, eballetbo@redhat.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] Use Device Lifecycle managed functions in TI R5 Remoteproc driver Message-ID: References: <20241219110545.1898883-1-b-padhi@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241219110545.1898883-1-b-padhi@ti.com> On Thu, Dec 19, 2024 at 04:35:40PM +0530, Beleswar Padhi wrote: > This series uses various devm_ helpers to simplify device removal path in > ti_k3_r5_remoteproc driver. This is the first series in the TI K3 > Remoteproc refactoring as long planned since [0]. > > Testing Done: > 1. Tested boot of R5F remoteprocs in MCU and MAIN voltage domain in both > IPC-Only mode and Kernel remoteproc mode in all Jacinto K3 devices. > 2. Tested Lockstep, Split and Single-CPU Mode configuration (wherever > applicable) of R5F remoteprocs in all Jacinto K3 devices. > 3. Tested shutdown of R5F remoteprocs from Linux userspace and also by > executing `modprobe -r ti_k3_r5_remoteproc`. > 4. Tested that each patch in this series generates no new warnings/errors. > > v2: Changelog: > 1. Re-ordered patches in the series to use devm functions starting from > the last called function in remove(), to ease review. [Andrew] > 2. Fixed a missing return after dev_err_probe() call in [PATCH v2 3/5] > ("remoteproc: k3-r5: Use devm_ioremap_wc() helper"). [Andrew] > 3. Removed redundant rproc_del() call in [PATCH v2 4/5] ("remoteproc: > k3-r5: Use devm_rproc_add() helper"). > > Link to v1: > https://lore.kernel.org/all/20241204111130.2218497-1-b-padhi@ti.com/ > > [0]: https://lore.kernel.org/all/Zr4w8Vj0mVo5sBsJ@p14s/ > > Beleswar Padhi (5): > remoteproc: k3-r5: Add devm action to release reserved memory > remoteproc: k3-r5: Use devm_kcalloc() helper > remoteproc: k3-r5: Use devm_ioremap_wc() helper > remoteproc: k3-r5: Use devm_rproc_add() helper > remoteproc: k3-r5: Add devm action to release tsp > > drivers/remoteproc/ti_k3_r5_remoteproc.c | 88 ++++++++++-------------- > 1 file changed, 35 insertions(+), 53 deletions(- I have applied this set. Thanks, Mathieu > > -- > 2.34.1 >