From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 4/7] gpio: max7360: Add MAX7360 gpio support
Date: Tue, 21 Jan 2025 17:20:08 +0200 [thread overview]
Message-ID: <Z4-7KAUhfXUSmD9I@black.fi.intel.com> (raw)
In-Reply-To: <20241223-mdb-max7360-support-v2-4-37a8d22c36ed@bootlin.com>
On Mon, Dec 23, 2024 at 05:42:36PM +0100, Mathieu Dubois-Briand wrote:
> Add driver for Maxim Integrated MAX7360 GPIO/GPO controller.
>
> Two sets of GPIOs are provided by the device:
> - Up to 8 GPIOs, shared with the PWM and rotary encoder functionalities.
> These GPIOs also provide interrupts on input changes.
> - Up to 6 GPOs, on unused keypad columns pins.
May I ask if you researched for the existing drivers that may host this without
much to modify?
Second, please, avoid OF-centric APIs in a new code. Use fwnode and/or device
property APIs. (This stands for the whole series and any new contributions)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-21 15:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 16:42 [PATCH v2 0/7] Add support for MAX7360 Mathieu Dubois-Briand
2024-12-23 16:42 ` [PATCH v2 1/7] dt-bindings: mfd: gpio: Add MAX7360 Mathieu Dubois-Briand
2024-12-23 17:08 ` Uwe Kleine-König
2024-12-24 9:12 ` Krzysztof Kozlowski
2024-12-24 12:22 ` Mathieu Dubois-Briand
2024-12-23 16:42 ` [PATCH v2 2/7] mfd: Add max7360 support mathieu.dubois-briand
2024-12-23 16:42 ` [PATCH v2 3/7] pwm: max7360: Add MAX7360 PWM support mathieu.dubois-briand
2024-12-31 17:31 ` Christophe JAILLET
2024-12-23 16:42 ` [PATCH v2 4/7] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2024-12-31 17:40 ` Christophe JAILLET
2025-01-21 15:20 ` Andy Shevchenko [this message]
2025-01-22 13:04 ` Mathieu Dubois-Briand
2025-01-22 16:31 ` Andy Shevchenko
2025-01-27 13:08 ` Andy Shevchenko
2024-12-23 16:42 ` [PATCH v2 5/7] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2024-12-31 17:45 ` Christophe JAILLET
2024-12-23 16:42 ` [PATCH v2 6/7] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2024-12-31 17:49 ` Christophe JAILLET
2025-01-02 9:34 ` Mathieu Dubois-Briand
2024-12-23 16:42 ` [PATCH v2 7/7] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
2024-12-23 17:05 ` [PATCH v2 0/7] Add support for MAX7360 Uwe Kleine-König
2024-12-23 17:09 ` Uwe Kleine-König
2024-12-23 17:53 ` Mathieu Dubois-Briand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4-7KAUhfXUSmD9I@black.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox