From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7A101DF721 for ; Sun, 19 Jan 2025 16:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737305976; cv=none; b=DNZgs51yMASGPHJ1ZUeFW1hY+L7541oldMqwVGW25Qw1WWy4onveLUNXf7uU0gnGk9ZB+TyNR2qzDZD6ygj2Akwx9OOYnKEL4j6GyHMvzlExT9NWrsFPYt+aVbdlmP16S6UKn54+lMtRYd6jCenhaLqjmMIwu3h9/R01oJlfqZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737305976; c=relaxed/simple; bh=i8jlXieaT8KmwtG6JYMZ97nlaBgdfnq052Onnm3ehjw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cVrG8/p6zbBVOCJpagKm09aeyuMJmiAIS80PUsxUd9pWciWteeYx4/yFM0Urumdmi2NkrLgrbHKEnoGa9L393QhzlduKPy2qEx2H2VXl79ISbAAtxWig6dlaDSWOmUmtP1+Z2uW7HaBPECML/9CuRLbAPUWmvVn94YL6I/Fo8m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FUChneSB; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FUChneSB" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-386329da1d9so1931428f8f.1 for ; Sun, 19 Jan 2025 08:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737305973; x=1737910773; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ryjgud0Cu35z0KcZwYmKJ/fOZn2jkkwEjHOVTa8VYFo=; b=FUChneSB8WMSrip1HVHKA0Q561mFMhPSUJA1Z0H6szMZvIUQifM3FatltyLCCl7v6N EP10NuSTsSqy2u8I81TlmCIOjVnNUkv1ixHJ3K8Uag42wakz+YDQPbIWbbOV8/YqYPR+ on0jYC2oD52kJDkBIBieVl06KyCDIn5ld8F6VFf+WaNg39rkZeZv4Q7VHZeVXny7uuwG ucrKzLoJKbLePEL5cG0V/vXw40dHqB13c4n5e+Ckk25S7bukpCReW6QA6UCNNnM3feQ5 lZ5xJhFTl9Bo7C5br7hJFpcOAGO6HhcuQZwrf2OMDQfEkPO+SUe7m509RT0IBJXz1/Hb 8oqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737305973; x=1737910773; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ryjgud0Cu35z0KcZwYmKJ/fOZn2jkkwEjHOVTa8VYFo=; b=SnROsrZTmXmms5gPkInJ1wOvUSFisNf6zslz7ycQudC3Cxud5EwabuqnszARo9rdNT VpDaW9MgDCNrvIicxgQmjcuIZA4M/Ti7bHRDBabp2tqiEG6P6Aa+r4AkmWc9PWXGMq4f mSlsHo8LxiaFK+4sFZbCXPMZ9EgKP2SiMeSNXJT1o7Z9e2MOoQ3muI4sNCZiP/jyW2p1 hcPiHX8nlAIJnUrnNr6rgkGp3Bms1dy3WZUcCLFNLvPqK1SjGGCaLvITJrZxZCcdVU8a Wq9ZRZZhemMj8ky4iJLkttuFqBHD2emGAwlbuYzj5DnT+VJby1IqCSHoMXOrC1jeGcVF 0cHw== X-Forwarded-Encrypted: i=1; AJvYcCUDrufSNTR/XN+7/yuxEnbI06rwveXINiU1PzudTPEduKENjY36TL3+xQ3pKsEAkOzfUoIJn+u76pf5nXY=@vger.kernel.org X-Gm-Message-State: AOJu0YwdaFX+V89vHTvBntYhgc+ZVKGjhCX2Xejn+FHNRXC6nXH6G4S0 k7phAJ6S/7UM4voaeqG0/tKRjJA/jUhH5IJFnTCDhvITAOXyaYcn5OcEtQpVWJ0= X-Gm-Gg: ASbGncsaTtpq+DSaxsvmhqVN4J0mcD+lvnO4JkqwMOlWt69qdsMJJar/BRUhZGaZzNP NwkSc5blCD2VOlt9gg7h36Nc+pvfu3JZMl+2T7y3Vu0V6j4UzgJJlX97wtM8PhNge2T0HSix31L 1QvwqWwS9TB73fZPs+a1cmFtCsJfRob/nGh2tZJUznRDKJFE8A9eYI+pQobps9Y2nCiftuTk2aM tQJRSi5Ps+t5ICC0c390gacFKGRKZOWB1T9NS5F3SKvsx3T9XL4RBK0X3/XGkJ3oDH3 X-Google-Smtp-Source: AGHT+IEHlfbUYzo6uXopuyotVKVif1ubxn0HrljJb34K7NGGjfxPHjuaD8j+8GTb1rrlbJmGX092oA== X-Received: by 2002:a5d:4568:0:b0:385:decf:52bc with SMTP id ffacd0b85a97d-38bf5671bc4mr6755803f8f.32.1737305973017; Sun, 19 Jan 2025 08:59:33 -0800 (PST) Received: from linaro.org ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3214df8sm8077337f8f.4.2025.01.19.08.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 08:59:32 -0800 (PST) Date: Sun, 19 Jan 2025 18:59:30 +0200 From: Abel Vesa To: Tudor Ambarus Cc: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Adrian Hunter , Ulf Hansson , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Eric Biggers , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, willmcvicker@google.com, kernel-team@android.com, stable@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 3/4] scsi: ufs: qcom: fix dev reference leaked through of_qcom_ice_get Message-ID: References: <20250117-qcom-ice-fix-dev-leak-v2-0-1ffa5b6884cb@linaro.org> <20250117-qcom-ice-fix-dev-leak-v2-3-1ffa5b6884cb@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117-qcom-ice-fix-dev-leak-v2-3-1ffa5b6884cb@linaro.org> On 25-01-17 14:18:52, Tudor Ambarus wrote: > The driver leaks the device reference taken with > of_find_device_by_node(). Fix the leak by using devm_of_qcom_ice_get(). > > Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API") > Cc: stable@vger.kernel.org > Signed-off-by: Tudor Ambarus > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Abel Vesa > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 23b9f6efa047..a455a95f65fc 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -125,7 +125,7 @@ static int ufs_qcom_ice_init(struct ufs_qcom_host *host) > int err; > int i; > > - ice = of_qcom_ice_get(dev); > + ice = devm_of_qcom_ice_get(dev); > if (ice == ERR_PTR(-EOPNOTSUPP)) { > dev_warn(dev, "Disabling inline encryption support\n"); > ice = NULL; > > -- > 2.48.0.rc2.279.g1de40edade-goog >