From: Nicolin Chen <nicolinc@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "jgg@nvidia.com" <jgg@nvidia.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH rc] iommufd: Explicitize struct iommu_hwpt_pgfault padding
Date: Sun, 19 Jan 2025 21:58:58 -0800 [thread overview]
Message-ID: <Z43mIgD55kU+9UAJ@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB5276F3057E4F8DFA3F22E3C48CE72@BN9PR11MB5276.namprd11.prod.outlook.com>
On Mon, Jan 20, 2025 at 05:44:27AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Saturday, January 18, 2025 10:37 AM
> >
> > @@ -868,6 +868,7 @@ enum iommu_hwpt_pgfault_perm {
> > * @pasid: Process Address Space ID
> > * @grpid: Page Request Group Index
> > * @perm: Combination of enum iommu_hwpt_pgfault_perm
> > + * @__reserved: Must be 0.
>
> iommufd_fault_fops_read() doesn't follow this statement as
> hwpt_fault is on stack with that field uninitialized.
OK. I guess I should update the iommufd_fault_fops_read too.
Thanks
Nic
prev parent reply other threads:[~2025-01-20 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 2:36 [PATCH rc] iommufd: Explicitize struct iommu_hwpt_pgfault padding Nicolin Chen
2025-01-20 5:44 ` Tian, Kevin
2025-01-20 5:58 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z43mIgD55kU+9UAJ@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox