Re: [PATCH 3/7] rtc: pm8xxx: add support for uefi offset

Johan Hovold
2025-01-24T14:07:22Z

On Fri, Jan 24, 2025 at 01:56:56PM +0100, Tobias Heider wrote:
> On Mon, Jan 20, 2025 at 03:41:48PM GMT, Johan Hovold wrote:
> > On many Qualcomm platforms the PMIC RTC control and time registers are
> > read-only so that the RTC time can not be updated. Instead an offset
> > needs be stored in some machine-specific non-volatile memory, which the
> > driver can take into account.
> >
> > Add support for storing a 32-bit offset from the GPS time epoch in a
> > UEFI variable so that the RTC time can be set on such platforms.

> Thanks for the great work Johan, seems to work nicely here!

Thanks for testing.

> I think you might need to add MODULE_IMPORT_NS(EFIVAR) for the efivar_*
> API calls you added.

It's already there (inside the ifdef):

> > +#ifdef CONFIG_EFI
> > +
> > +MODULE_IMPORT_NS("EFIVAR");

Johan