From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 2/2] iio: imu: st_lsm9ds0: Replace device.h with what is needed
Date: Tue, 21 Jan 2025 08:01:55 +0200 [thread overview]
Message-ID: <Z484U1gDYolJ8CAm@black.fi.intel.com> (raw)
In-Reply-To: <20241203195340.855879-3-andriy.shevchenko@linux.intel.com>
On Tue, Dec 03, 2024 at 09:48:52PM +0200, Andy Shevchenko wrote:
> Instead of including a huge device.h with tons of dependencies
> include only what driver actually uses.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 2 +-
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> index d03cec3b24fe..2b1b57761688 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> @@ -7,7 +7,7 @@
> * Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> */
>
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
> #include <linux/err.h>
> #include <linux/gfp_types.h>
> #include <linux/i2c.h>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> index 69e9135795a3..d3bfd74a69ab 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> @@ -7,7 +7,7 @@
> * Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> */
>
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
> #include <linux/err.h>
> #include <linux/gfp_types.h>
> #include <linux/module.h>
Isn't struct device still used in these files?
Raag
next prev parent reply other threads:[~2025-01-21 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 19:48 [PATCH v1 0/2] driver core: move devres APIs to a separate header Andy Shevchenko
2024-12-03 19:48 ` [PATCH v1 1/2] driver core: Split devres APIs to device/devres.h Andy Shevchenko
2024-12-08 17:10 ` Jonathan Cameron
2024-12-09 0:45 ` Andy Shevchenko
2024-12-11 18:29 ` Jonathan Cameron
2024-12-12 14:35 ` Andy Shevchenko
2024-12-03 19:48 ` [PATCH v1 2/2] iio: imu: st_lsm9ds0: Replace device.h with what is needed Andy Shevchenko
2025-01-21 6:01 ` Raag Jadav [this message]
2025-01-21 13:25 ` Andy Shevchenko
2024-12-12 14:34 ` [PATCH v1 0/2] driver core: move devres APIs to a separate header Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z484U1gDYolJ8CAm@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox