From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56DFB1B6D0B for ; Tue, 21 Jan 2025 10:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737456329; cv=none; b=UYD1xwDsP/CtGo4fc9V9j4ttTiXvxyzexP9VNsY+CEjbvj9/pDecIae9UvTKGKHbsvAb6j/MWzjoSJfi0oLMvAwJ5w2MAXPsIcD7a1ns+nnnGexB5lGlaH4kmU8Sj2buGEc3yAN60MYEjV45CTAEA6BPN+fc4eYk9eB4PKeyht4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737456329; c=relaxed/simple; bh=T+M08FOztkgSWKpmxQanv+3vsAoNgsguOND8a7JU59w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QHocamTr+nkxSxRp9XyefOAAj5OjjSEDerPpFx2P93Kt4P5831ZC4NLW1mbXewsqDUST1c+wK9+Z1hyyd69JeLEU8rw5dhYwZn4F8BPVErjWD5jktm1I68dFEy7NrWKaa39XVM3avi99eCNqYUi+YWpLX5PgC5FhaPiB6mJPGBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CXCfbb39; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CXCfbb39" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-385f06d0c8eso2872160f8f.0 for ; Tue, 21 Jan 2025 02:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737456325; x=1738061125; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5+927yDcfTkIOGouFWigCtvSDidRLS7ZH3ez8GRWqN8=; b=CXCfbb39V7XRnn+euqzIHSb+rtsiFkp1jxYOoeRgWG95RUrDMI3OLVHNnJe0b4E2YV ypMzCyLBNj10QKaOYVSAuCBc4jkdLf2b2LoA5NnbbhjvhpRHl9XShPXOsVGjI3EIOpDf zZ35WwHzIaUYzCU30c7W/P8t4+hx11JmAdY+rrDhEQcOOt0h1uuQGrOOim5QZk+pQfN9 LN/pDWD6KuIAQOp0DWcr5/TY+aNFOwhDy0+DAAxePEMWapo/Z8PvWghurA2M6WLBwXXH r0Sfh7pQRRIMh4wKlwI7lk7ARmGii1Suw3NiBZ9b/2VDw/foHlDTrzXk8hPc6huELEaI dfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737456325; x=1738061125; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5+927yDcfTkIOGouFWigCtvSDidRLS7ZH3ez8GRWqN8=; b=aXxlNoLhsnoWsfU1B+wpGM8oE7CVL4I6c4I1IwngDIlh4pNkMNBkIYai0NFr+nZ9pB XwQxlZvIosmsK3dpAb6Fpjnvh0cevIpFHkaKZgmkKL94UB4oolzN+b0PhWzjXKcKLmiW KuNQ0Q5zlYWSmDJ6g4jWG34MGmSERW4ouJKw85bERDEUJ7CggnNOE2nfo2xha2qLU4i3 aUUjFZo/UYv1YfNPbiRbL05TKjo5irnjEWIlJEYCXiXG8uPEcYwi4+dBD7p3tl7eip/G 6+o8JRKImP29d2DIj4tU1d+LaJpTtspzmdAgnHhyuI8fy1B/dG/1wbZIeuFNTvB9VlU8 CvlA== X-Forwarded-Encrypted: i=1; AJvYcCXrMkt/gNAWnIRrsYOJldSt6I0AlfwthsMHJkYmUJqPHtYaJsTvarLAeNV/S7Zs7+P2Y8Peom1C2zQeirY=@vger.kernel.org X-Gm-Message-State: AOJu0YxwGYycL+aKNOlYlOwoQSArjVR3WZc08GsTbkcSZGRY3l7Dds02 7m8SU294UanM3wvxcdXMphYzOhWQpQhYIARtmEcryalqEVp755lK X-Gm-Gg: ASbGncsDRU0+f1ATSYcywC5sRk6du1QOXL3YgrZhup7XgrMcIsfGrIhM+DBbUysG52m qFiuMgHHH0/bH5/kpNQXt8a0hIjvQwyeInOctTz4eO1uQX3GoSKsgvp8Uh1jFv4H8n5J2QRYY5P ea7eKdzqsn4g9xut77p4JVp6+P2WUPH67EMt5P/IbZg5kZtwFjIOIP9sN5QVqUa/2mOUNFgwTdw z1fUOqaDXCF526vwf8Ypwk5lL1cGGG0koCNC1iwuhlhXf3nDfNsvgEFek90RqSj9peB X-Google-Smtp-Source: AGHT+IGoEzxq0HPWhuGQ495VDSXx5P9J5zdFjyXfhO1hziVwbrGp6oAHmMzXz8FDgj9b5VZ3m5AxLA== X-Received: by 2002:a5d:6505:0:b0:38a:88ac:ed10 with SMTP id ffacd0b85a97d-38bf5789edcmr13155035f8f.25.1737456325275; Tue, 21 Jan 2025 02:45:25 -0800 (PST) Received: from fedora ([94.73.34.116]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3214fc9sm12736519f8f.6.2025.01.21.02.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 02:45:24 -0800 (PST) Date: Tue, 21 Jan 2025 11:45:22 +0100 From: =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= To: Louis Chauvet Cc: airlied@gmail.com, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mairacanal@riseup.net, melissa.srw@gmail.com, mripard@kernel.org, rodrigosiqueiramelo@gmail.com, simona.vetter@ffwll.ch, simona@ffwll.ch, thomas.petazzoni@bootlin.com, tzimmermann@suse.de Subject: Re: [PATCH v4 3/3] drm/vkms: Switch to dynamic allocation for CRTC Message-ID: References: <20250117-b4-vkms-allocated-v4-3-8ec8fd21aaf6@bootlin.com> <20250120162327.2866-1-jose.exposito89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 20, 2025 at 06:26:07PM +0100, Louis Chauvet wrote: > On 20/01/25 - 17:23, José Expósito wrote: > > > A specific allocation for the CRTC is not strictly necessary at this > > > point, but in order to implement dynamic configuration of VKMS (configFS), > > > it will be easier to have one allocation per CRTC. > > > > > > Reviewed-by: Maxime Ripard > > > Signed-off-by: Louis Chauvet > > > --- > > [...] > > > > + /* Initialize the writeback component */ > > > if (vkmsdev->config->writeback) { > > > - writeback = vkms_enable_writeback_connector(vkmsdev, crtc); > > > + writeback = vkms_enable_writeback_connector(vkmsdev, output); > > > if (writeback) > > > DRM_ERROR("Failed to init writeback connector\n"); > > > } > > > > Hi Louis, > > > > Thanks for fixing this error condition. > > > > I have been working and running automated tests on top of this series and > > I haven't found any other issue. > > > > Reviewed-by: José Expósito > > Thanks a lot! I will merge this tomorrow. > > What is your automated tests series? On the kernel side, I keep working on the ConfigFS patches here: https://github.com/JoseExposito/linux/commits/patch-vkms-configfs/ It sits on top of your work to switch to managed memory. But now that the code is merged, it needs to be rebased. You'll notice that I kept your signed-off-by in many patches, as I tried to reuse as much common code as possible. About the automated testing, the series could be split in two: - vkms_config.h/c, which is tested with KUnit - ConfigFS, tested with IGT: https://gitlab.freedesktop.org/jexposit/igt-gpu-tools/-/commits/vkms-configfs I made some wrong assumptions with connectors, for example, it is possible to create a device without connectors and hot-add/remove them later, and I'm still fixing them and writing tests. Once that work is done I'll send the series to the ML. Jose > I will also send tomorrow a new rebased iteration for: > - https://patchwork.freedesktop.org/series/140786/ > - https://patchwork.freedesktop.org/series/133698/ > - https://patchwork.freedesktop.org/patch/625883/ > > If someone can look on them and leave some reviews, I will be very happy > to apply them! > > I will also send a first version of the configFS work (two distincts > series to make the review easier). > > Thanks a lot, > Louis Chauvet >