From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 767EA215F5A for ; Fri, 10 Jan 2025 15:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736522659; cv=none; b=kUHvJXVF+NS8ufBgCMG+Yni4aLf7xpbe1+A/H76nN9CFvCr1Keav+R6aEl+NNnfri8Go1c6Mt80y6bD/A+LZjtuAYiQisAvJAgzqtSF0sLWaVqE2WtKntdOPXtiEr54hPU44VS5IeFGkwaGFIXQlJU54pbPbophJ9e1LtS35TLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736522659; c=relaxed/simple; bh=ozaW39XiXqWHvDfVzhAiyQHSSs0KQk4AFJKRA3c7840=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zu89FPYC9kdoFycZ+sRensGLWKOSbYHyi2uyvlDpikocLI7fZSjb+bcJWT/DNutI8/g341FAbBFXpX9Jo7P/BND4aLG/Ay/UDGauUvC8OjZakvK8mdJQ9z3fvHtzQ2kYoIXBF4ZdklmUtyEOAjvMq1Hnsw0EXzuyzOwchGgpccs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cs.cmu.edu; spf=pass smtp.mailfrom=andrew.cmu.edu; dkim=pass (2048-bit key) header.d=cs.cmu.edu header.i=@cs.cmu.edu header.b=BkShXSx5; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cs.cmu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=andrew.cmu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cs.cmu.edu header.i=@cs.cmu.edu header.b="BkShXSx5" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7b7041273ddso170540885a.3 for ; Fri, 10 Jan 2025 07:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.cmu.edu; s=google-2021; t=1736522654; x=1737127454; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=OOepsUM1TiRNJGNg+5Q+9ESc+ok+SkXbqe3ywE+cOlg=; b=BkShXSx5Opio63JjPFEXFcvMLFX3As7NelitOp9nqeuvj0N8VooFwQ3aXAZKNVpLkV Rvyoznz7D0g5Aw8hqhezUbETrjCn4/WL7YSo/Jf96GHYNwqPVUJ5jUsAtoQR1VLICyh1 G0dVb4XX0jOWefiATEvEhfj5+iG3CngAB2o+AToEZI49UEcC3OuwBJ/1MC3B5rTtzLN4 L98++rbnr1gmasz3MBhXFIS0uy1OtC+QFX8Xg73dp052iyNAtYTMMJS/eZbEOlVKDHBA rQBZn3QU8igh/OPqB4n8AOj8hxfsUFCZEzcTY4qCI3S9priwCbTN58u9rJCD0O9V2NT4 MfvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736522654; x=1737127454; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OOepsUM1TiRNJGNg+5Q+9ESc+ok+SkXbqe3ywE+cOlg=; b=IFFPNqpl9bys+Mix+vrFI3gTXpQBIl+pSt3xguCmvG6t26q6AaX01ZX1Pbi/HIFFho woBa3TF/YjvItLmUIzFVXP6EYeooKGjGT5LF0JDNmxkvvgluybzL9eKLrqoRl9epGhBs o1LxUIlp2LmErt2PsW4d/ZrR1JbjGNNJiH1HrxYsCPrgbjZXIOIScWhQ+U1cn+mEDhs5 NJlXpHSIPW18ruMlPX5JpwtmM+hmmQbqsvvL8z0PJo1q7W8uZ3by5UaPDZgHYsyDsPUK +AxwrHJzkJJnW1MBqtjT/kniRnilhy0fbd+Kp6MJU/kjSdjUz96lZy5QUqPiTkn3cjY4 Y4qw== X-Forwarded-Encrypted: i=1; AJvYcCU/tS21e7mAVgrkiH3e5cfW9SgHRPVcGt0q9BTvWEzzK3hbPjv2ngMqJebk2HsAcBU4IVC4vQvadi8M1e8=@vger.kernel.org X-Gm-Message-State: AOJu0YxncaITh0YFe9Q0DVsntkkVBlc5B5LI0UbjoZ9YWJEQjckKfL8s uFmhZXZMK+g106KdiXLDuJNPvfUV9qiJqK7F2WZOoK3yuFDzTPJcKf24V97VPgIlK79eKmW136g = X-Gm-Gg: ASbGncvB4iKbsXRu647egbUgi6H5VA/W/CuM7grIkR5rh9PsPLj94NzQ/on2+LEvzi3 x2Rvr9Bvk5Eow4pmtTnKfutMbV+Pt/M/fjJAa5NYledCRJ2lM1kS5qfPX/jYHL0ZIaU1DvhUbhT x+l9LwPo+dPi64LkpH9birMCNpB7oCm+RDn/SKfmQYfa89vZGocOYgMDKweNUgrGl7NuwWTt9pP bzRJ1hgKP70XXnwIr5T4GmrVnl4CCcg2G9y2H2fnmTq56pCzNzemWEj7NNaamaO9pQ5CkmN1/VQ fZskDMkdWBLjXSnmQU6AStIKQDAWmrNhE7YW3A== X-Google-Smtp-Source: AGHT+IHZ/TzUGQFpUp1yKd5u44JR82Ij0B4Jfyt4J9NNiAn9+VdbgFO7jdkTTZEHVLLTgHQul6l3+Q== X-Received: by 2002:a05:620a:40c2:b0:7b6:d089:2757 with SMTP id af79cd13be357-7bcd977ebb5mr1763421985a.35.1736522654406; Fri, 10 Jan 2025 07:24:14 -0800 (PST) Received: from localhost.localhost (pool-74-98-231-160.pitbpa.fios.verizon.net. [74.98.231.160]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3237e25sm182089385a.10.2025.01.10.07.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 07:24:13 -0800 (PST) Date: Fri, 10 Jan 2025 15:24:11 +0000 From: Kaiyang Zhao To: "Zhijian Li (Fujitsu)" Cc: "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] mm/vmscan: Accumulate nr_demoted for accurate demotion statistics Message-ID: References: <20250110122133.423481-1-lizhijian@fujitsu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: > Well... I know what was going on, the second pass will override stat-＞nr_demoted to be *zero* that makes the first try stat-＞nr_demoted got lost. Ah you are right. This is a bug when demotion partially succeeds in the first pass. Thanks for catching it. Acked-by: Kaiyang Zhao