From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0B02135A5 for ; Fri, 10 Jan 2025 17:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736531027; cv=none; b=TAExUibUBOAuYCE5xIQ2q+lZNuf90ZQAzpmePdghVnGA5vwFqH/prbzP4E0MK7z1ETeQ0WnhH96hrYpkGtxEO62V/FGZI1LrWo0oVzYLwFhJTurWKyIUj8d8h6CTEXNcITDzXw6ccBZaQBeGgIlMI928v3I+B9QAhxn36wRuOM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736531027; c=relaxed/simple; bh=CnfWGhpozCDpRgp/Mucxlx5ehb4EqHx5bh3ZF1YXGlo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kEi2n5QK8Q3tkStQ3UhXSgrCPe2coSt03GExBYPojFa1hrvPbNKjtvyKrkC9kUjrNFZijxAb4ACvLRiYL+9Mc5FNhD/DixGIDk8ipeNWeWN9J5CJObeuZbdXtlF1OC0aT0ma70IQrvoeGbCwijXVSkf/jadXJVDCiMJYWOWXG6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OUJP31MK; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OUJP31MK" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21625b4f978so1825ad.0 for ; Fri, 10 Jan 2025 09:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736531025; x=1737135825; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Semh6egqknurVUS0UY9kKvgG5qMUFSUKa2mHdZrAPcg=; b=OUJP31MKpIN51JHccOrPLOMgnp+QQzdIcWkG6cqeMjmPXm/CnVD5bxFGn4DKGMAWqB zTfmpmguNoUY7qpTahwAaevHehmOaRMTXLCum1SV9JNP4cYGQoDcBnI2qSKNoLbedw7V /SOxhRgGoi2ZAb9ARWrONpaV0qrxNfFP4BXov3eQ7+VFujemtpc6KVA1wT0xBenv03sv IM0JnK3sUqbSkMagMOZgCC2C9f2N9gXMIxhtBiucHKC0SvFIthlxorCCSWJbSuWt+FKr 3cg0JZ4Gy730PICNC9qKI7YreJdEfrycBoMfO8jt6e1RDWV6BJTbidcNke4NKlwCH5UT Ruiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736531025; x=1737135825; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Semh6egqknurVUS0UY9kKvgG5qMUFSUKa2mHdZrAPcg=; b=hsoRj4DDjmlkbhOmJD45rwqtFzOJzvE9Wc5TuXfedFYfYk+wQ3lSCVEDSEYK7Y1149 LR2jGJP2LkK8RmQeKTK51v4KNIAhYZGvYhH+5Z7hKZB149cIRftdesK6KGqoYm00iQp+ Z6YBQPNU/IuFEdI0sNHRwNdlPhDM37GMeKnenwMugF9kkRUIUKX9LnNfETDosIN20NHJ fmTU5OGGxKyK6897Ahp9IW5948q4kOw4azaLf00sPC0yvNcc/zCUa1Q9YNDQwnF45FNi 5u2yZcuHeK7FphgerRdXDg9v5s9kA24ZQIOKaDCfhzwrPTJ+YLMHWRFqjSSZtPUkUb0V PiYg== X-Forwarded-Encrypted: i=1; AJvYcCUojmNjw4V8RWkkZkTzmS7ED3SFV8cPthuD/F/nq9uQ8GLuPBrdRIaetse8f5us3HvBwojSN3QOTq0z7ic=@vger.kernel.org X-Gm-Message-State: AOJu0YyhzRo7iUUrX2yLj914Hc/5LkGnZIExlhkCmFMSWgE8LgxKTsC7 5KRtxglRJIPy5zQo9PBwEvm3lvQhSCosbYieT3JFTzS7lixCCmLzvEgoQbd9Aw== X-Gm-Gg: ASbGncsB0bcyk3swXhM52hXU+OxxXlzR4LWrt5rZMWbpNTbNgqLZpHIqE1hSzIt9/+c Td0ovnsIGUGWz5u6g3yN7eYFLnZe8Pc1Etac73pnzZbWmGSyEjrLo2HZDatazyrTdgSKxREwU1A LeJ7+7QKHN8bP2HXw1FEnwXRaXTnLI4WffW6QhUiSc9517o689TgqADyC0HxAWo5MooEEHv81GB QquiNPogAGGtr7htySBUgk57I46nIA5PEqD9V932GA554WYeVezWw0fbz6UgO9GvJqyp5OmI8Tk Nyues2sorYcoYKh0hNk= X-Google-Smtp-Source: AGHT+IFbXcT0x2kN800ZREcXlYQGGuTgOzivDYlBCT6fvG1ccacTPd+Fjb/A90HAjloQ/QqmHoBl5Q== X-Received: by 2002:a17:902:f803:b0:215:79b5:aa7e with SMTP id d9443c01a7336-21aa3388d04mr2337725ad.13.1736531024992; Fri, 10 Jan 2025 09:43:44 -0800 (PST) Received: from google.com (57.145.233.35.bc.googleusercontent.com. [35.233.145.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f10dddfsm16385485ad.23.2025.01.10.09.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 09:43:44 -0800 (PST) Date: Fri, 10 Jan 2025 17:43:41 +0000 From: Carlos Llamas To: Alice Ryhl Cc: Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , linux-kernel@vger.kernel.org, kernel-team@android.com, Steven Moreland Subject: Re: [PATCH] binder: log transaction code on failure Message-ID: References: <20250110000503.2396017-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 10, 2025 at 01:11:32PM +0100, Alice Ryhl wrote: > On Fri, Jan 10, 2025 at 1:05 AM Carlos Llamas wrote: > > > > When a transaction fails, log the 'tr->code' to help indentify the > > problematic userspace call path. This additional information will > > simplify debugging efforts. > > > > Cc: Steven Moreland > > Signed-off-by: Carlos Llamas > > --- > > drivers/android/binder.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > index ef353ca13c35..cb4187a4e595 100644 > > --- a/drivers/android/binder.c > > +++ b/drivers/android/binder.c > > @@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc, > > } > > > > binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, > > - "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n", > > + "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %d size %lld-%lld line %d\n", > > Shouldn't this by %u instead? Yes, with tr->code being u32 it technically should use %u. I'll send a new version. Thanks!