* [PATCH] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe()
@ 2025-01-10 22:53 Thorsten Blum
2025-01-10 23:04 ` Oliver Upton
2025-01-11 15:02 ` Marc Zyngier
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-01-10 22:53 UTC (permalink / raw)
To: Marc Zyngier, Oliver Upton, Joey Gouly, Suzuki K Poulose,
Zenghui Yu, Catalin Marinas, Will Deacon, Sebastian Ott,
Fuad Tabba
Cc: Thorsten Blum, Christophe JAILLET, linux-arm-kernel, kvmarm,
linux-kernel
Remove hard-coded strings by using the str_enabled_disabled() helper
function.
Suggested-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/arm64/kvm/vgic/vgic-v3.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kvm/vgic/vgic-v3.c b/arch/arm64/kvm/vgic/vgic-v3.c
index f267bc2486a1..528ee93fefd4 100644
--- a/arch/arm64/kvm/vgic/vgic-v3.c
+++ b/arch/arm64/kvm/vgic/vgic-v3.c
@@ -6,6 +6,7 @@
#include <linux/kstrtox.h>
#include <linux/kvm.h>
#include <linux/kvm_host.h>
+#include <linux/string_choices.h>
#include <kvm/arm_vgic.h>
#include <asm/kvm_hyp.h>
#include <asm/kvm_mmu.h>
@@ -663,9 +664,9 @@ int vgic_v3_probe(const struct gic_kvm_info *info)
if (info->has_v4) {
kvm_vgic_global_state.has_gicv4 = gicv4_enable;
kvm_vgic_global_state.has_gicv4_1 = info->has_v4_1 && gicv4_enable;
- kvm_info("GICv4%s support %sabled\n",
+ kvm_info("GICv4%s support %s\n",
kvm_vgic_global_state.has_gicv4_1 ? ".1" : "",
- gicv4_enable ? "en" : "dis");
+ str_enabled_disabled(gicv4_enable));
}
kvm_vgic_global_state.vcpu_base = 0;
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe()
2025-01-10 22:53 [PATCH] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe() Thorsten Blum
@ 2025-01-10 23:04 ` Oliver Upton
2025-01-11 15:02 ` Marc Zyngier
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Upton @ 2025-01-10 23:04 UTC (permalink / raw)
To: Thorsten Blum
Cc: Marc Zyngier, Joey Gouly, Suzuki K Poulose, Zenghui Yu,
Catalin Marinas, Will Deacon, Sebastian Ott, Fuad Tabba,
Christophe JAILLET, linux-arm-kernel, kvmarm, linux-kernel
On Fri, Jan 10, 2025 at 11:53:09PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Suggested-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
--
Thanks,
Oliver
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe()
2025-01-10 22:53 [PATCH] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe() Thorsten Blum
2025-01-10 23:04 ` Oliver Upton
@ 2025-01-11 15:02 ` Marc Zyngier
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2025-01-11 15:02 UTC (permalink / raw)
To: Oliver Upton, Joey Gouly, Suzuki K Poulose, Zenghui Yu,
Catalin Marinas, Will Deacon, Sebastian Ott, Fuad Tabba,
Thorsten Blum
Cc: Christophe JAILLET, linux-arm-kernel, kvmarm, linux-kernel
On Fri, 10 Jan 2025 23:53:09 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
>
Applied to next, thanks!
[1/1] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe()
commit: dea8838128c580cc6b563c901576b580f93a703e
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-11 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-10 22:53 [PATCH] KVM: arm64: vgic: Use str_enabled_disabled() in vgic_v3_probe() Thorsten Blum
2025-01-10 23:04 ` Oliver Upton
2025-01-11 15:02 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).