From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B3C1184E for ; Sat, 11 Jan 2025 00:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736556569; cv=none; b=KbVb9XvpQ8UGna4CUEGRdsPLYPW92nfACuWdW2qGQL1G7EyRvpdCJQ9KwXeijdnQxXL63A95v/hwndXyyTjplII3ReKTFgS3pbfQipeBdOikGSVxaSdCRo4P7qMxfZhIIQyICgwEqBHn+LqMrS5gdrgX1q4sosJr7oMt7Vksw34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736556569; c=relaxed/simple; bh=DqbsPM7pbMq3tNO53LpeaJ86ETg2ScGj8LGDaaUTLJM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NNQgI2efJZJ9KyylWMeh5Yl88ZtowQN248ZdjHgqc0zER5m6EVXKTAUzX1O4gDQDLeuKtB4aOPI7WhjksLnu7He7i2Sj4ww4BOAbquD+l3yVDXdTrhESN164yMQKocUM1k8M9RN09xLzIVto5acPzdoOXlTlLIzDLFDoIRwYTqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Nu902t86; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Nu902t86" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2eebfd6d065so6692235a91.3 for ; Fri, 10 Jan 2025 16:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736556567; x=1737161367; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=YX28d/CEykAYv4b51S4uD+A1lpSwnJPjWn7kTo7F+wY=; b=Nu902t86+h2+UCpAerjCkL1TxbV1qTw+ub+wiooHKXwFb+VvD7cGumqCUdu4VdJaVC wQRcVfcjLeG+0OD+ph810tBX2DRJnI1sKuYSWyaYS85EkRagqODZsqYf4Nh5Jlf8MWfU OoblEve0Cu5eGvBTfN0E1VBNgLEwTRwRVkuAOTnlFaUSNboPXKpf4nQ2M4WirwklA9I4 L5GyIAofAqrnmPwlZBuC4nSx6DrCGjg6kLbTs5u6YVuCOjk35n+cCqh7qib4W2uJ3JNQ S6pEt9JhWGBvZ1aI0GBgJXJxfkCn6yXuS2+b6AQTFzW67CTkKeIGuAK/O1p8hz1VGjth 1txg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736556567; x=1737161367; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YX28d/CEykAYv4b51S4uD+A1lpSwnJPjWn7kTo7F+wY=; b=oALArC1kr10sgZ6VpLtsU9Sf+3MfC/f7JTmzixLjaRApEVLE7r5eae5PlGcxZrUMWR gmd7Ap26L6W0MV5ICg5DFCoTIiocr6Kf2I5kT14qX2klypzt7JVBCEX629AWMf8qM7x4 AF0x4mhzkRdXItp4n7Ykzu5XYh90UcjOriLRtQeVC+1LDf5aUBIKdOBZHyEfJ5j6xzg+ jCl+j6VBbi0tg8UFEkV6jpPEdEtNemKIe9Vx5uHwR7GaOxhIgURNS4j9KU/NeQ1gcy+3 d7OzbQtDcXIHQ55x11dL2+sCcaeRCp3oaCta9bRRqRP5I7ECj8ZcSxhoPWgelL552AnM Zjww== X-Forwarded-Encrypted: i=1; AJvYcCXuAVBe20y4WB587DuNtUDs5kiDv+EzElvC627MY1qd93epq/2+dONA4wf94VbSkPSlh19IlHe5szeHbI4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxiycby38bylvlfvd6Pq8Lmt9su9M1liy7LnfCJkQs5aIIVuuKU p0umLM5ZDkxxzFcicg3erVRYmu2koej03qiuE3GmqbNl5uw+qko/mgrD4qOV/74cxDqHzFjLL+H jsg== X-Google-Smtp-Source: AGHT+IH361hyEP8ZBxDjRVTWmQZDmlNvVhHg1tXUKZ2PrfsrRNnR2/vcWBj5z0ljoK7+gcYBV3qV4n3VGY0= X-Received: from pjbhl13.prod.google.com ([2002:a17:90b:134d:b0:2e0:9fee:4b86]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2747:b0:2f2:a664:df1a with SMTP id 98e67ed59e1d1-2f548e9c9bcmr19626538a91.2.1736556567441; Fri, 10 Jan 2025 16:49:27 -0800 (PST) Date: Fri, 10 Jan 2025 16:49:26 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <14f97f58d6150c6784909261db7f9a05d8d32566.1735931639.git.ashish.kalra@amd.com> <6241f868-98ee-592b-9475-7e6cec09d977@amd.com> <8ae7718c-2321-4f3a-b5b7-7fb029d150cf@amd.com> <8adf7f48-dab0-cbed-d920-e3b74d8411cf@amd.com> Message-ID: Subject: Re: [PATCH v3 6/7] KVM: SVM: Add support to initialize SEV/SNP functionality in KVM From: Sean Christopherson To: Dionna Amalie Glaze Cc: Ashish Kalra , Tom Lendacky , pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, john.allen@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net, michael.roth@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 10, 2025, Dionna Amalie Glaze wrote: > On Fri, Jan 10, 2025 at 4:40=E2=80=AFPM Sean Christopherson wrote: > > > Is there a way to change the load order of built-in modules and/or ch= ange > > > dependency of built-in modules ? > > > > The least awful option I know of would be to have the PSP use a higher = priority > > initcall type so that it runs before the standard initcalls. When comp= iled as > > a module, all initcall types are #defined to module_init. > > > > E.g. this should work, /cross fingers > > > > diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c > > index 7eb3e4668286..02c49fbf6198 100644 > > --- a/drivers/crypto/ccp/sp-dev.c > > +++ b/drivers/crypto/ccp/sp-dev.c > > @@ -295,5 +295,6 @@ static void __exit sp_mod_exit(void) > > #endif > > } > > > > -module_init(sp_mod_init); > > +/* The PSP needs to be initialized before dependent modules, e.g. befo= re KVM. */ > > +subsys_initcall(sp_mod_init); >=20 > I was 2 seconds from clicking send with this exact suggestion. There > are examples in 'drivers/' that use subsys_initcall / module_exit > pairs. Ha! For once, I wasn't too slow due to writing an overly verbose message := -)