From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE4A14A614 for ; Sun, 12 Jan 2025 22:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736722676; cv=none; b=e38hBOUszZ1Pt64eR2ago6N91Nz4EeDFqcilIDBPMZ+bAu843NkGUfrNYK9F9tZ6qiAwgFlEDjBaa6OqTPQ7zZ4SX35g7AWXemyj8txf3H3BbGRruzEQW5SigJgmCHCGFJfV4h/ECYN7xIm0myIHWcy4//5ajqzy6PiW9Xas6Js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736722676; c=relaxed/simple; bh=1vXAt5TLN9RhSuUgNKe8Ng8uM/j48rXN1eJ596jih70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pyfE3HBqjAduJ6v+HAHS+1HFtqEj8nwvOxSMht1YZDKiVq+ZDxPJMTRVIMDo279G4fFR/sYgtbvqA3kvZEXOf0LiDC4n1MUxcLRZakCyY0M8EEJ46kzZtA63QIvCXQSVlRjboK+wxfJzgdsqxdnPnKPxFryaCo1eJSBbo+QyGdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=bvDCJed+; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="bvDCJed+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=Dn+nzRwAjy4+MEb2ambf3gZ4KPvzCEVaQV2Es+r7Tes=; b=bvDCJed+rtd+eLWd SJEKpST9puKdabamlyAE3/sqLwqu/thl/SKdeUwHztRCcy2kvQwp1AgoYIUsMam9MdSR1ZkzB87P/ H8PFPNmSdfsHJ51uBOMTVEPEiBr31jWUOJ9KSOraj4o3kpmmJ5CKob56nGxsoxLTQYEqw8rma1EsX 7E5kySi0Mud/GRkIScuvW2L9gU+bbI97++ceurh6KX+CxAZvrc2BgpUDLqFoNrvIMi4T3C00avj0l piL0tNzCfIN0LZqT5qwHSbWcNWmAmTqADqir2UzI4AoZIVGKvANHMTJnyP/xHBgVoVfUsHveKcgxK 6VhJA1OsSiJBvW2KDQ==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1tX6tv-009lc9-2O; Sun, 12 Jan 2025 22:57:47 +0000 Date: Sun, 12 Jan 2025 22:57:47 +0000 From: "Dr. David Alan Gilbert" To: Alexandre Belloni Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i3c: Remove unused i3c_device_do_setdasa Message-ID: References: <20241221143418.86012-1-linux@treblig.org> <202501122254082b225acf@mail.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <202501122254082b225acf@mail.local> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-21-amd64 (x86_64) X-Uptime: 22:57:31 up 249 days, 10:11, 1 user, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/2.2.12 (2023-09-09) * Alexandre Belloni (alexandre.belloni@bootlin.com) wrote: > Hello, > > On 21/12/2024 14:34:18+0000, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > i3c_device_do_setdasa() was added in 2022 as part of > > commit 672825cd2823 ("i3c: export SETDASA method") > > > > but has been unused. > > > > It calls i3c_dev_setdasa_locked() which is now also unused. > > > > Remove them both. > > (This is effectively a revert of 672825cd2823). > > > > > Yeah, i guess this just means that we didn't see the device driver yet. > I'm going to keep those function around for now. OK, thanks for the review. Dave > > Signed-off-by: Dr. David Alan Gilbert > > --- > > drivers/i3c/device.c | 20 -------------------- > > drivers/i3c/internals.h | 1 - > > drivers/i3c/master.c | 19 ------------------- > > include/linux/i3c/device.h | 2 -- > > 4 files changed, 42 deletions(-) > > > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > > index e80e48756914..984976f28314 100644 > > --- a/drivers/i3c/device.c > > +++ b/drivers/i3c/device.c > > @@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, > > } > > EXPORT_SYMBOL_GPL(i3c_device_do_priv_xfers); > > > > -/** > > - * i3c_device_do_setdasa() - do I3C dynamic address assignement with > > - * static address > > - * > > - * @dev: device with which the DAA should be done > > - * > > - * Return: 0 in case of success, a negative error core otherwise. > > - */ > > -int i3c_device_do_setdasa(struct i3c_device *dev) > > -{ > > - int ret; > > - > > - i3c_bus_normaluse_lock(dev->bus); > > - ret = i3c_dev_setdasa_locked(dev->desc); > > - i3c_bus_normaluse_unlock(dev->bus); > > - > > - return ret; > > -} > > -EXPORT_SYMBOL_GPL(i3c_device_do_setdasa); > > - > > /** > > * i3c_device_get_info() - get I3C device information > > * > > diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h > > index 433f6088b7ce..842e1a865877 100644 > > --- a/drivers/i3c/internals.h > > +++ b/drivers/i3c/internals.h > > @@ -13,7 +13,6 @@ > > void i3c_bus_normaluse_lock(struct i3c_bus *bus); > > void i3c_bus_normaluse_unlock(struct i3c_bus *bus); > > > > -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev); > > int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, > > struct i3c_priv_xfer *xfers, > > int nxfers); > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > > index 42310c9a00c2..000187339400 100644 > > --- a/drivers/i3c/master.c > > +++ b/drivers/i3c/master.c > > @@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) > > } > > EXPORT_SYMBOL_GPL(i3c_master_unregister); > > > > -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev) > > -{ > > - struct i3c_master_controller *master; > > - > > - if (!dev) > > - return -ENOENT; > > - > > - master = i3c_dev_get_master(dev); > > - if (!master) > > - return -EINVAL; > > - > > - if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || > > - !dev->boardinfo->static_addr) > > - return -EINVAL; > > - > > - return i3c_master_setdasa_locked(master, dev->info.static_addr, > > - dev->boardinfo->init_dyn_addr); > > -} > > - > > int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, > > struct i3c_priv_xfer *xfers, > > int nxfers) > > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h > > index 0a8a44ac2f02..f4e924c179d7 100644 > > --- a/include/linux/i3c/device.h > > +++ b/include/linux/i3c/device.h > > @@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, > > struct i3c_priv_xfer *xfers, > > int nxfers); > > > > -int i3c_device_do_setdasa(struct i3c_device *dev); > > - > > void i3c_device_get_info(const struct i3c_device *dev, struct i3c_device_info *info); > > > > struct i3c_ibi_payload { > > -- > > 2.47.1 > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/