Re: [PATCH v5 02/14] iommufd/fault: Add an iommufd_fault_init() helper

Jason Gunthorpe
2025-01-10T17:25:16Z

On Tue, Jan 07, 2025 at 09:10:05AM -0800, Nicolin Chen wrote:
> The infrastructure of a fault object will be shared with a new vEVENTQ
> object in a following change. Add a helper for a vEVENTQ allocator to
> call it too.
>
> Reorder the iommufd_ctx_get and refcount_inc, to keep them symmetrical
> with the iommufd_fault_fops_release().
>
> Since the new vEVENTQ doesn't need "response", leave the xa_init_flags
> in its original location.
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/iommu/iommufd/fault.c | 48 ++++++++++++++++++++---------------
> 1 file changed, 28 insertions(+), 20 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason