From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/5] perf test: Add a runs-per-test option
Date: Mon, 13 Jan 2025 14:29:34 -0800 [thread overview]
Message-ID: <Z4WTzkVh61cYoOsW@google.com> (raw)
In-Reply-To: <20250110045736.598281-1-irogers@google.com>
On Thu, Jan 09, 2025 at 08:57:31PM -0800, Ian Rogers wrote:
> Add a runs-per-test option to perf test inorder to better diagnose
> flakes. Each runs executes as if it were a different test, the tests
> appear together in the output:
>
> ```
> $ perf test -r 3 lbr -v
> 122: perf record LBR tests : Ok
> 122: perf record LBR tests : Ok
> 122: perf record LBR tests : Ok
> ```
>
> v5: Fix the patch that updates the documentation for the sequential
> option, as spotted by Namhyung.
> v4: Fix crash in dont_fork mode caused by cleanup work.
> v3: Improve perf test documentation, including for the new option, and
> add some example output to the commit messages as requested by
> Namhyung.
> v2: In the v1 patch Kan and I noted cleanup that would make the code
> cleaner and less indented:
> https://lore.kernel.org/lkml/20241109160219.49976-1-irogers@google.com/
> Add patches doing some builtin-test.c cleanup and then add the
> runs-per-test flag.
>
> Ian Rogers (5):
> perf test: Rename functions and variables for better clarity
> perf test: Send list output to stdout rather than stderr
> perf test: Fix parallel/sequential option documentation
> perf test: Add a runs-per-test flag
> perf test: Improve verbose documentation
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> tools/perf/Documentation/perf-test.txt | 20 ++-
> tools/perf/tests/builtin-test.c | 223 ++++++++++++-------------
> 2 files changed, 119 insertions(+), 124 deletions(-)
>
> --
> 2.47.1.613.gc27f4b7a9f-goog
>
next prev parent reply other threads:[~2025-01-13 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 4:57 [PATCH v5 0/5] perf test: Add a runs-per-test option Ian Rogers
2025-01-10 4:57 ` [PATCH v5 1/5] perf test: Rename functions and variables for better clarity Ian Rogers
2025-01-10 4:57 ` [PATCH v5 2/5] perf test: Send list output to stdout rather than stderr Ian Rogers
2025-01-10 4:57 ` [PATCH v5 3/5] perf test: Fix parallel/sequential option documentation Ian Rogers
2025-01-10 4:57 ` [PATCH v5 4/5] perf test: Add a runs-per-test flag Ian Rogers
2025-01-10 4:57 ` [PATCH v5 5/5] perf test: Improve verbose documentation Ian Rogers
2025-01-13 22:29 ` Namhyung Kim [this message]
2025-01-17 17:54 ` [PATCH v5 0/5] perf test: Add a runs-per-test option Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4WTzkVh61cYoOsW@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox