From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12666146A79 for ; Tue, 14 Jan 2025 15:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736867398; cv=none; b=uk/HNgcj5H1MokP02iODtfTUXWqtXfFJn2myFkKen4GMhjEcFQkt11RtFsJxS6lRnkP4u78FfMUFJXMLlkUiS88PuIRWwEgOsG69s/we73xeLRIzvc+PfLPKIokPRgYtgSuvjFR/2HV1Fjeu2vsCAFPfJKtkO7dx42PaHoJ7F+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736867398; c=relaxed/simple; bh=pF75XEhCKXfa8xLX7BhBkgUQunabFzT49vPHGlCrxp0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l22zBYp9Z8ZLO/ba6DAiXT4C6MoUhjPxC/LoIMlTwYf/RC02aX/YqCMOsbj78HF1hTTa6F1Ytq7Ap5DCT+R3r0EThuWV/89FHR4qp7PepaL771nKVOg+IXJo1ZErwqwPAa5EyBUxh2fpxH1yGur7IDQXQvqviPOd3PgvNcco7zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y8BAvFB9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y8BAvFB9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC181C4CEDD; Tue, 14 Jan 2025 15:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736867397; bh=pF75XEhCKXfa8xLX7BhBkgUQunabFzT49vPHGlCrxp0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y8BAvFB9wyfMPoiWJw529UvoYSB6t2kMT9i/2h1HSI4JFMtvWoxIsXQ3GcbgJ9oK6 VH0lVO2wZk9/6yQZ5BLvJBD3yi0IhFH84jdw2+29r9kZodDMMx2P/99jEiANO2JKwf CK6WrnXksNSX1/HcrvXFyZpplL6njbLq/6Uoy9+FHkpk5vrUZesIQg6KgVULRSitMq ZNw23DEjnUAn33zZvbr/Dg7P3XO1fwJwoqIkeIg7yqnBpnQ5tdDbyqvZiRqZflndLy 5KhYZ0/sbtdcaH6MVKDAph8GpK/xF6W+jlxnbJUmtQis5udz5Q+7tSA6YEtdFYYlsq 8AC0XTwA+RNWQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tXiYK-0000000079j-0bFX; Tue, 14 Jan 2025 16:10:00 +0100 Date: Tue, 14 Jan 2025 16:10:00 +0100 From: Johan Hovold To: Nobuhiro Iwamatsu Cc: Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] gnss: mtk: Simplify return variables in mtk_set_active and mtk_set_standby Message-ID: References: <20241117052501.1138926-1-iwamatsu@nigauri.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241117052501.1138926-1-iwamatsu@nigauri.org> On Sun, Nov 17, 2024 at 02:25:01PM +0900, Nobuhiro Iwamatsu wrote: > Simply return directly instead of assign the return value. > > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/gnss/mtk.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/gnss/mtk.c b/drivers/gnss/mtk.c > index c62b1211f4fe4e..be20f6d6470736 100644 > --- a/drivers/gnss/mtk.c > +++ b/drivers/gnss/mtk.c > @@ -24,25 +24,15 @@ struct mtk_data { > static int mtk_set_active(struct gnss_serial *gserial) > { > struct mtk_data *data = gnss_serial_get_drvdata(gserial); > - int ret; > > - ret = regulator_enable(data->vcc); > - if (ret) > - return ret; > - > - return 0; > + return regulator_enable(data->vcc); The current style with separate success and error paths was used on purpose (e.g. to make it obvious from just looking at this function to determine what is returned). Johan