From: Johan Hovold <johan@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com, pmenzel@molgen.mpg.de,
jirislaby@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
"Adam Ford" <aford173@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
tomi.valkeinen@ideasonboard.com,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
robh@kernel.org, hns@goldelico.com
Subject: Re: [PATCH RFC v4 4/4] gnss: ai2: replace long sleeps by wait for acks
Date: Tue, 14 Jan 2025 13:36:09 +0100 [thread overview]
Message-ID: <Z4ZaOXiUVQXK_d7L@hovoldconsulting.com> (raw)
In-Reply-To: <20240606183032.684481-5-andreas@kemnade.info>
On Thu, Jun 06, 2024 at 08:30:32PM +0200, Andreas Kemnade wrote:
> Previously there were long sleeps for everything sent out.
> Replace the sleeps by some wait for completion.
> Wait times like 60ms are seen.
> There are ack packets sent out if requested. Unfortunately
> just waiting for them seems not stable, some open()/close()
> loop stress-testing brings the communication into complete
> disorder. Unfortunately these ack packets arrive before
> a complete answer of the command has been received but
> apparently after some processing has been done.
> Properly declaring expected answers might help but adding
> that can only be justified after some wider testing.
>
> So leaving this part of the series as a RFC and base
> for future optimzations.
Haven't really looked at this patch, but based on the above this doesn't
really provide any confidence that this protocol should be handled in
the kernel rather than in user space...
Johan
next prev parent reply other threads:[~2025-01-14 12:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 18:30 [PATCH v4 0/4] Bluetooth/gnss: GNSS support for TiWi chips Andreas Kemnade
2024-06-06 18:30 ` [PATCH v4 1/4] gnss: Add AI2 protocol used by some TI combo chips Andreas Kemnade
2025-01-14 12:00 ` Johan Hovold
2024-06-06 18:30 ` [PATCH v4 2/4] Bluetooth: ti-st: Add GNSS subdevice for TI Wilink chips Andreas Kemnade
2025-01-14 12:14 ` Johan Hovold
2025-01-14 13:05 ` Andreas Kemnade
2025-01-14 15:26 ` Johan Hovold
2025-01-14 16:26 ` Andreas Kemnade
2024-06-06 18:30 ` [PATCH v4 3/4] gnss: Add driver for AI2 protocol Andreas Kemnade
2025-01-14 12:33 ` Johan Hovold
2024-06-06 18:30 ` [PATCH RFC v4 4/4] gnss: ai2: replace long sleeps by wait for acks Andreas Kemnade
2025-01-14 12:36 ` Johan Hovold [this message]
2024-06-06 20:04 ` [PATCH v4 0/4] Bluetooth/gnss: GNSS support for TiWi chips Luiz Augusto von Dentz
2024-06-06 20:19 ` Andreas Kemnade
2024-06-08 19:00 ` Adam Ford
2024-06-08 19:20 ` Andreas Kemnade
2024-06-10 23:17 ` Adam Ford
2024-06-11 8:32 ` Andreas Kemnade
2024-09-02 9:22 ` Andreas Kemnade
2024-09-02 9:26 ` Johan Hovold
2024-11-18 9:52 ` Andreas Kemnade
2025-01-14 11:57 ` Johan Hovold
2025-01-14 12:35 ` H. Nikolaus Schaller
2025-01-16 1:10 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4ZaOXiUVQXK_d7L@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=aford173@gmail.com \
--cc=andreas@kemnade.info \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=jirislaby@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=peter.ujfalusi@gmail.com \
--cc=pmenzel@molgen.mpg.de \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox