Re: [PATCH v2 0/5] KVM: kvm_set_memory_region() cleanups

Xiaoyao Li
2025-01-14T02:09:31Z

On 1/11/2025 8:20 AM, Sean Christopherson wrote:
> Cleanups related to kvm_set_memory_region(), salvaged from similar patches
> that were flying around when we were sorting out KVM_SET_USER_MEMORY_REGION2.
>
> And, hopefully, the KVM-internal memslots hardening will also be useful for
> s390's ucontrol stuff (https://lore.kernel.org/all/Z4FJNJ3UND8LSJZz@google.com).

For the series:

Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

> v2:
> - Keep check_memory_region_flags() where it is. [Xiaoyao]
> - Rework the changelog for the last patch to account for the change in
> motiviation.
> - Fix double spaces goofs. [Tao]
> - Add a lockdep assertion in the x86 code, too. [Tao]
>
> v1: https://lore.kernel.org/all/20240802205003.353672-1-seanjc@google.com
>
> Sean Christopherson (5):
> KVM: Open code kvm_set_memory_region() into its sole caller (ioctl()
> API)
> KVM: Assert slots_lock is held when setting memory regions
> KVM: Add a dedicated API for setting KVM-internal memslots
> KVM: x86: Drop double-underscores from __kvm_set_memory_region()
> KVM: Disallow all flags for KVM-internal memslots
>
> arch/x86/kvm/x86.c | 7 ++++---
> include/linux/kvm_host.h | 8 +++-----
> virt/kvm/kvm_main.c | 33 ++++++++++++++-------------------
> 3 files changed, 21 insertions(+), 27 deletions(-)
>
>
> base-commit: 10b2c8a67c4b8ec15f9d07d177f63b563418e948