Re: [PATCH v1 19/21] platform/x86: dell-ddv: Fix the type of 'config' in struct hwmon_channel_info to u64

lihuisong (C)
2025-01-22T05:57:57Z

在 2025/1/21 20:18, Ilpo Järvinen 写道:
> On Tue, 21 Jan 2025, Huisong Li wrote:
>
>> The type of 'config' in struct hwmon_channel_info has been fixed to u64.
>> Modify the related code in driver to avoid compiling failure.
> Does this mean that after applying part of your series but not yet this
> patch, compile would fail? If so, it's unacceptable. At no point in a
> patch series are you allowed to cause a compile failure because it hinders
> 'git bisect' that is an important troubleshooting tool.
>
> So you might have to combine changes to drivers and API if you make an
> API change that breaks driver build until driver too is changed. Note that
> it will impact a lot how quickly your patches can be accepted as much
> higher level of coordination is usually required if your patch is touching
> things all over the place, but it cannot be avoided at times. And
> requirement of doing minimal change only will be much much higher in such
> a large scale change.
>
Ack. Thanks for your reply.
>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> drivers/platform/x86/dell/dell-wmi-ddv.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c
>> index e75cd6e1efe6..efb2278aabb9 100644
>> --- a/drivers/platform/x86/dell/dell-wmi-ddv.c
>> +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c
>> @@ -86,7 +86,7 @@ struct thermal_sensor_entry {
>>
>> struct combined_channel_info {
>> struct hwmon_channel_info info;
>> - u32 config[];
>> + u64 config[];
>> };
>>
>> struct combined_chip_info {
>> @@ -500,7 +500,7 @@ static const struct hwmon_ops dell_wmi_ddv_ops = {
>>
>> static struct hwmon_channel_info *dell_wmi_ddv_channel_create(struct device *dev, u64 count,
>> enum hwmon_sensor_types type,
>> - u32 config)
>> + u64 config)
>> {
>> struct combined_channel_info *cinfo;
>> int i;
>> @@ -543,7 +543,7 @@ static struct hwmon_channel_info *dell_wmi_ddv_channel_init(struct wmi_device *w
>> struct dell_wmi_ddv_sensors *sensors,
>> size_t entry_size,
>> enum hwmon_sensor_types type,
>> - u32 config)
>> + u64 config)
>> {
>> struct hwmon_channel_info *info;
>> int ret;
>>
> .