Re: [PATCH v1 00/21] hwmon: Fix the type of 'config' in struct hwmon_channel_info to u64

Krzysztof Kozlowski
2025-01-22T07:51:42Z

On 21/01/2025 09:14, lihuisong (C) wrote:
>
> 在 2025/1/21 15:47, Krzysztof Kozlowski 写道:
>> On 21/01/2025 07:44, Huisong Li wrote:
>>> The hwmon_device_register() is deprecated. When I try to repace it with
>>> hwmon_device_register_with_info() for acpi_power_meter driver, I found that
>>> the power channel attribute in linux/hwmon.h have to extend and is more
>>> than 32 after this replacement.
>>>
>>> However, the maximum number of hwmon channel attributes is 32 which is
>>> limited by current hwmon codes. This is not good to add new channel
>>> attribute for some hwmon sensor type and support more channel attribute.
>>>
>>> This series are aimed to do this. And also make sure that acpi_power_meter
>>> driver can successfully replace the deprecated hwmon_device_register()
>>> later.
>> Avoid combining independent patches into one patch bomb. Or explain the
>> dependencies and how is it supposed to be merged - that's why you have
>> cover letter here.
> These patches having a title ('Use HWMON_CHANNEL_INFO macro to simplify
> code') are also for this series.
> Or we need to modify the type of the 'xxx_config' array in these patches.
> If we directly use the macro HWMON_CHANNEL_INFO, the type of 'config'
> has been modifyed in patch 1/21 and these driver don't need to care this
> change.

None of above addresses my concern. I am dropping the series from my
inbox/to-review box.

Best regards,
Krzysztof