From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BE01B87C6 for ; Tue, 14 Jan 2025 16:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736873815; cv=none; b=QFP46artbz4rhXDKoyTDX+qSgE1ykU6yX3Msn/UFgm6/Q7OZwyI9KYsUkOM7nldNtgFNoiTUQPaH0LswaPbgavGFlrdL0fG3MPBPigRWSxctVdizQXiijZaU+n0MxI+M4nol4SIN4v7awTZJ4h4FKggo6NNQhdHGTDBDa0NBHwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736873815; c=relaxed/simple; bh=39D/Xi+vW60VERRJTbj1uNFzbyidxTF3OoZLKrTjLuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HTstVkZmS93EFWTQanFsxiLKVq8LoxLBJdXuz9MIQxu9KHtwJsghRZ1VjTCplwOm+izNQlQ1CN3A30TBLdwNIazaVX8V84OZuiOwH4+doNU7eEz//pQ9uhYCFW9MLteIqklTxIMR3B5uMBsf+wZqPqO9vxXs8nhzFa9c+ufD5qY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HeuG8adK; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HeuG8adK" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aa6c0d1833eso405996266b.1 for ; Tue, 14 Jan 2025 08:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736873812; x=1737478612; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k+NCndVlSXNfCvU38YnHTIBhOsF9U+leIyffmLvzRwQ=; b=HeuG8adKtWA6+LMwnCOjyQJcOcWIBZ1vHlz8S0aty0TvWfrvPRwMolMM1QA8boQXpA zN0DzZZjatNSZt0qwZ54lf7obB0TGa5Ljijy+1Nyf2wnf2GJ1bFF7XZe0XfsI4ZYDxmM 2j5iGEsCkUJZlkznWFQoohV95ukxUTytoQOYIHfDIWoFZezY76NHh0Hc4iT7R8nhdD7w 3M1yAypkGSswCZYzLfuHSnCd06J2aYWNTq9iryiz2wQXNSdO+6UXGT4R6R1Qw2PDzrbC 0fsS1OvX0E8YsZ5maUY7hc/tDFz2vTTe30ljZ29BZHy0e7C4ZPiKFSzWL+NBxSzlC9TH 9pOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736873812; x=1737478612; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k+NCndVlSXNfCvU38YnHTIBhOsF9U+leIyffmLvzRwQ=; b=SYKYxVVXEP2c0h66z4KUQB4ybCCjIIwzVrJoRTGTKpsPMTQFi80u9KeMCMcVrMIhAP Q6LGusVvUUShUsVPy1jAitgrfov8/Fq/mKzwI0AyHey5MlXq+gh+jGGQREDmbar2CeBM x2hcJ9AAfZhD8BCfFqT3r/uVcCCd/nUBAx/U/dJ2O+L89TgHQCJMfeVQNOVYgiUdddwr XOG3LjUan4xnoQInJt0dWuVDeZq7ZN0QnL7AarDc/F3lVBmqAmtLExp3ViRWJEW72qZ3 QL9hNJ5P3OhW3B3rjAdYCYEHjD4vAcDHDMQspRGs58xBnVWo3Av4BL0RxasqkL1zOPL9 DMbw== X-Forwarded-Encrypted: i=1; AJvYcCXQPBdjTuTl8XWyMA+TxKMygNA9hA07EtElSmeNf9zqFTwDL/7mg2MGwv1HGvC0V79HLbeIkr7dgarMBbs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4P37acNA3QoCqn6hFGMPnVkcCnR4BtYiqr+zuhCmDqOQxWmFa mwxT+Jj498FLu0wxkxSCSdeHXT0jtnpaJ6vQOygJrweNCsZbdS+ghRSmAbZEegg= X-Gm-Gg: ASbGncuK1h/Ugmzd6bTdiqqclSDHTuBhfeO6qE9xTMMI6V2d/8kNKwQku2FpSkEY54e YR06Gc8xRm5LMYFgaI4YJZXbS70ddWAtISMEKckY+oFAq8v3SSWismfSNmfvy6ZDb9zTBbiELmL VxzW2ckL6yw9lB0O22JeoIYuqCXAIFCUlnEDVwWyO9+SoJ7SazOcQ/p23x+8UezI2hPUN2h2icC RBE+wgm4FNS0y/rehu5iSzutF6w6bDnb8S1xA8KhLQfZvlui4kiO9OPQDvulxLEk+2dlQ== X-Google-Smtp-Source: AGHT+IH1ZgJew7m6NRAJoySqboWQ70RFJl30LWnHsy4ktkPD5nv9TCgRb5tHdsOAoWY46J8BU7kQWA== X-Received: by 2002:a17:907:7da5:b0:aae:83c6:c679 with SMTP id a640c23a62f3a-ab2ab748f2cmr2569261666b.32.1736873812276; Tue, 14 Jan 2025 08:56:52 -0800 (PST) Received: from localhost (109-81-90-202.rct.o2.cz. [109.81.90.202]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9562519sm653091866b.132.2025.01.14.08.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 08:56:52 -0800 (PST) Date: Tue, 14 Jan 2025 17:56:51 +0100 From: Michal Hocko To: Johannes Weiner Cc: Yosry Ahmed , Rik van Riel , Balbir Singh , Roman Gushchin , hakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Nhat Pham Subject: Re: [PATCH v2] memcg: allow exiting tasks to write back data to swap Message-ID: References: <20241212115754.38f798b3@fangorn> <20241212183012.GB1026@cmpxchg.org> <20250114160955.GA1115056@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 14-01-25 17:54:17, Michal Hocko wrote: > On Tue 14-01-25 17:46:39, Michal Hocko wrote: > > On Tue 14-01-25 11:09:55, Johannes Weiner wrote: > > > Hi, > > > > > > On Mon, Dec 16, 2024 at 04:39:12PM +0100, Michal Hocko wrote: > > > > On Thu 12-12-24 13:30:12, Johannes Weiner wrote: > > [...] > > > > > If we return -ENOMEM to an OOM victim in a fault, the fault handler > > > > > will re-trigger OOM, which will find the existing OOM victim and do > > > > > nothing, then restart the fault. > > > > > > > > IIRC the task will handle the pending SIGKILL if the #PF fails. If the > > > > charge happens from the exit path then we rely on ENOMEM returned from > > > > gup as a signal to back off. Do we have any caller that keeps retrying > > > > on ENOMEM? > > > > > > We managed to extract a stack trace of the livelocked task: > > > > > > obj_cgroup_may_swap > > > zswap_store > > > swap_writepage > > > shrink_folio_list > > > shrink_lruvec > > > shrink_node > > > do_try_to_free_pages > > > try_to_free_mem_cgroup_pages > > > > OK, so this is the reclaim path and it fails due to reasons you mention > > below. This will retry several times until it hits mem_cgroup_oom which > > will bail in mem_cgroup_out_of_memory because of task_is_dying (returns > > true) and retry the charge + reclaim (as the oom killer hasn't done > > anything) with passed_oom = true this time and eventually got to nomem > > path and returns ENOMEM. SUSE Labs > > Btw. is there any actual reason why we cannot go nomem without going > to the oom killer (just to bail out) and go through the whole cycle > again? That seems arbitrary and simply burning a lot of cycle without > much chances to make any better outcome > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7b3503d12aaf..eb45eaf0acfc 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2268,8 +2268,7 @@ int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, > if (gfp_mask & __GFP_RETRY_MAYFAIL) > goto nomem; > > - /* Avoid endless loop for tasks bypassed by the oom killer */ > - if (passed_oom && task_is_dying()) > + if (task_is_dying()) > goto nomem; > > /* Just to clarify, only if we have strong reasons to keep bail out in the oom killer path. If we go with the change proposed in the other email, this doesn't make sense. -- Michal Hocko SUSE Labs