Re: [PATCH v4 10/30] riscv/paravirt: Mark pv_steal_clock static call as __ro_after_init

Andrew Jones
2025-01-14T18:29:23Z

On Tue, Jan 14, 2025 at 06:51:23PM +0100, Valentin Schneider wrote:
> The static call is only ever updated in:
>
> __init pv_time_init()
> __init xen_time_setup_guest()
>
> so mark it appropriately as __ro_after_init.
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> arch/riscv/kernel/paravirt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/paravirt.c b/arch/riscv/kernel/paravirt.c
> index fa6b0339a65de..dfe8808016fd8 100644
> --- a/arch/riscv/kernel/paravirt.c
> +++ b/arch/riscv/kernel/paravirt.c
> @@ -30,7 +30,7 @@ static u64 native_steal_clock(int cpu)
> return 0;
> }
>
> -DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock);
> +DEFINE_STATIC_CALL_RO(pv_steal_clock, native_steal_clock);
>
> static bool steal_acc = true;
> static int __init parse_no_stealacc(char *arg)
> --
> 2.43.0
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>