From: Yury Norov <yury.norov@gmail.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: I Hsin Cheng <richard120310@gmail.com>,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
jserv@ccns.ncku.edu.tw, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] cpumask: Rephrase comments for cpu_any*() APIs
Date: Wed, 15 Jan 2025 10:55:13 -0500 [thread overview]
Message-ID: <Z4faYaMwHymIWdps@thinkpad> (raw)
In-Reply-To: <Z4ewVu4WrzW9w67/@visitorckw-System-Product-Name>
On Wed, Jan 15, 2025 at 08:55:50PM +0800, Kuan-Wei Chiu wrote:
> On Wed, Jan 15, 2025 at 03:19:32PM +0800, I Hsin Cheng wrote:
> > The cpu_any*() APIs comment states that it returns a "random" cpu within
> > the given cpumask. Hoever it's not actually random as random itself
>
> s/Hoever/However
Hi I Hsin,
Can you please fix this typo, drop quotes around the 'arbitrary' word,
as suggested by Mark, and send v2?
Please also keep Mark in the loop.
Thanks,
Yury
>
> > stands a meaning for uniform distribution.
> >
> > cpu_any*() APIs are a naming convention for the caller to states that it
> > doesn't care which CPU it gets, so change "random" to "arbitrary" would
> > be more appropriate.
> >
> > Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
>
> With the above corrections:
>
> Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
>
> Regards,
> Kuan-Wei
next prev parent reply other threads:[~2025-01-15 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 7:19 [PATCH] cpumask: Rephrase comments for cpu_any*() APIs I Hsin Cheng
2025-01-15 12:55 ` Kuan-Wei Chiu
2025-01-15 15:55 ` Yury Norov [this message]
2025-01-16 8:12 ` I Hsin Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4faYaMwHymIWdps@thinkpad \
--to=yury.norov@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mark.rutland@arm.com \
--cc=richard120310@gmail.com \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox