From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B2578F46 for ; Wed, 15 Jan 2025 15:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736956517; cv=none; b=jhtpFI6b1Jox9pLE1uIxP9ZMlMylzgv1EG1RFXJboc5lLAc9CAY+babbimq40Fdojcft9LnHL0WtWQ+ib4TtyBsHCzHGfi3Wy8E5bu3PwPmIvOCiN6RNorYqjCK3UoJaGCTZZWl7vFzRRc/y2+zIkyg2AIFx4eNBOq+qFSd5aTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736956517; c=relaxed/simple; bh=pnTMNFiOe0Sr3yDXpyFza7O8ReV7MEbvS9NPzKuW/sQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U22EbOUxFbet3zQrEL9mQHLVkqHyBqsZsL6i3xSdYYlbFue0hSUHvVAcyt7V9a3hbkjHZ4IIjcG9Xwye1H3Fn3SdH0nyAL1OxPZnupxlMed7k+VcZIvmNqbzACgZp+XKanYuU9FtxazX3748usOLIIiNtnvGAb4G3YgeiOlgp7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Opm3UqMW; arc=none smtp.client-ip=209.85.219.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Opm3UqMW" Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e3a26de697fso11173045276.3 for ; Wed, 15 Jan 2025 07:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736956515; x=1737561315; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jSl0MBdKIse1+yB3OUPDjemy12vwrh1jhIp/T/+VnWE=; b=Opm3UqMWgGZtVDAgpGQQEQilgZl8en54MSlH1cQyZpDn9XIEx0sDyetGQezdxmjKEv 3pCQdM6radIxxKZOO06/OtUIIK1Xthl6GH08B/zqTOb2jV6snp5tK5XckuEivGSO9Dym zy91RTW0YMjzhDsb8ypv1HalS9xlevT2Up/a+2mRiavnDoYzToYpfQ170OeNzBg2oaJm mG51h3yvEnUWGwqWFGfRkukeAr2dGGPZy7GEbgQV4oMFZzs8h6RQDb+Q+AGcgTCvUEOv QkpxCs5fdDCrIqkfiM1LiDy+XoCI5H2cKlNh3bJmMvP4lPFM8iAVi9DFyNVmvk2pK7ju JYNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736956515; x=1737561315; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jSl0MBdKIse1+yB3OUPDjemy12vwrh1jhIp/T/+VnWE=; b=l+vDwvDyKhKOZ93U/sscn01xP8m1I0UiC7/vX2zHIZrzAbUl/XxKXWNll0GGTYIPKf FZHqjESjoDnhT4GOsUulcFCFbyNtmutq0xe8+jq/NryS7lgNUTZNmcwICB3SXUQ9rYyB 7+kmjmXOeFswp+naWX5Kp7u7/Pz2WsBYquLIimujeAgc9HWcUswYXx68G48ZeAnC6hlx TWmYeqdyVDtkiLVxiJGEr9boKlYcdNLNQPyTKAWAW4payJezOWeZDozex15myUr2bULC fTcbKGJvyz26fQsBlxCKTHZv7NIVOudSMTX5MkvzVpQg2WcZhtLf0ru8jSP4OZxTw7v4 TOGg== X-Forwarded-Encrypted: i=1; AJvYcCXmHVaN31iuuAUG50ZtPOd4k1gtR4P1O2bICkHqm+ZgD8SOT8ihQmT80v3NvJPC8+bKTTGnwX3mtjI+OH4=@vger.kernel.org X-Gm-Message-State: AOJu0YxSyMzYBU5vcxCZiHLhM2h0LBH81jxliOWiuTwQMPBftTHWfoO2 B5uKJnq0n1kj0IbJ6wl0gRuN/Cnb/6gLkFMqExT/w05RudVjACmggF94FFvV X-Gm-Gg: ASbGnctJPtTJ8tNfyAxzRitj0LR6gBp79s/LKpMQmJZcvX1AX8dn/5R4JOxr1Zt5LOf qAeqE4eWDWafFADADaafe4nJpOHm+IMf8h6oZ4zlTTUDezdtH6rPpAXl2vOoTVP8Cz6nrAc8qhN 13cIgQtPRPESUH2sp6WGA94ksEUR06uMDa8mQ8KsJFhV2i+NyTB1792xt5QY1dk9H04kLdSPTup wlUOTm4bJfwNDv5Gg3tXh0bKUYYyqRTE9G76pXJoYbxufOZHHzpizs= X-Google-Smtp-Source: AGHT+IHur1vaiXTZwLcQWY87ksSZYsMNRZhQbxwl7jtJLvo40KbUiVzF8B6hIl84YKBN0bnoWLut8Q== X-Received: by 2002:a05:690c:6b83:b0:6ea:5da9:34cc with SMTP id 00721157ae682-6f5311e631emr225947127b3.7.1736956514815; Wed, 15 Jan 2025 07:55:14 -0800 (PST) Received: from localhost ([2601:347:100:5ea0:a75:6411:350a:b866]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6f546c25df1sm25171897b3.12.2025.01.15.07.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 07:55:14 -0800 (PST) Date: Wed, 15 Jan 2025 10:55:13 -0500 From: Yury Norov To: Kuan-Wei Chiu Cc: I Hsin Cheng , linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw, Mark Rutland Subject: Re: [PATCH] cpumask: Rephrase comments for cpu_any*() APIs Message-ID: References: <20250115071932.43607-1-richard120310@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 15, 2025 at 08:55:50PM +0800, Kuan-Wei Chiu wrote: > On Wed, Jan 15, 2025 at 03:19:32PM +0800, I Hsin Cheng wrote: > > The cpu_any*() APIs comment states that it returns a "random" cpu within > > the given cpumask. Hoever it's not actually random as random itself > > s/Hoever/However Hi I Hsin, Can you please fix this typo, drop quotes around the 'arbitrary' word, as suggested by Mark, and send v2? Please also keep Mark in the loop. Thanks, Yury > > > stands a meaning for uniform distribution. > > > > cpu_any*() APIs are a naming convention for the caller to states that it > > doesn't care which CPU it gets, so change "random" to "arbitrary" would > > be more appropriate. > > > > Signed-off-by: I Hsin Cheng > > With the above corrections: > > Reviewed-by: Kuan-Wei Chiu > > Regards, > Kuan-Wei