From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FA4414F9FB for ; Thu, 16 Jan 2025 03:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736996964; cv=none; b=a9tucKUbrAI2yTmPBhmeSFiOJdTXzSAoDlYccwN6k0Pn9+RbxhS5TdkIPmHO5ylGiI34kajxYgXgCPO5/ONFJwOCVaSk/+47YewT8Bd6GCCqPSM+6Y5WsI4uLGg7dl6fzipBZDMKrlioXB+LwpzDmf5cxJtAJjh7a56j8AZ14sM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736996964; c=relaxed/simple; bh=YvT347LAFtvqLpCK4qt1Yi9x/NqEjZFWcuO80fdGZVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EThIzDa8TpZbPhwoSG+REhCW3o0iOIm7wHe/CFJZNa6VNbFKnWNglUf9nJ1nTVUTkXorP8l1wHju/UFGSf3ULbKn6+Qux620zPoHc6o64Lix+0sirSN4eXWlRkfkM4AtBdpj1TsjZK2gFjn6F+aRAJwvyk88kTGpdjDzt0LG7ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nbBw3K61; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nbBw3K61" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-215740b7fb8so73495ad.0 for ; Wed, 15 Jan 2025 19:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736996962; x=1737601762; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0k2tjWflbKcVqC6zMuhNKy98nVj8U7DcPtvNyfmp/OM=; b=nbBw3K61Xm9jUU6s+mbgYb6sEm7959mAkaX0M2A+a57neOTUGl6D5mf7sQoEVRrwyk qeqkb9v43WhOgrbypwYa3dtczs1No9uLZGFdM/BLPZjz93pYZzilHtvb4tibVapesPVj 8jDeMK6JATdu0JHqsUpBw82ALrz4XtO/I9jJ4U7On2fKShrxr+H20vbVS6Mg2mDiUMFl 1iBoA2u/UVzFV+hetMvh7X2Du8L0NwKRSAmsMJYiVdU78MZEAnnyKRTp0jUPbKdfbq7P Ot+7Yg2gY6tn8L/auLr3eEDcJ0ttQ/Mj90EP6QbkTQWlUtdLuc/Do3k6/v0+yNeySn/5 kgNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736996962; x=1737601762; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0k2tjWflbKcVqC6zMuhNKy98nVj8U7DcPtvNyfmp/OM=; b=b7rh0a4wlIkXk/yYaKYM4GdF6OrMewWHbtf70HAZoTIXUd9Rnc7xCtg7a/nukHoxZk 65PTXzCxbARFkQ9u3CFTLxbnAdlYSHR/Wfbf8EX8ZAe03Jejbz+QOxPWDaG97MREGqZ3 j+z0K/lc19s+kKra46cxUOHTpcE2wc4Je8q0iUPrxFQM0OC/1gendTSI/wfXfy429Os1 cK59zmph7iWi2+ymyLjxjqKDK1Kor2IXds6UH2xJojzlLuF7XJ4qi25zfZidncUou+dO JffYhkeKyh/JRZb+vJzq8MJ29eVic5fmSqWs0phIo59TwiYvTSVtrcr49r4ZJgAqAOlj bVEQ== X-Forwarded-Encrypted: i=1; AJvYcCXphAKeJvMwNsc6Cd5Xgf8QOXEzFKIIh6fFT8A8WoGuYrHkho8RnUvSdWda7E+flhPJxEnlwvfkKNLGdhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw627c+yGjuVP38Fh34TTLMhlPWuOGav8Kd4HLzOCD0jdGtkvyG ArIUfsr+36uB3m2sdpvln7yVqISNpG3xmHgxtRk+zX1uI6MGgrUFf0Xog0SyQJDl0gUDKZWPuaG lcY5I X-Gm-Gg: ASbGncs49dCg92mtKPCPcW8YBAupztKzD60tTCmkDmKciykm1AE/OEu6ovWgOuToWUt 9ducbFKNbICdByDjUSLsVjbI0QPWHJua0f4oB/H9awCk3vBKv4Z62oMweVy7hcOoMz00dRK1fxZ w/x5SUVfnvz8xI2WyB6FYmXQaWPCSpJH7HYGgz9BTtGVluWTfs70GlGmkiNJqWIRQnC7LHlE6gR tEH/g3xASaTDubcECR/AqiPyMRo6jN7eu65Evw9QuYLOfR7aUPEiRX+pS78KaGhb0D3YNPjAaqB 3ULAGtWSmHdH X-Google-Smtp-Source: AGHT+IHZcCbVA815LPJGb0bCjcocKzrwMS8Y8KUYeVaCrLeZOxiM8S63vOxnYqo99Qw0ZPV4r1BBuA== X-Received: by 2002:a17:903:443:b0:21b:b3c4:7e0a with SMTP id d9443c01a7336-21c165a4395mr788135ad.13.1736996962080; Wed, 15 Jan 2025 19:09:22 -0800 (PST) Received: from google.com (1.243.198.35.bc.googleusercontent.com. [35.198.243.1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40658b71sm9879160b3a.85.2025.01.15.19.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 19:09:21 -0800 (PST) Date: Thu, 16 Jan 2025 03:09:13 +0000 From: Pranjal Shrivastava To: Robert Marko Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, jgg@ziepe.ca, nicolinc@nvidia.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, luka.perkov@sartura.hr, kernel test robot Subject: Re: [PATCH] iommu/arm-smmu-v3: add missing header Message-ID: References: <20250114160630.1122885-1-robert.marko@sartura.hr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250114160630.1122885-1-robert.marko@sartura.hr> On Tue, Jan 14, 2025 at 05:05:56PM +0100, Robert Marko wrote: > str_read_write is currently undeclared and thus compilation will fail with: > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1911:25: error: implicit declaration of function ‘str_read_write’; did you mean ‘sb_end_write’? [-Wimplicit-function-declaration] > > So include the missing linux/string_choices.h header to fix compilation. > > Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202501111926.qOpnlK9J-lkp@intel.com/ > Signed-off-by: Robert Marko > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 0e4cbb2c64d7..a0e395da8a88 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include Hi Robert, This fix has already been merged to the arm/smmu/updates branch [1] which should appear in -next when Joerg next rebuilds the branch. Thanks, Praan [1] https://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git/commit/?h=arm/smmu/updates > > -- > 2.47.1 > >