From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH v2 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"
Date: Thu, 16 Jan 2025 18:13:31 +0200 [thread overview]
Message-ID: <Z4kwK6JCm5RDI4nG@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0izBnSGjmjO7T+_gEhrSib0==_bRXnsLEdzEjbH0cZDqg@mail.gmail.com>
On Thu, Jan 16, 2025 at 05:09:29PM +0100, Rafael J. Wysocki wrote:
> On Thu, Jan 16, 2025 at 4:44 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The introduced macros are not doing what they intend for, namely
> > they won't eliminate the code when CONFIG_PM=n.
>
> I don't think they have ever been expected to eliminate the code then.
> They just don't export the symbols in that case.
Then I'm really puzzled with (potential) usefulness of them to begin with.
Having a dead code that is not exported is doubtful benefit.
> > Also there were no users of them for all this time.
>
> This actually is a good argument for dropping stuff.
>
> > Drop them for good and to avoid possible misleading.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-16 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 15:43 [PATCH v2 1/1] PM: Revert "Add EXPORT macros for exporting PM functions" Andy Shevchenko
2025-01-16 16:09 ` Rafael J. Wysocki
2025-01-16 16:13 ` Andy Shevchenko [this message]
2025-01-16 16:27 ` Rafael J. Wysocki
2025-01-16 16:33 ` Andy Shevchenko
2025-01-16 19:18 ` Rafael J. Wysocki
2025-01-17 13:39 ` Andy Shevchenko
2025-01-23 20:23 ` Rafael J. Wysocki
2025-01-16 16:55 ` Richard Fitzgerald
2025-01-17 13:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4kwK6JCm5RDI4nG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox