From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs
Date: Thu, 16 Jan 2025 18:24:50 +0200 [thread overview]
Message-ID: <Z4ky0iNJ9yE06l3g@smile.fi.intel.com> (raw)
In-Reply-To: <f5ce40f3-e261-43dc-9496-fef609e8be14@sirena.org.uk>
On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote:
> On Thu, Jan 16, 2025 at 02:43:30PM +0200, Andy Shevchenko wrote:
> > Besides the fact that currently defined devm_*_free() APIs
> > are being unused, it's usually a sign of bad design to call
> > such explicitly. Drop them and make people pay more attention
> > on the misuse of devm_regmap_*() APIs,
>
> This just seems unhelpful, there's fairly obvious uses for something
> like this where we decide we can't actually use some things based on
> what we discover during probe.
It's an effectively dead code. I rarely see people are using devm_*_free(), and
when it's so, it is most likely by misunderstanding of the concept. For what you
described I don't remember any _practical_ use case. Theoretically any dead code
is useful, but it's not the point, right?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-16 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 12:43 [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs Andy Shevchenko
2025-01-16 16:15 ` Mark Brown
2025-01-16 16:24 ` Andy Shevchenko [this message]
2025-01-16 16:41 ` Mark Brown
2025-01-16 17:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4ky0iNJ9yE06l3g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox