From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1CBC190052 for ; Thu, 16 Jan 2025 21:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737061766; cv=none; b=MDivCNLsUyKNQ38qiCgYJTTccP7hDEoBskUlOgt1ZLyVRfNBMvckQ5ITaeCDHG9BcMBxr5cSuBSJbLA5iVEV8UqlaQrxqbSgAYRhfZayqq6A2rAMKtKvoA7J7rHT/ePLdxBKexs9PkYD3kATE3+ca/P6rhlUB4ZHqayVpanQtPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737061766; c=relaxed/simple; bh=KE/Cs3hnYIUKphXNAbBOON1S4PYwNM97TbB+pLw8evw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVwkYOFmoWtiRRjgRpOVAcyOTyiMT266ORw56q3xfJE43UZT4+q88S0fO9auB3MuD4dfTBqa2Kji9pcwUuvdMInJfzzCptsKZrVpDWoS/lJVSqpkm6OddT/eTX6HBQ4eFN7GFJNVJE1/6pnL+B0H5TEuscX8O825BJ3ZnuVIe4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=hLjs3b7m; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="hLjs3b7m" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21675fd60feso31645955ad.2 for ; Thu, 16 Jan 2025 13:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1737061761; x=1737666561; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xLy6fiGQSiUhs1Gv7gi/9ehtHmgmcyfRdTPntzghr9M=; b=hLjs3b7m5vDGfCpfbohVM1FWeo6eIVIRPzoJVa93QDsH7P5L8nc42mYIurTh2bXzvF ArwO5+HLX9MQJ0MXxxluTfArccdmSJFaF1hf7BnQ5lHCiwmNlHVDDsyfdQ7Zm0VQz2bU 1g5/6jQvrqmGBNeJmAk+H0HDgoo7OLf9Ruqzx+P36BoBPxSUhjbhsDNOnxDxb6C7X3Ue 6NLRZFJHA48N5rOgWA0rJciWnwvHy4SzXOTlRXjE5kZD+2c2IgglJPyl/xRjvPlbf9If JNec86ef8HJapBOKQyAQH1Yt4PRYKWsPO+rWuw17W0zX14PzyfXNgMwon5E7iWI9C1t8 N97w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737061761; x=1737666561; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xLy6fiGQSiUhs1Gv7gi/9ehtHmgmcyfRdTPntzghr9M=; b=ZMbVLXK7fwa7bNJ4/iANdoU/mIQow0aCxeCuIbT0oD6V6v+EG4UDF9GbeBS3rIScSH +LoGn9WVFy8sE8gqgQgo2X1Hn5p1hOsdo/Wvvf8dXTxnsuQ0iauvSCE5w7S2aadfy5bN Moma51lq9NNVRzVPdJ3MH91qggAnfRPQdPeCVV7+vGR0FhURFg4Z/gH2id+qLINKTZ7K AjpXw4sbhEl/vlk0XARxFN/ZvqKxfOs620vRurTJOIwHmlIT1NYjTF775HUr5BfiI32Z 8JK4cmNiROcp2VLn7jfht1yhV9yviyErNLSrpkkzcN/Wh4fQBsTBkIYEOqNd85irYY3u A/iQ== X-Forwarded-Encrypted: i=1; AJvYcCXicV24IxL6GtXLdX4VYaNlwxhDr+gELrocNu3nUHFXuU/oeLM+Y8fkx0Vey8xJ+vllJrG0bGwOoGf7W+s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Ix1014HkdjvbWjVLFtP+L8R5iERkO9k0TcvM+akZmVvADA1Z 25vyVDX0UhJbTTtmEii5R+fKStraVq2WzGow7ULcEkSm37fCJtWsSusL3V9Qc9g= X-Gm-Gg: ASbGnctpzfT+khF/IRobEXoqvZfG1yevTMD/caqU5ai0VJ7FJXaloeoUmjgDoNcLbHG JCo9+fmBS6HF0zu40KOVhT4gWS8drflq2YQgj5du0sHoxPPdGbhZ/QKa7LtJbyynJSRAQ/t0gYj cRA0EwzeAh4olcCkGEZp0sY8De2UumsnHy08cucFW45qNVmX0YxjyQrOzs+VFnf1DHNQqLFDaus MY5Mq1+yoZn7cLdJyqFlLEkZcG1Ij9ob1GXt1DrWN1PILk= X-Google-Smtp-Source: AGHT+IHn8r6fyORqvt70F1/RiXRVvEfOUziTFNpWxfLgt7XnjW5G2Mmw6jp8xmfIuHpGfdjO4Hfobg== X-Received: by 2002:aa7:88d1:0:b0:729:35b:542e with SMTP id d2e1a72fcca58-72dafb90892mr371241b3a.16.1737061761171; Thu, 16 Jan 2025 13:09:21 -0800 (PST) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab9c8e37sm429311b3a.119.2025.01.16.13.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 13:09:20 -0800 (PST) Date: Thu, 16 Jan 2025 13:09:18 -0800 From: Charlie Jenkins To: Xu Lu Cc: anup@brainfault.org, tglx@linutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, lihangjing@bytedance.com, xieyongji@bytedance.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: riscv: Order normal writes and IPI writes Message-ID: References: <20250116120710.51673-1-luxu.kernel@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250116120710.51673-1-luxu.kernel@bytedance.com> On Thu, Jan 16, 2025 at 08:07:10PM +0800, Xu Lu wrote: > Replace writel_relaxed() with writel() when issuing IPI to ensure all > previous write operations made by current CPU are visible to other CPUs. Did you experience an ordering issue from this? - Charlie > > Signed-off-by: Xu Lu > --- > drivers/irqchip/irq-riscv-imsic-early.c | 2 +- > drivers/irqchip/irq-thead-c900-aclint-sswi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-riscv-imsic-early.c b/drivers/irqchip/irq-riscv-imsic-early.c > index c5c2e6929a2f..275df5005705 100644 > --- a/drivers/irqchip/irq-riscv-imsic-early.c > +++ b/drivers/irqchip/irq-riscv-imsic-early.c > @@ -27,7 +27,7 @@ static void imsic_ipi_send(unsigned int cpu) > { > struct imsic_local_config *local = per_cpu_ptr(imsic->global.local, cpu); > > - writel_relaxed(IMSIC_IPI_ID, local->msi_va); > + writel(IMSIC_IPI_ID, local->msi_va); > } > > static void imsic_ipi_starting_cpu(void) > diff --git a/drivers/irqchip/irq-thead-c900-aclint-sswi.c b/drivers/irqchip/irq-thead-c900-aclint-sswi.c > index b0e366ade427..8ff6e7a1363b 100644 > --- a/drivers/irqchip/irq-thead-c900-aclint-sswi.c > +++ b/drivers/irqchip/irq-thead-c900-aclint-sswi.c > @@ -31,7 +31,7 @@ static DEFINE_PER_CPU(void __iomem *, sswi_cpu_regs); > > static void thead_aclint_sswi_ipi_send(unsigned int cpu) > { > - writel_relaxed(0x1, per_cpu(sswi_cpu_regs, cpu)); > + writel(0x1, per_cpu(sswi_cpu_regs, cpu)); > } > > static void thead_aclint_sswi_ipi_clear(void) > -- > 2.20.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv