From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs
Date: Thu, 16 Jan 2025 19:51:52 +0200 [thread overview]
Message-ID: <Z4lHOJ68VRdJG3j_@smile.fi.intel.com> (raw)
In-Reply-To: <4f001c94-423d-4377-8647-81a41f69d1b2@sirena.org.uk>
On Thu, Jan 16, 2025 at 04:41:36PM +0000, Mark Brown wrote:
> On Thu, Jan 16, 2025 at 06:24:50PM +0200, Andy Shevchenko wrote:
> > On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote:
>
> > > This just seems unhelpful, there's fairly obvious uses for something
> > > like this where we decide we can't actually use some things based on
> > > what we discover during probe.
>
> > It's an effectively dead code. I rarely see people are using devm_*_free(), and
> > when it's so, it is most likely by misunderstanding of the concept. For what you
> > described I don't remember any _practical_ use case. Theoretically any dead code
> > is useful, but it's not the point, right?
>
> The use case would be to read some ID registers in a subfeature then
> decide that it's not supported for some reason so we'll just ignore it
> at runtime. Given that you're also complaining about there being no
> current users there doesn't seem to be much problem with misuse.
Yeah no users — no misuse :-)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-01-16 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 12:43 [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs Andy Shevchenko
2025-01-16 16:15 ` Mark Brown
2025-01-16 16:24 ` Andy Shevchenko
2025-01-16 16:41 ` Mark Brown
2025-01-16 17:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4lHOJ68VRdJG3j_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox