From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05DED153808 for ; Thu, 16 Jan 2025 17:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737049918; cv=none; b=o6wxcdPQwkbnAWLXObVO4+3jb3arVDg4j/1ZWcnqN0FIf9hi4xuQQprVYo2aW2E6Wbm2hjvSLQaMLs7ds0FAmop6sHOWMF5z+nByKzqjOlcFrTIHNP5Tvx7jDNOUejRugCVS/ZSoAAfkpFDwAyI/kLKP4+DIgCiCoyk82jr32qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737049918; c=relaxed/simple; bh=Q4JLlqyrIka4ga3A1XpdjvQUYRv1vH/Ri7KD2zE6gsg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JZWwyHHivQ643ZuF9oFYdeBXKxoqfSVBAcCdWTUegY+hi9G9dgMalGsN5xsmrHfOd57qon4rFkj0jqi3jOxsvyg1I2VIs/FHrcpiH5FcqIIY9CdBVyk1Y4EinXefBuoWI3OosG76iO1QkJ04PSFKwim06tdeKVYgZxTN6EFmYbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aUjhHsx3; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aUjhHsx3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737049917; x=1768585917; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Q4JLlqyrIka4ga3A1XpdjvQUYRv1vH/Ri7KD2zE6gsg=; b=aUjhHsx3jc8hNnftRDg4QRrliirve9ZiqMYEgyU+z+1CVoQaBPTSllFO mgWqHkJoXSzRnwm8jg483uLNr8wqdds3Dm3Rjey2Bq/f6KXkbEtAv6SYX KXTAodTrW2w4h6d8eLaZ9DE+GrWJ4rGx5uJw9YGN6D95ITQSqLgsfK8v6 CvECIzFnF8IUKi1pN1eakeaYCnhQwwRU5obUpxL8YEdtRc6724NAArIWK 41ZcA7EAyOYFJ/E+A19Yaz90fAalrXqlAEoC6L7TJ4tWqiGYOu9cHkFNz Xgi349iCEnYrklcFFOmyFuyOtjnFP2ldnbDbpImWfC5JPfjAuaOEyB7c+ w==; X-CSE-ConnectionGUID: ndcjSVuARj2NTEYqHI/Hgg== X-CSE-MsgGUID: Tnw+h4zwQ9ecNZNA3qMZxw== X-IronPort-AV: E=McAfee;i="6700,10204,11317"; a="59930354" X-IronPort-AV: E=Sophos;i="6.13,210,1732608000"; d="scan'208";a="59930354" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 09:51:57 -0800 X-CSE-ConnectionGUID: M6nt9gfaRE625JLDP/x8Lw== X-CSE-MsgGUID: H06Wsf4YR5ukAmehKCc0Dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="110552642" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.154]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 09:51:55 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tYU24-00000001lnS-46HY; Thu, 16 Jan 2025 19:51:52 +0200 Date: Thu, 16 Jan 2025 19:51:52 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Subject: Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs Message-ID: References: <20250116124339.3941636-1-andriy.shevchenko@linux.intel.com> <4f001c94-423d-4377-8647-81a41f69d1b2@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4f001c94-423d-4377-8647-81a41f69d1b2@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Jan 16, 2025 at 04:41:36PM +0000, Mark Brown wrote: > On Thu, Jan 16, 2025 at 06:24:50PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote: > > > > This just seems unhelpful, there's fairly obvious uses for something > > > like this where we decide we can't actually use some things based on > > > what we discover during probe. > > > It's an effectively dead code. I rarely see people are using devm_*_free(), and > > when it's so, it is most likely by misunderstanding of the concept. For what you > > described I don't remember any _practical_ use case. Theoretically any dead code > > is useful, but it's not the point, right? > > The use case would be to read some ID registers in a subfeature then > decide that it's not supported for some reason so we'll just ignore it > at runtime. Given that you're also complaining about there being no > current users there doesn't seem to be much problem with misuse. Yeah no users — no misuse :-) -- With Best Regards, Andy Shevchenko