Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs

Andy Shevchenko
2025-01-16T16:24:54Z

On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote:
> On Thu, Jan 16, 2025 at 02:43:30PM +0200, Andy Shevchenko wrote:
> > Besides the fact that currently defined devm_*_free() APIs
> > are being unused, it's usually a sign of bad design to call
> > such explicitly. Drop them and make people pay more attention
> > on the misuse of devm_regmap_*() APIs,
>
> This just seems unhelpful, there's fairly obvious uses for something
> like this where we decide we can't actually use some things based on
> what we discover during probe.

It's an effectively dead code. I rarely see people are using devm_*_free(), and
when it's so, it is most likely by misunderstanding of the concept. For what you
described I don't remember any _practical_ use case. Theoretically any dead code
is useful, but it's not the point, right?

--
With Best Regards,
Andy Shevchenko