From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4751427456 for ; Fri, 17 Jan 2025 01:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737077854; cv=none; b=J3JaULlRtyZON/OOodwJy6x7WliPiOeqAUzbg15Gl/9RTVPzrXDfB+dXEZzGWzryBgFyg/44BCijbE85q03NxxP9gj/5U81NQVn5RmrEZssmlE42kajmsceB8Uv7B8DH2x4+1zlx7fd/ap0+RPQODWteh3trjyBJz/dl6ALeZHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737077854; c=relaxed/simple; bh=vuTljDy5KeFuOJGHOxIEU3/xGl9zWcsaPdGyt16Cdyc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HnNWnk0vpq2I2XSS7NKH/YLdg6+8OHHlnHEaYV24UswGeiHyHEm49sOJVVWcFSIRxuVAWREtepq2k3uVIuyOqk4bTlbbm/3kV8/nAMAJIoKJgKtNBfD63PRLgWLtJT+uVFohqhFY1vwOBWbr9mV7TEVjHR8gzUlyIBxwYN5lUcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IGqicN+B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IGqicN+B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A55E0C4CED6; Fri, 17 Jan 2025 01:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737077853; bh=vuTljDy5KeFuOJGHOxIEU3/xGl9zWcsaPdGyt16Cdyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IGqicN+BhzJdHJ3JkdtFNRUlR7rcjxuvoFwy4KkMLhvbUCiCw4DGwQtbDeqmONvYd RpRPtudUDm05BvG1p+uMHQyzIQqraqCsQa9aOq/SP2jDawOV1W8gKBWD0wzKQ0wd91 D7/jCgy1pEG9HAQy//YJfoWDQ+pqO/5D5QvxdfRfnpq12/yc4gh5AVDrORURJWmgKk 5+52W4aJmAmYpGknc4Keqh9BIpKUGNxecMSWcL+Z+kFyza56xyM0+hzGG2YJV3xffV rAaw69hE/pvdYl7ErhSDDb3xGL0uuNYhhJFJMLFUk3eteMelEe0jFtk14CzpgIlhhE b5hCcNPnkLaUQ== Date: Thu, 16 Jan 2025 15:37:32 -1000 From: Tejun Heo To: Changwoo Min Cc: void@manifault.com, arighi@nvidia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] sched_ext: Add an event, SCX_EVENT_OFFLINE_LOCAL_DSQ Message-ID: References: <20250116151543.80163-1-changwoo@igalia.com> <20250116151543.80163-3-changwoo@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250116151543.80163-3-changwoo@igalia.com> On Fri, Jan 17, 2025 at 12:15:38AM +0900, Changwoo Min wrote: ... > diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c > index 7e12d5b8322e..8054e4e5ed0c 100644 > --- a/kernel/sched/ext.c > +++ b/kernel/sched/ext.c > @@ -1467,6 +1467,12 @@ struct scx_event_stat { > * the core scheduler code silently picks a fallback CPU. > */ > u64 INVAL_SELECT_CPU; > + > + /* > + * When dispatching to a local DSQ, the CPU may have gone offline in > + * the meantime. In this case, the task is bounced to the global DSQ. > + */ > + u64 OFFLINE_LOCAL_DSQ; Let's do components in descending order + event: - SELECT_CPU_INVAL (or SELECT_CPU_FALLBACK) - DISPATCH_LOCAL_DSQ_OFFLINE Thanks. -- tejun