From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F255E22FE00 for ; Thu, 16 Jan 2025 22:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737068334; cv=none; b=hwjxBHSBh7lNJr8Kh/eATVJKjG3giR1ZcAscMtHo1JmO/w2H6GPbxTYQzGtLUAtqLDfIPJhUvzjdZXr7l83aDyachLe5EJUwvXkYXJYqeqouBDkJnyyEwqWvvFw3QlCqHyicPElYAoPmU8GGIKj4cpd3xeBd2YKBtICfaqKw8Ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737068334; c=relaxed/simple; bh=g13QriG2HaYgqb0uLffYe8D5Ap9JtELmtfDRmSibjnI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kt/0PULZDynNVf6BZoCBd3Q8HSIXSrhMjkv4aWFvNfe3Yb6syoLyhyLUBR6ElDrb4VUnip+myphGaTt6ajktw8YC5PUYbZ6G+ITpC+m66OUd2GDvRAvXjU9r93RDfIWUK1oXxcryopD7Vb5lIQV5PGfD33nv1XDaKV0esCBfims= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QOUhFgNJ; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QOUhFgNJ" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2ee709715d9so2194539a91.3 for ; Thu, 16 Jan 2025 14:58:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737068332; x=1737673132; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IvMp8UJ+AUZmpf/2T1YDxrAGfWL2IguTr0D7rYDEuSg=; b=QOUhFgNJ2+0ON7EUYK9O6n6TpDSOx1WMrJ1BeQBLsBAbdUxBgtaLXHxYBezNng3qYg FlC4TclTNR4ycZ4SI63i79aHhrqA0JLjrhy7T1YbwzaugaxnucdbeD9shig66lSsO3QO qXGrTyISRdffPxRbjm0Gxhip/UvgYlQxGLvjmXaMK/per2Ei0gr0qtREg+nua4Ku0r6h mT2ChIRCpM1uizDxIPCBmZWTusgQsFW0mOif8SDEPGWQ1N47PYHt4lO0SqX72Ch14sli aNRnmMf1uLhhK1+CCneJEGqUNArsWrNwEi499HGEzK/ekaHwCIdISvlsFqDyv1LizxkH eirA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737068332; x=1737673132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IvMp8UJ+AUZmpf/2T1YDxrAGfWL2IguTr0D7rYDEuSg=; b=CYAdNkn7k05XLVyAXL3m9LNf6DbFzTpYEUj05m0MfA9nUTA9jgD2ATlBbXk7PMvLMK hqBrWabfj9ozXnjTv8TP6HoJzOo2rdleiMm7TrVqf+1rd1hc8L54dFE9M3ndMWlmqE9q cZA7AUdpW3m+w50K5f/Kj1mQUCx/72v0hDDhjCDvb1wzVl93Zynwoz06Mh0omBseNCXJ lEzHODxNMlInn92ORFs6MFyXsvHpdpqBq82wh4HsmPEA4CFM5JmL/f0ef5YNozvbWHdD M7UFviYpSbi1i9yO1Ri1ASgTLvls7IVYSyJTHFjruPA9HFVeLrFQoTtESwXSOPqUqAyb 1aRA== X-Forwarded-Encrypted: i=1; AJvYcCXOmLANiJ+Y5EKx4XKkIRQ0rGaTtIM494Z3qOV/1HS4HCQmPh0lPFZ0lH/XruE7b0FEJnMoNDh0alZdAKE=@vger.kernel.org X-Gm-Message-State: AOJu0YxxZUx3N80Aa8cqigcA06fcFqR+m12dtq3s/ASsheWpRZbB9RM8 kTFoE/5j38cg0I3hFn+KWKCdRb1Jso70WPEzuRA4B0LUUilD0tohIHCD5JQs4g== X-Gm-Gg: ASbGncttrLt0rdMrhalhikOkXs4skymhPLmm99pWBRWuvO3uAom9+njZmLhzL6zkZ4J ftoNA0qwX/F3G1/G1nBSBnWNPeqmRQzzq3Sy9Q6/SPNVdEMCzzFCZ8YcodztCa/eke6IC6GJKo6 L6FM+aBNQ47VfodcUuKE8nH+bDP5+UcUZTV6ETUGjI6VYgeMLGZ/oLbtIs//27Rjw0srYmZ5eaV pDJBneMIOL1gC5mhzaxSX5Ztpr2LKL/6rj464KEAj2sS8taTCQfIVJP0AQSBqk0WPZpdiA1kT3L LJLZx4ijmwqF8Q== X-Google-Smtp-Source: AGHT+IHI0gnCSzyJPMRPrLaAscBds4qE3vC5wbmKSUGCK9b/EKZJbpAOYjrqiqEA0exBtUcdYrt1Uw== X-Received: by 2002:a17:90b:38ca:b0:2ef:316b:53fe with SMTP id 98e67ed59e1d1-2f782d306dbmr434742a91.22.1737068331992; Thu, 16 Jan 2025 14:58:51 -0800 (PST) Received: from google.com (28.67.125.34.bc.googleusercontent.com. [34.125.67.28]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f77629bf96sm715296a91.36.2025.01.16.14.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 14:58:50 -0800 (PST) Date: Thu, 16 Jan 2025 22:58:46 +0000 From: Benson Leung To: Stephen Boyd Cc: Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org, patches@lists.linux.dev, chrome-platform@lists.linux.dev, linux-watchdog@vger.kernel.org, Lukasz Majczak , Benson Leung Subject: Re: [PATCH] watchdog: cros-ec: Add newlines to printks Message-ID: References: <20250116224605.110870-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pw379ZAJmMFLjC7o" Content-Disposition: inline In-Reply-To: <20250116224605.110870-1-swboyd@chromium.org> --Pw379ZAJmMFLjC7o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 16, 2025 at 02:46:04PM -0800, Stephen Boyd wrote: > Add newlines to printk messages so that the next record is more easily > readable. >=20 > Cc: Lukasz Majczak > Cc: Benson Leung > Signed-off-by: Stephen Boyd Reviewed-by: Benson Leung > --- > drivers/watchdog/cros_ec_wdt.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wd= t.c > index ba045e29f9a5..716c23f4388c 100644 > --- a/drivers/watchdog/cros_ec_wdt.c > +++ b/drivers/watchdog/cros_ec_wdt.c > @@ -58,7 +58,7 @@ static int cros_ec_wdt_ping(struct watchdog_device *wdd) > arg.req.command =3D EC_HANG_DETECT_CMD_RELOAD; > ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); > if (ret < 0) > - dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret); > + dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret); > =20 > return ret; > } > @@ -74,7 +74,7 @@ static int cros_ec_wdt_start(struct watchdog_device *wd= d) > arg.req.reboot_timeout_sec =3D wdd->timeout; > ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); > if (ret < 0) > - dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret); > + dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret); > =20 > return ret; > } > @@ -88,7 +88,7 @@ static int cros_ec_wdt_stop(struct watchdog_device *wdd) > arg.req.command =3D EC_HANG_DETECT_CMD_CANCEL; > ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); > if (ret < 0) > - dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret); > + dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret); > =20 > return ret; > } > @@ -136,7 +136,7 @@ static int cros_ec_wdt_probe(struct platform_device *= pdev) > arg.req.command =3D EC_HANG_DETECT_CMD_GET_STATUS; > ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); > if (ret < 0) > - return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus"); > + return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n"); > =20 > wdd->parent =3D &pdev->dev; > wdd->info =3D &cros_ec_wdt_ident; > @@ -150,7 +150,7 @@ static int cros_ec_wdt_probe(struct platform_device *= pdev) > arg.req.command =3D EC_HANG_DETECT_CMD_CLEAR_STATUS; > ret =3D cros_ec_wdt_send_cmd(cros_ec, &arg); > if (ret < 0) > - return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus"); > + return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n"= ); > =20 > watchdog_stop_on_reboot(wdd); > watchdog_stop_on_unregister(wdd); >=20 > base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532 > --=20 > https://chromeos.dev >=20 --Pw379ZAJmMFLjC7o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCZ4mPJgAKCRBzbaomhzOw wm3iAP0Z7Dg/5jcSL4eji0cptrtvNWyhVdS51qVX3Tnlw+bADgEAjjcwFG7aUqYQ ahmXBLry1zvisbI5crLJC4Jadbo2rwY= =ppxp -----END PGP SIGNATURE----- --Pw379ZAJmMFLjC7o--