From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09DB61F8AD4 for ; Fri, 17 Jan 2025 08:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737102871; cv=none; b=k6hxJbQ99tULsT++ghTHM//fdQmRC/DC5YDWoQpIfWiO1ms4mbOJuzXWnVYFYnmpXIPA+/LuvHf2004PM/uCWiq8CqhuXNZ9JdI1yZ6sWwOopJd4q0yuoIXlDoMJPOFRXnHl3Cvx6ti7isQqYEK9cly6w/+PO89PaLxl9TFG1n4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737102871; c=relaxed/simple; bh=sOGKnN21SydKR7OjQwmd45VUVjnqidbSZRg3IVAn+sk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KEnBx8xJHo8gNZ+DDKVfCCb10tiFoxa4H5CDl4F458l4VvueqqMUt5WM75UMtvZmhRZv+i/KIOD86D2Y53nP6tOhKqRpghCsPxGuzu5kGFjIGFYeGGQ5sZOZXsmXkjmAOpXAO7BJPQyFx46ft2KOyxpk70azD+0jxKdIUfNLm4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rK8qtf9K; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rK8qtf9K" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2163affd184so75655ad.1 for ; Fri, 17 Jan 2025 00:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737102869; x=1737707669; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=84rMYzUqq4y85KkEDWY3HmzD2Qa5Sp+w6owgX1xBktY=; b=rK8qtf9KTbaYfo8vuXmCMjicl17CpEkDUHfReTS3bbxqGOrVnhicHafv1aD3ypjmPP sNSpiDLzG0042QjjkV9bEHUWX5+j7HttkjHxs5ZzcRL+/9EgMY9I9whC3KvDP8nMNAYw rgAkBkdmrbgNE3iAj30ARWuMSOqUUtTx4X7Gv1ZrqfJGmrJBDVIKzXMcqkXi2HWMmI3B NIHN/cKAEUXaExSAd3LAhbsFsTFp/bdss5cclKrdCVeF7kf1pSeCQItbatTY6cEu9/y4 cADf7z30qILgsVGlG6mg4lcItonJJ290d3UeHGgRYFhrQ49LdMY4TELqSq/xwvkwLid2 dyQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737102869; x=1737707669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=84rMYzUqq4y85KkEDWY3HmzD2Qa5Sp+w6owgX1xBktY=; b=eQjRCrpX3Kwmq+7bxx6JDAE1WZwRMiSjJ4B5a2o2ujKMDKWop2mLEfHpTXxWmd8Epl 3SsrgAUZ7PoZbkgGd+Ah1P/T8lRWwi0waj1z6VlK2V4llK5Cks6KSC1wn0EGSCx6Imw6 b3B381IaVRjHoRXzax38+G6esURahG+oOrwI7N5H6jBA0RqHxHbbAX/UbX/OLpeJoLnc Myxri1WffYwXurtsJnjYO8shxV1Vq9adQzWlHQq4IFa3lGjmhFie7Ye4h5fSu8uAR22p KmTfmG6bHSiUAtPnC7r0CtqEzejnc6TUotzJJvgy9zgQ4iKqxHNKtE/dfX1BU2NO69KO a25w== X-Forwarded-Encrypted: i=1; AJvYcCWfOjjyH40SzD1hGo6GchjzCRXvV87WoNAzyX3M6E2iRVffNDUVE3CeI0+kiRrPjg0mGIdwUf2SvGVnkT0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+MkOwJvLkRI33vLjHx90Sxz9PrKmWijygmtkr/iXGGBjnOhml L2Z1WR98KkFt0GkLNabl+XoCpMStNNQg+0xK7KBJma+WakWcTUKxxkqbCeXVsw== X-Gm-Gg: ASbGncv5MGGzK3q7WhWjw7IxDlUUvnI89ZLCOR//I22tnXcqcjfBGGNpctMTTAGdtaL fgyyDdMiseh5oZR3YQBcXNu8ku1IwPcSsVXLLlcIOEL2+Azzy96imAVyCdZFz697Cq5dyhKHTn2 eg0Pdcmqpy6JdVbgeSt4t2pUXGsCM3DGL7mNOnBENexasM9+coYxJ/oBMEUiS/K4qS0b4aUuPFU 3i+GWWYZLFyoh/IG53cuwrOztjYvLKcB34nyiflZgplop6dvmVXVUzUy0bvCS4H7l2MkX3Q+9/Y VO39kekijCvq X-Google-Smtp-Source: AGHT+IE7mqIl7gVi27tsigpFfH+LHplATJtz4D0uDOw0zsnmgSdBynTa28sifGUpSwSM2ArpqhIfWA== X-Received: by 2002:a17:903:3285:b0:215:884a:e8d1 with SMTP id d9443c01a7336-21c33430be1mr1851675ad.24.1737102869074; Fri, 17 Jan 2025 00:34:29 -0800 (PST) Received: from google.com (1.243.198.35.bc.googleusercontent.com. [35.198.243.1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7761a713fsm1422341a91.25.2025.01.17.00.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 00:34:28 -0800 (PST) Date: Fri, 17 Jan 2025 08:34:20 +0000 From: Pranjal Shrivastava To: AngeloGioacchino Del Regno Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, jgg@ziepe.ca, nicolinc@nvidia.com, mshavit@google.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] iommu/arm-smmu-v3: Include string_choices.h header for str_read_write Message-ID: References: <20250116121025.118464-1-angelogioacchino.delregno@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250116121025.118464-1-angelogioacchino.delregno@collabora.com> On Thu, Jan 16, 2025 at 01:10:25PM +0100, AngeloGioacchino Del Regno wrote: > The str_read_write() helper function is defined in the missing > string_choices.h header: include it to resolve build failures. > > Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs") > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 0e4cbb2c64d7..a0e395da8a88 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include > Hi Angelo, This change has been applied to the arm/smmu/updates branch and should be available in the -next when the maintainers rebuild the branch. Thanks, Praan