From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2085.outbound.protection.outlook.com [40.107.236.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700CF1F7905 for ; Fri, 17 Jan 2025 09:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.85 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737107405; cv=fail; b=XLLo3QOXStJF9pmK3kJckFWjTBWn/Ql05fLiNNKtLcV0vTqBrYIkYwQ8szudd27JktMnCdNMq3QIJ8eEF295nlhQ41N8nEnzm5govqsEIJYryfvtCrQvwBv7y6qV8lcnScsc5CCGRELCYJSlET5Chpzm8rxsS/1+N4FDDsnXYWo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737107405; c=relaxed/simple; bh=B+BfOIUvRQ+/Ue0utQWdb9fkUVr9yzEVpvdR9vnd4S8=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=jGxmhon1BjvDYsXGl555pbd4n943xJroglNXssEAkah6XfE3C4LlEExhymWomgR9d3pwGh5Bj5YmdtI2Hy2iRPGSIBQMFp9Kx9ZqACTZoTaChqFbj+rCeNfcz70RKGGKAibjSrTT3kPr/xL2gl3pXsE2lWAGod1pWMM9zL1Z7T4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qUmyOQlV; arc=fail smtp.client-ip=40.107.236.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qUmyOQlV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fEoM0OnPgQ780KK1uzAq9G6mYNpUgUWHonGHIaNNoqwyJtSdQvpeFaxomZHXzKvRH2hn8SiQshk9z/kkL37Z8Xm0VmLIb3ZV4ICheIL5SdaDGFn3VAF0aIGRx4qz1xEKpk9hjlOwx4QY7vcEid95rSHZu+n/0x1GGIPslZaBZsbeVmkTm54ytZonYkNUYFmUNDpsmwmHn2nU3BqW80nKaM4Ktl7KoyiGLhF8iA2WyDjB06RC7wsRqq8wLkVwcjkMBPqkXHA0NPG3c+2iZvlJlCloXXnLBoaXe57j8fQqe+JMVrm3WobEKpTztYPJWmipaF+WyrgeZubQnfSODPcavQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+BfOIUvRQ+/Ue0utQWdb9fkUVr9yzEVpvdR9vnd4S8=; b=qDxwzr3xsZhlXoB0xWIi0Tl1C8O+LkMJ8XgdkS6AwJe2HWQFeClwOoIH7qHXxqMWEbq5M20vGOM3ndQ2Frplvu997UM4nsgeQTFmgkJtx6bwX332SXDc8sY7EBiILWNEqQn6JDNUkx8ohnBc5cCZSWKeMudyGztDmQXRbGkMjzK2WamNxHY2D8n63jG2RBFaTLxYe4LvgVLpHxsNhppxsQjLkHr+rsUv8GU4pz6MhBv02OE7XJRxo7ONPJTz3n3vED3AVGGZAuniCuTkdD2cQOs079eaDCiV1+Qo41nT81QA0JdM6yMtQPR4/JBN5v/t0o1uZd5HbYGzfgVjfEWJdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+BfOIUvRQ+/Ue0utQWdb9fkUVr9yzEVpvdR9vnd4S8=; b=qUmyOQlVU29pSUZYOCKhvEAZ/ZoyZ7nmqXw+AdmomTwa43WhdCK+NJug7tJXjomZIEPlo1/jpBU1K5rTdVEplOYyO6VLHQMRlXSMdLdeQ/5vUf+C/XxXhuIqHSxBqADnwGAOlIUP8Gd+BivVn49wI/O9I5mL2926xThE8kBEh2r26d7f4uYPPhq1STKB42/BVG1/FlOlI0i9RI2GNGelmM8W+zxcYEqvV8xATHE461/0cM/qxHd5+LiVgYkHqy93V0IYm1D5l43r7/bqvY7UNDw+1A0QBkDi5vg+lmdGTlk+GIr1qtemV5kLn4PtVGheU3wCsGcrbmhKQcEzo/9vkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) by IA0PR12MB8895.namprd12.prod.outlook.com (2603:10b6:208:491::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Fri, 17 Jan 2025 09:50:00 +0000 Received: from CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5]) by CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5%3]) with mapi id 15.20.8356.010; Fri, 17 Jan 2025 09:50:00 +0000 Date: Fri, 17 Jan 2025 10:49:55 +0100 From: Andrea Righi To: Changwoo Min Cc: tj@kernel.org, void@manifault.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] sched_ext: Implement event counter infrastructure and add an event Message-ID: References: <20250116151543.80163-1-changwoo@igalia.com> <20250116151543.80163-2-changwoo@igalia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250116151543.80163-2-changwoo@igalia.com> X-ClientProxiedBy: FR0P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::20) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6405:EE_|IA0PR12MB8895:EE_ X-MS-Office365-Filtering-Correlation-Id: 1396fc2a-58f6-4b3e-c96c-08dd36dc4edf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MSQLw3j6PiUm6KbftRgqcADfWuWwrc5Yoq/rBGHuvIJsIt7OkN4zxh720ihL?= =?us-ascii?Q?FLnYDuYWnYqXO4KIKvm5AKCxHrQtir1qMOELcmZEKNCcn1quj4rw960meQJ1?= =?us-ascii?Q?9GB4m5/DNN2An6m20K0XaL7ZZdtk5dksZWCVYJScLrypGAwXNgg8uVsyp2Ix?= =?us-ascii?Q?Pn9r9O49cmAGgSMfAiEn7SRAsiZ8yE28baTlDMa4XLnpsHFpzKzsNXuseod8?= =?us-ascii?Q?Vz8Mswhy9+LeBljgf6g1RiW7B3irgnSWi+C0pxFSU1eRIA0+awv67IBIntmr?= =?us-ascii?Q?2CMWwNI7Y1YIWvV+IyFcietYU8op83XHWzvUizZbXR1G2+k8yx87AfP1P3qn?= =?us-ascii?Q?mXZom7uH2pcCExvDYeKc7e5jq2PdD9fJO5AjJFDypEt1tue8bkP8qU2k0+9D?= =?us-ascii?Q?b+lzmjajO5uvbHd+9zCH2x3sUZHphyx9MnlpZ7txTk1xxPdY9/uQK7U/Gdjk?= =?us-ascii?Q?rX1PT4xhkdFBPwW7KOgeHrzzhScLLafBl0ImPzEtJM9/LIYGYCl6qiwqKwgj?= =?us-ascii?Q?1tCuy08ve1R1Q0C7JCgBlrKtfMT3nFHo251JHEGhafXhEH1i1x+7wF1u+R1F?= =?us-ascii?Q?A8XUMSKFEREgsB/trUKnjBhLMeFNEe28WpLbxj/17X2SC/sVXwy2nyoYlFuM?= =?us-ascii?Q?y94fHSMNMpNPqDacm+mYn8qpxi4IENivgDnhRuyRPgkG9t+J9P/lI+qrM3cx?= =?us-ascii?Q?xOCXa68iZpEFHphF+ZiXY7honBmmUmgZ6QsgdftOZqO4upXEAIS3oeXgTdgs?= =?us-ascii?Q?sIGnWgHsZNSl09wrh6/ldPdHvel0JI/PrT4nZnVA4pasqZrc8vtDVDwI/fHU?= =?us-ascii?Q?Hdf7bcqySzUU9ifQWiCWLoHdaN0Y8vkMNQB8YmomSeVcaxD8AmHnK8yX6B4N?= =?us-ascii?Q?MeDjzIL6mC0zraETE/dygLaRSRtIAG3zen26gIDpA2YYDx18yOP57XtltfaG?= =?us-ascii?Q?oYhjsY9FWCElV6p9X7ACfAhov+zloi0pAG/B2gFwYU1SuWVFTQ+U69Al+1/u?= =?us-ascii?Q?gbfg1MeXOrQ7fYxxSY8ApttUcLzBsRTE8ct+ROhcNTxDafS8yq0IKNK8wX41?= =?us-ascii?Q?HETpaES5aZHZjoxVyWzbwgzGZRpm0V4HhsG+NFTsBGdxtKToC25AeWSMUTeO?= =?us-ascii?Q?Z2wbEmeQOkWXBqQet4vLp4wNbCsvQSvUJRH/U3MhwQqQAdWXQNJM1R3w7L5u?= =?us-ascii?Q?I4DYeP46TGpQwjOY9jpU2Jfy6RHutugCJYqjf2BBs7w8EhLAu7VAgctfGyiK?= =?us-ascii?Q?COVQZghOhXZYyK2iCIKlPpzIc3oxx3pLRlyFF+u8wuN9V8R0Vhhefm9KHLtL?= =?us-ascii?Q?MKtrLgY5/aEFCsSVcA5bQPFEeyTKCuy995zJEuKrsA/W1J0SjECbWqS+dFUK?= =?us-ascii?Q?PiMwU6F3yjXJSImksROIW6odXpop?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6405.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4morlKvYVc3iNU4tEBS7cwrenvQRiVq3t9k1oPXWbvEMMu5g1xxr7VfY9m/w?= =?us-ascii?Q?Zn1KBhxE4PCo+RJbxuIVjBfk73KmlMxvwgErIAy8xmHd3edKWX1i7tfigo0D?= =?us-ascii?Q?QfiCa35C7paG/8YA2In/kgoSsJPJTKWzD7LN5N4Tyg2W8Bzn/HQ1u8y4p+26?= =?us-ascii?Q?nQlWsAgvsAsR54q0CiyWywKAvjuLmhPtU1CDV4IEharIOqlRi/w+TPyArV6s?= =?us-ascii?Q?gMtXYfqt0MWiENAqdzkQzwZxwSfoKHuagaeRbYQzVidp/lAMioE28HjYMYrI?= =?us-ascii?Q?LxMDmOglHiE/Hi2EEGi8sa/sUOmyj+wAjlSWs7vQlL+g8Z5+fx228++mKTMj?= =?us-ascii?Q?Z7WI3r4f6K6HSy4ezVwulL1xutc8guUchybhcl2sRcksWKxm2lSrqvN2hUIt?= =?us-ascii?Q?JtPLT9f6zZvPkK3thO6xhlj/mWcdleyyBZ1mLxgWbAglme3aVAbFD+W3AcV5?= =?us-ascii?Q?S88r75NtNeADHbqxX6NKGXZ28u4RcG0jmXxq7l0o1kcH1cOKQ+HMIjUJBEWS?= =?us-ascii?Q?JBbD/DXCPToQ2kyangMpy/Q9KDkOvSnHDLuvF0s5y7gJENWHE6yGMqcHJY2Q?= =?us-ascii?Q?+66U70XWenp2JRKCOQUo42vMjFnl7MVbsUt3v9LHMD4Ash91muz9UabJJ28G?= =?us-ascii?Q?037a/QMRs+nq3o1bs/Xa/vaQipJgk7hGFCSeUppdcG2pnCItm8hm0ouHXfSJ?= =?us-ascii?Q?T5Vsot9yQ2nbLn772MOsm/YP52NWlq/LR6RUbobvPpNW3Ggw+CqBbUNFrGPv?= =?us-ascii?Q?Oxq/Bx3p2BMUsVeXSz+CfJBtsNULpxTTQ60lTXcZUb+zN5oJwFcMg1rvoxN4?= =?us-ascii?Q?HF8DBATVlCbWmixE9PmSTxqCbwWYwDD4K1KUp8w8vsT8wUs5Vge+U8A1h9Lq?= =?us-ascii?Q?Gk5X0r74/4RAaCd34RtyoUMgRZTxulH8PbkFUADVjf7pOsyM6vEDZ3xO6FRs?= =?us-ascii?Q?RP6oGmwaYtgNslyNmAcCdAdtaOqnuPCHmyKzFlxlRNoEcFiV7xUL1RbXVKuB?= =?us-ascii?Q?OKuXiDGxrkGI6P9hmEaDyb55gxRs0gWbzLWk3h3Gt/zzZU+xfvP4CLNonClT?= =?us-ascii?Q?KWDZ9yEg0dY24BZrcBy/sWlcep+9yGWQgtIg1dtIjUbfoLvDrjUhoQCQmT1j?= =?us-ascii?Q?7Y5hTetnv8FwU06RYCGK+otmN5k8sTeMMJE9jAQa8B3goOh4mocVCYqCVxQk?= =?us-ascii?Q?fhpnGEFLuyxN49pZqzlXKW2ctkJI1TYv8sItZTimgAm2neWITVjToLqggfda?= =?us-ascii?Q?eUnk42hd3om5n1+VmBC3sH15Qh3H2k6WlmlZ+r+kqBa2ViJsshKKLzLWBlEp?= =?us-ascii?Q?J6c5E15j/oEKlrP0oDKNKDDWpeudtUUb6iwVBlp5m6KSVhF3PSPgkzbkiFPb?= =?us-ascii?Q?APG8UjOIroxEnxB/WHqOTxW5GE5ns0xMIQDekYbP9AMYYvEnlRvRMB8RJOhX?= =?us-ascii?Q?PdlqyPWYCn3yWDIUD5ZCrUAsUjuOS587p/MOY9oANDtUYpglxcigIxjmWxd1?= =?us-ascii?Q?GB9I3rxXchVbyPntDIJU9Q42KhpQpOfBMS4rMnl1XirO0S+TBkaGrb7h4j+N?= =?us-ascii?Q?Z4M/funTBPJqyyp/FXE5cp5KyV/2ka2DD2iRJZij?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1396fc2a-58f6-4b3e-c96c-08dd36dc4edf X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 09:50:00.1592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 08yhQHZo/sGTrTQmBdECeqLOjWCId3Xdj/3OmM3jf35sWN8/j9gHleCFJrEOrjlx4KZJK5GD3FfaBtr02U7XBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8895 On Fri, Jan 17, 2025 at 12:15:37AM +0900, Changwoo Min wrote: ... > +/* > + * The event counter is organized by a per-CPU variable to minimize the > + * accounting overhead without synchronization. A system-wide view on the > + * event counter is constructed when requested by scx_bpf_get_event_stat(). > + */ > +static DEFINE_PER_CPU(struct scx_event_stat, event_stats); Should we consider tracking these statistics per-scheduler rather than globally (like adding scx_event_stat to sched_ext_ops)? It's not particularly important for now, but in the future, if we allow multiple scx schedulers to be loaded at the same time, tracking separate stats per-scheduler would be preferable. Thanks, -Andrea