From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C0121F5616 for ; Fri, 17 Jan 2025 09:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.40 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737107712; cv=fail; b=OI6X/Gl/zNg3qpPbCRS2H+aEkA8d2UvvodBotJ5soqccpoRqqLG0fcs/9QxQEuff4PKAKjnOf9571AbpKukPY6yKHTouTOuTE8Bxikg2JVrkHS1XKOFAU4E0vSPjljg0J0o64W8t/SebV9t7Y4rRkUNbSjHjz/TbRA1H1+AmYd0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737107712; c=relaxed/simple; bh=xN0bZ7nhzF3m16oU2R0MixJV6vt9uxifFILv+kPCx/s=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=VwU9CI8v8T3qc0mtm7R0GpyhhWPToVDnrgEQq1EV3DfAmTW1rP7rWoN4Dq4E3dLJ23tB6tEAYx7xxGeYp4jr70A0BFChOX94nhM/7FlOXLWQj1YO6i7TmO3p1udwAi/smY9vOVCsOtU/mwHG6PKrC3sAhVBTGG8EoG3oimrncTM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NyxyIOF9; arc=fail smtp.client-ip=40.107.244.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NyxyIOF9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=edN8ONpE2N+YTK3IiXt8qoO/hBsbhd4pS/iT5lvovU5W3DPOzU3c0Clez0UhigkADR7Z/E9nyxtt5B/D+SyokX+N4WJpEALbFS7avTkxXo4bIzc6O19tus+NSUZrsit/JOYjb44PnlYf0N7c3CfJYhe9PYEwakCaPaiGhsGaoCTCiLRWU5LWvi/zQRZXSnkIGPzBGh9yGvqqAaO+CZwL0hpHXJhhP7nFT+Akbm2A2FrNysY7q9uJBTic4/aGj6V4QymvyNQjXcoDZduXSxCI8CHrcg6BC6/EZF1q6UmMcSyaAFNlAWb4562q8wB2m6wVbawcirMpuFt0SFW9ElpZyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+EZkimIS/CUqR8xTqhph+HgiyU6oUtU+8YfkELEMzpU=; b=snbgN0QGLTh6MnIrbLDJL3Cldf5KTBZ2BVkHYETzDNiE06ENCH6pkAJNzlWBIZ5XYvPFmhGozv4SWAFvReD5oenynexSPe67O2GiVyTVHps7F41mnbwumd1sQm1+qc9r9r5255e6Wi0Zqq8zwQ5RAQfcrDFlrBCkGHM5IyLrhKLWX7gFtX6QsNiE85QffrYKMbifI5eno9ZdY38wryoIE5N4xhxS/OCqNoVIbFM6FocmvbFWJeOEkaVtLvO2nkkUvZQTuGtBVOcp5dgIupiMfD3m5JbrQ0AivLM1uSm6322JVrg0FrdOB85snLnbtuFCM2c41PjVaUtPlUsSTPmlaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+EZkimIS/CUqR8xTqhph+HgiyU6oUtU+8YfkELEMzpU=; b=NyxyIOF9Kt6ALyCwNIPTRW0Bu3J8xNghPfhHCmVJmH0I7Cb7FeDXrHIS2bymuXCHLQPJgnI2BWoEy0rj1+tA8qIt2IdGcynsq8itThTxzf/2uwJSY7XwIzgYjADqa20LpbufaOjov4litpXOgYxKf/KX8jXqpi0z94pWCTUy4pxZV+DH6dLp+3MM40xhxzG09SGMtr9pYWEBUDM2H0EahjkslOQ50zVEQisUfIR38hWZjGn6YSSmVq5K0XCZpfQiUJ3lh0DTviyvRCCQ2cAcDPwkQ3efl5ZP6HWZJMXz6xDn5FjubLj8HnS4GR5RSyeTXnNj4tcO5w5HcOFrUvm6lw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM4PR12MB6424.namprd12.prod.outlook.com (2603:10b6:8:be::16) by DS0PR12MB8200.namprd12.prod.outlook.com (2603:10b6:8:f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.14; Fri, 17 Jan 2025 09:55:08 +0000 Received: from DM4PR12MB6424.namprd12.prod.outlook.com ([fe80::8133:5fd9:ff45:d793]) by DM4PR12MB6424.namprd12.prod.outlook.com ([fe80::8133:5fd9:ff45:d793%7]) with mapi id 15.20.8356.010; Fri, 17 Jan 2025 09:55:07 +0000 Date: Fri, 17 Jan 2025 10:55:03 +0100 From: Andrea Righi To: Breno Leitao Cc: Tejun Heo , David Vernet , Changwoo Min , linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au Subject: Re: [PATCH] sched_ext: Fix potential deadlock in destroy_dsq() Message-ID: References: <20250116115101.549175-1-arighi@nvidia.com> <20250117-defiant-tidy-foxhound-3bcbc2@leitao> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117-defiant-tidy-foxhound-3bcbc2@leitao> X-ClientProxiedBy: FR5P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f0::16) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6424:EE_|DS0PR12MB8200:EE_ X-MS-Office365-Filtering-Correlation-Id: b78a0dd2-3796-4ff6-3577-08dd36dd061d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jy7KVnBZ5D0cHfcu8+8QXIzTIDx+loT3QD5V4nk4SG878Qzq6EHdmALUFfz3?= =?us-ascii?Q?2dg6lNHMD1UhowHL1lvkvSN9OBiU2GSR5K8q5phvfyLIRI0UajSZ38yFDjbn?= =?us-ascii?Q?AiAmgXiNG5AcmYJlxOJ1aH3opfMA/udW49nHV8iK95HVs5e3hPxQI+pxUlw5?= =?us-ascii?Q?K1e+/vr1Wyb+MvdIn+teTRBxb1DD6xHF2qhrdSqg+1BctHPMneYZPbZwVKrR?= =?us-ascii?Q?ZAFk96dgrSmkfV7y+1ZEBDPopQme/0YOpPNTB0TUjXxTpsitaNR5zBDlN9a1?= =?us-ascii?Q?+MXHHiMGOIyekDoaG3rigkyurLqo0GdARJlsRN3zZxC3Tl9qLADtqlTJpgmy?= =?us-ascii?Q?xP/iEC8VK0oE0D3YHG4qt2HWiOKXXr/ajjfxvZxptt/tkGHy19EmEZyQs94W?= =?us-ascii?Q?jNTwCWqcBb2P56weL4egftttSgCp02qLqMP4QrIYZ6F/2VfjDGWTKN+S+mi4?= =?us-ascii?Q?peEQJ+Lx1R3oZXLQ1RJEEC5WbXJdADXHduD+7DBIokdalUOZFHq5HHY5OeVS?= =?us-ascii?Q?2SftN+TRhaF8O7zghY60YVxcycbnY2/1M3h8DVAQcI7zUeT/m+UIXjaM31gK?= =?us-ascii?Q?Z8DblcJqpqW9u/0TtfUKqaHiVtCghyxcmS/9JHu+Pz3Ev1e/Oakv42O0JlS9?= =?us-ascii?Q?Tplsn6t8tdE3MlKdTylZxutQ7qjOxTqxcSD1KBmvIYHcjEjZjJ4VmZwPCPAz?= =?us-ascii?Q?POr4bGuf1jBqi7HHYWtkBgoDCXDGm5rDQrV/Hp0hKJcTEIbuRO2xDNq6PeNm?= =?us-ascii?Q?f28vcHr3egauHNSrHCqVbaj95Ric+gfq+bkF+ieZopBiHxBPgYFzp4KTGXZ9?= =?us-ascii?Q?YdRRAEQi41EyTKKwEiwaJcmiAroDoodinLpf6HDdrfCamSp80CHfz06WhUZA?= =?us-ascii?Q?Z3/NmTt7PYPKr/RWVttkIZsSFqKLHfmHwDRENUymprGyXANs4jWVwzTSSaZC?= =?us-ascii?Q?J2VQSBHkDyj9HODFNeVYI2yyCAjJYZ1AKjGNs+g9v0WlilgZrkTRIrxdMWDy?= =?us-ascii?Q?X+dwvYTgvnH7Nkn/+jf0bTtbclgUxqRFmjkrIMHcIx9wlAKEVkUkr3WsUmf1?= =?us-ascii?Q?1f07TYUlvwMG9D5gvyhk23b79cdXS5fIqUvqSthPoHzVZsfYcwpy+uVKmXCY?= =?us-ascii?Q?wV5mWLv8Odenivm/bV62brd46uvJpPQj0OzZIe4yjJzzTT437S069i09/kVA?= =?us-ascii?Q?c3OOB+tXWYBPJW8SVrWazY93Bb8qIDE8BU2YOT8Pnc1mKSb+bLYkSH3Iqm/J?= =?us-ascii?Q?GpbL0TYdti0/IqPm7jkcXxHhgAlHJ5fM2Bq1Dqx2vHaoEDtYhBQI3CLjtCl3?= =?us-ascii?Q?DIgusTszMYWa8B7TdNGh4zfDDRaK6UHlVWVNDX+27t0ISEKlHL1kRhSsJtir?= =?us-ascii?Q?kouBKuJlWH8n2g+miBHmdHSZI6ig?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6424.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lx3KEoTMmMWpXH7OvG8P+XnAwtm7YAjW6tPqkb6hHlDUA6BIledT1f/XJfib?= =?us-ascii?Q?O9hw/j80x90E5nAiGyXBEYvLGgKnzQJnymtnj1NlannWpXYuA73/AyilbABr?= =?us-ascii?Q?tUDcoY+xEneLXKYKxEISK1gip+SmUgw8kAsahzj3CWY+Y2HcUFrLG82Sw2tB?= =?us-ascii?Q?B9hAMOYL+/4W6NYk3euKiBo1BvDFKLABv8thpu6Z2QYpC7LwuZxl+aKY/MK4?= =?us-ascii?Q?XiF5Xk5cpuaZavSr85CTFHzhO/ssRmfxW3AIWj8EjL8WOlm2isjy/RN/A7zS?= =?us-ascii?Q?DLuy1bKw84LcSAebX5LN86a9VyL0zCtD8DUDC/XiHMzBvwuy61kd7VJGQfT/?= =?us-ascii?Q?0COr5QkSHZjxNSfvOS1XSOoqdi50CxWb9ALtz2mMD3YXGm8srdBhfZ1Ya4Hz?= =?us-ascii?Q?7/+0AXD1K2DgO4Hr2t/U5zCwYSiGxiQctMnQF86BvuFAC/15YtF3+xpNxS34?= =?us-ascii?Q?esj/MKDTjrwFewnl2Q6apGJHVacJu0247SKAn5f5x4u3eCz8M0CdWc/rP4XS?= =?us-ascii?Q?HExG+33W/wWEQxu9Vm7cxT+QRpBAo1yA1rRs16oFv9XYP1yq3h3fKvJEmKAC?= =?us-ascii?Q?5anYsXdYqi7Mne/ZI0JQj9/dRyqzbmsq80sqnjcNbqGxMWwCvj7x0mGaRcJR?= =?us-ascii?Q?0Zz4pUxyXaqJEXoHZ3JddTWfuwJL0DxPTYUBOM/sr+/dkPqqC0wSBOvEea0v?= =?us-ascii?Q?6wtU56ugZ4s4wMP/oDuFzMBasHE0gCh1ofZcMZgQlOajJG+KhPnse1jN1w75?= =?us-ascii?Q?3uCJeJjGjUXcLSJoI5oa9hGjrshqLp9izua6ONgirIgQqakImdRkMTJtwfss?= =?us-ascii?Q?qeeN2DrElQ8yokemRhe9lCIkuyUyPfTPwss2PDpFcoHFYX5bX0NwvV2MpPQl?= =?us-ascii?Q?i06n1tLmwg2zAqH08sMuvoPpruUqAIryT2HqFMCPM46aCN1difqRNVj0XPpo?= =?us-ascii?Q?p/YWF6o+ok4lNDtK/VAZ57iU12yrnCtRAPn7lmkveAYYeFuyTBfU+xNVivDb?= =?us-ascii?Q?p3OC7ZJd4HwuN3uZVR9PL7XZHC1rd4Z6tOyHi8WnQC+YLNzi1L7azCw1uKAw?= =?us-ascii?Q?yTqEhRo6A4ro+AnjrEh50GrRDD7dfjY0lepDjFch/OPoOfdBgBW8ZGEGiMh5?= =?us-ascii?Q?qp/BGXjruIYWUcfOh19gFCrjYYymbhnDHf2HjCgqFyR6Z85bFqKtm2RlddyA?= =?us-ascii?Q?L7DiQWsU3v4VHwRI7U+PoQehSeGkW74bGV/NP7dEN7jCS7CUv7S3i1ZskVbf?= =?us-ascii?Q?m563+CWO1YbDnK+3EDxic5UHn3XXI/2eeaZeCJtEonHMbe/EUBQI0H6kmH+/?= =?us-ascii?Q?KhS4Ws+DWa5wZXNek9DuvGlNd9klRuPXIj0AThaNjzKEmyAVemT6K7uvfxHY?= =?us-ascii?Q?pptwod5YK7y58rBntP3598eQY6Y8ITFUMPPUCOaOJV/ob4TBCB34ai/MwsA/?= =?us-ascii?Q?v1bDVY//wXnq51qp0GnkDkxirIj52P16q38iXwdVovxA+quswO+GdvBKe5dB?= =?us-ascii?Q?bctVp3qTHKWGnVfwUONA+G/cJkRMyQA1RNPQla/R9cNVjPuqVFdHxzCANvWr?= =?us-ascii?Q?yeqa6fF/YFF+fVirSMPN5lvd+jh76vh8qp8XtZb6?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b78a0dd2-3796-4ff6-3577-08dd36dd061d X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 09:55:07.8381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yo9IJC4Z4PMsRO63d/ft7DYpg2e7CxX0o1Nm7efuFWjxEEf7dY+jPhjRu9cQiFPLFYbYauGy8CpWfDdl5bUqUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8200 Hi Breno, On Fri, Jan 17, 2025 at 01:46:12AM -0800, Breno Leitao wrote: ... > > Hmm... this is probably the same thing that Breno tried to fix with > > rhashtable update. Breno, what's the current state of that patch? I saw bug > > reports and fix patch flying by but didn't track them closely. > > Right, that seems exactly the problem I fixed. This is the current state > of the issue. > > The fix is already in linux-next, but not on linus' tree: > > e1d3422c95f00 Breno Leitao : rhashtable: Fix potential deadlock by moving schedule_work outside lock Oh I totally missed your fix. > > That fixes caused a regression[1], and Herbert got a patch, which is not > committed in linux-next AFAIK. > > This is Herbert's fix: > > https://lore.kernel.org/all/Z4XWx5X0doetOJni@gondor.apana.org.au/ If there's something in progress already, feel free to ignore my patch. I'll do a test on my side later with these fixes applied. Thanks, -Andrea > > [1] Link: https://lore.kernel.org/all/Z4DoFYQ3ytB-wS3-@gondor.apana.org.au/ > > --breno