From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 824DD1A0BFD for ; Fri, 17 Jan 2025 17:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737136507; cv=none; b=lVOakWyYA6X+r3/vIwyvpIpBHF0hNNcpOsugpTZ2ZVExZfd+C/sqk4bvV5GIujJRrKe/8H7KkDpKA7+IbPQYRIoXoiVWm2zD7L583YpcnIusykjNRCPOlxmejNnObp8ggZMbqmxyE/NdW9Du/Vuf1B4ceaLxMmeKcwz9c3VNZhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737136507; c=relaxed/simple; bh=K67tpMQT0+BbeazJE3N5OyFBMhLIclKIIm3lqJP0g3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EcgOMp+cv+KjD05I0rPZfQz6gVVKP8v8fUPQmpYAL/ktOZlvfat+rb+wbCDTeONmjLrXEJ4EkOhMz63nkA46X64NRwlXivSA3/I1SyBe7ZxilNowE1flHxKdUAzOK4BgQhNkTPiMmxNliGNIeQFX6Dw7/xUvrpWhuHxP3ea76xg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VtXMmSuf; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VtXMmSuf" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-436637e8c8dso23033365e9.1 for ; Fri, 17 Jan 2025 09:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737136504; x=1737741304; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OuIZAMpkTZRgTeZlnciow8WXhqjoSsm/hec0PgoHCmg=; b=VtXMmSuf2VdvEGUbzMiYdlR+anPPv4HQc6RQydAnktKR8sb1089CWtTH+u1WlujQnr /ulg6FadYT/N8XYcCSo3cOKNB3jFLiTyJfWsfEfKceALwzzjXWGtK9n+sx4ftJ6bB/XI JPpgZZ/wpr3raYGSmh5pXT9yuvUfkRVZgX4j4CAGwXwJICKW8SgzuNisVFFHS1Czq8Gi U/vS60Ow4wyKke5Cqz3ovnzlDqZzT2OP87BNFIwWrb8a8BaeR6bUJeTOPTHnKCcIUCrC tPdtWTnxLxhvg/9Dj7OaBqDsSAKpN0MDXsa9gfqriLXTpJXqX4FjQjUimumf1GGn2CR2 ANkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737136504; x=1737741304; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OuIZAMpkTZRgTeZlnciow8WXhqjoSsm/hec0PgoHCmg=; b=ZRmF9WSPraKjrxGqvLstn9Vq1g4lGeRN1buP2h/U6z88canMFfVwYQZEPWm44bpxZL qGdWPtP9GuU2uNdrDgQjQTUDdoRqJCV+E/fTrINkeNxv8Zfud36VuT0H8YTKWvrCoG9V TpokDA/0QTCrIEkRspZ9HQ48c2ze6BsyJinsxOXS8wMdeIk+mngPC/+L8qyTLZ0KwMjJ 0xsMFinIrLzKYIeSnFOA//eOHu4Ashv435QPsdftLnrJglbwWxa/h/uIm4bp5s7311vR zYMMNwFoyfy5eQP/4PnekMjX5qvqUBOUFMnlrbkdyQhZ/0Yl+gZ7PHSzqymg8KRlNxtY e9xw== X-Forwarded-Encrypted: i=1; AJvYcCU+c5VDOdNk7q4CLGRJ6geEjmOH215E6uumIYxRxR4v4zLfgY0VxwLGqlUlwONSkRQN8L7g9M9VQkeOTWk=@vger.kernel.org X-Gm-Message-State: AOJu0YwU7SDLvreIYOoP3jkSN2ZMYqWQCsCALAnVTB8VI6ZCK/PVV6iU f1Bp521tYRAr73s62XNI1kmhE3XBOy4SSzhoBBNncUnolTka07b/ X-Gm-Gg: ASbGncuB2mSP1qXkTVnLnyUwfeiC8q51Dk8NeyDo0HsRhjuZEM7y2OC1oB6EaaqZtyW +myUB6Z55JM2L/+ZsD8I2xfZgecHDTmVIKbuTpmYQe/moMsxPDurcGyCdBFWdq3cFQc5jgE7Bq6 Ll3Nv8LoxA/LBlfV5v0VAqQae7+ADPDK8uoSwOqNdYKN0BJDDIZGP1K7qJR0O/rTgOEpmiNOUuP roZfi/6WndRsR6KKwWo41F6FHSbHIIVOhyE++LZe+ib8VLWXcYEkc9JCz2ZTimF9yyTDNqw X-Google-Smtp-Source: AGHT+IGe1bqv6j5FJx3lKej8/cZNS1j6GR+UPSYL3lYTkxf1tczKFeAF+CDKv6+JzeKENnBSFC6MDg== X-Received: by 2002:a05:600c:4511:b0:435:9ed3:5698 with SMTP id 5b1f17b1804b1-4389143753bmr34726165e9.24.1737136503529; Fri, 17 Jan 2025 09:55:03 -0800 (PST) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438904087cbsm41520955e9.3.2025.01.17.09.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 09:55:02 -0800 (PST) Date: Fri, 17 Jan 2025 18:55:00 +0100 From: Dave Penkler To: David Laight Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gpib: Fix inadvertent negative shift Message-ID: References: <20250116110014.15577-1-dpenkler@gmail.com> <20250116224003.28675481@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250116224003.28675481@pumpkin> On Thu, Jan 16, 2025 at 10:40:03PM +0000, David Laight wrote: > On Thu, 16 Jan 2025 12:00:14 +0100 > Dave Penkler wrote: > > > During the initial checkpatch cleanup, when removing blanks > > after open parentheses, a minus sign in the argument of a shift > > operation was deleted by mistake. This transformed a pre-decrement > > operation into a negation. > > > > The result of a negative shift is undefined and a warning was > > signalled by sparse. > > > > Restore the pre-decrement operation. > > > > Fixes: 6c52d5e3cde2 ("staging: gpib: Add common include files for GPIB drivers") > > Signed-off-by: Dave Penkler > > --- > > drivers/staging/gpib/include/amcc5920.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/gpib/include/amcc5920.h b/drivers/staging/gpib/include/amcc5920.h > > index 766b3799223f..7a88bd282feb 100644 > > --- a/drivers/staging/gpib/include/amcc5920.h > > +++ b/drivers/staging/gpib/include/amcc5920.h > > @@ -22,7 +22,7 @@ static const int bits_per_region = 8; > > > > static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned int num_wait_states) > > { > > - return (num_wait_states & 0x7) << (-region * bits_per_region); > > + return (num_wait_states & 0x7) << (--region * bits_per_region); > > It would be much better to use (region - 1). Hi, You are right. I will send a separate patch to change this instance and all the others in the file. cheers, -dave