From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5C71B394E for ; Fri, 17 Jan 2025 22:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737152450; cv=none; b=KR1/K3TpNiihiOC9nfm3w6TvejY6eMXfslGvYq4mDXeKdhVjySxsThiIB40CmsDeQXzobhQHIoo9LOq0JU2bgBE0YRzZu4h69iyJRJFIA6CvcY0nU6ptB+4b7ijYjdjTrKXhMT+RSfGWEQf+SmKGA+jjGU6eYSBPMajTb1MRW+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737152450; c=relaxed/simple; bh=S1zKicbqXlV/ATgu8n+aRUZCylDWDZI+or9hHgthmAI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hYgBM3Y61WJY0V78OfOY4VYYudqzH7XF+nGYohVp23b/549sYNKi/2LJSmXYNvARBzP1dVNZqzDooTlBERB8gtHVo91pMHa9rpFYR/l0LIlJuJzI339bzRnqvRjalRpr+P2FUK34aJY9BNXlw/ePA7YEL/cRp/u2S9KzQHfnULQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=iIdK6rjH; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="iIdK6rjH" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2166f1e589cso66244515ad.3 for ; Fri, 17 Jan 2025 14:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1737152448; x=1737757248; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+UvfbyshMpjq49xRnNRxHHOIBduK4UL6eUEvgrgMgDg=; b=iIdK6rjHRXhqiwLfXl9BFhSs7I5UHSYs5cXkCJ4Aggcs/vG33sBPgpFgJAA+lwcRNv RWBi349hIsi10MrzXXX3YxQTZp5BuZxEUs6Q1QCJ2BMAafoozvxpu7el6b9MfQ1nsZx4 39nLLNETQlels8nGdePFXfKMYN/cUp9MhmPPVWeYOk9UlauOaNOxoivGkbRNy+nwf1NZ pDKddeN4z2920ITB0t6zQlDg5GTh3oFSJ8d7I1/iocqA0QFzZVDJVrD+V2sKRpUbQHaQ 0vmYOkm8/bb8Y3A7lcdhelcEwc6d9Yf8vYcXgbbinap9/ikelHTyW2ejdmeRvWa81LR7 HWvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737152448; x=1737757248; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+UvfbyshMpjq49xRnNRxHHOIBduK4UL6eUEvgrgMgDg=; b=Wq4vC7d57AIJRQcpwJECHsuJLjLTox5W+AhpeA4Rss7DlQM7Ax55ld8P/0gVz7ERM5 Cc7h9tDYk3imWrXsCfK67pMtPYt72UOY8lRbfOSqvE/TDGTMJ191zu69TgKOQLhJA2sI mL5CKDoKTXa+d/261mcdOchyrdhTCkqfW2eCCr+wmLOlWcvyzeUtUX1WF/F6ReJSpAZv 8FHvBvlPTty5Gz5ItmL7xxwfbEgIpHy7xABLogUauQWS/UqOU3c2BkSDH5oHzk5aAsi7 wCOlV8JseAoq1/zMMNP09pqgePS9zHI803rCXQp8xAbxP9lbLnfAssQ1It+bEwMhoP1y AL0A== X-Forwarded-Encrypted: i=1; AJvYcCUZIiOA2BOGtkPFSqnVPk58OgPUanf2M8cq3r4sASqb1kswHeh2+SiPlqdFgWJMRbsVLTqphmC9rbMiEBk=@vger.kernel.org X-Gm-Message-State: AOJu0YyWnP8dvTEYWYfAPZ8Q88SemXrb5IHznm39ixBwqgJeKufOYAET BEoUSGOzw0ApsFRnxFh9/I94SGWDhYURHNBrGvp3kJ/jPN3yMgfg+IoCn21rdMj9XrfjOEQ2tif Y X-Gm-Gg: ASbGncsJs2eMT33KKTgeqFajODAk6+9jzZ5kQU57imao/S5r3X5vC7UEoDWsRg63FV8 IcZ3kSqbGW3Lb0wIU5YLMCR0o8pHEDjGXWQfjUw27sNOemga4ee8gC8ncTxADNdRWSR/4nxCSSh v73+AuS7VV4YyrLoPNRwb1g4cG4JHGC5NPdQ2Gi6721KgKEMEzs6u2++bDMepPNZEwPkygl1wTu Z/aHcem/WLYz+BnaLQFzfDlIevvP2wu9rAY9kQaCBW1/KdD8vV/oVt7y6RuBYk0HVctRur57xm+ Tm5WamLCnmySZF7D7/n2qc+Q/fuPLNbUQnQ= X-Google-Smtp-Source: AGHT+IHzLnjLl+lx1SZTSRx+LbZ8zk/wyNSJfNQyh5luY9Pn0UzSaf8cbFhTg1LP7e/Wa14Xnby1ZA== X-Received: by 2002:a17:903:11c3:b0:216:2138:3ed1 with SMTP id d9443c01a7336-21c355c77cemr61602355ad.19.1737152448318; Fri, 17 Jan 2025 14:20:48 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-a9bbd0274besm2413894a12.0.2025.01.17.14.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 14:20:47 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tYuho-00000007B3Q-2sjw; Sat, 18 Jan 2025 09:20:44 +1100 Date: Sat, 18 Jan 2025 09:20:44 +1100 From: Dave Chinner To: Christoph Hellwig Cc: Brian Foster , "Darrick J. Wong" , Chi Zhiling , Amir Goldstein , cem@kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Chi Zhiling , John Garry Subject: Re: [PATCH] xfs: Remove i_rwsem lock in buffered read Message-ID: References: <953b0499-5832-49dc-8580-436cf625db8c@163.com> <20250108173547.GI1306365@frogsfrogsfrogs> <20250113024401.GU1306365@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 15, 2025 at 08:36:48PM -0800, Christoph Hellwig wrote: > On Thu, Jan 16, 2025 at 08:41:21AM +1100, Dave Chinner wrote: > > > I don't really have time to turn this hand waving into, but maybe we > > > should think if it's worthwhile or if I'm missing something important. > > > > If people are OK with XFS moving to exclusive buffered or DIO > > submission model, then I can find some time to work on the > > converting the IO path locking to use a two-state shared lock in > > preparation for the batched folio stuff that will allow concurrent > > buffered writes... > > This does sound fine to me, but it's hard to judge without seeing > a prototype and results based on it. OK, the consensus seems to be to run with this for the moment and see how clean it ends up being. I'll look into it over the next couple of weeks then. -Dave. -- Dave Chinner david@fromorbit.com