From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AF1C1B2EF2 for ; Fri, 17 Jan 2025 23:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737156300; cv=none; b=ifc9K/G8ZB/G5iE3R9pnXOjlHiEdXFGqJKfZcXywuknPBiPxdNTmzdyD+g8BVG5wJtAi/G/RUyXsdBLPZE34WuircaGOMuY+YYTYkmDsS+evB6ICSGvvgDRXw+kCJZ4R69lLTy4Nl597e76WpAh3ijtqMRDoFEiMSNwtRSd1nYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737156300; c=relaxed/simple; bh=wluxbA0YJqJBbFZWt0n5zlBBZEJdezD66lQaZlhJ2B4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QU8CnhM+sAz2ZHu8hrvONfhjjjJ9yqchm2smAKhHMSli50gNKpEEaQ4LFKvqUVyxroJ7WM+ZHcvCvMlIdN5GFwtDufNAipz6zWL2DyH0l7dXXzBM4k65AQWwAPGTR18tYDgznuvhYOOqmdrtj5B8ocMZxYuGxiQsSHJ0jshdFFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=BXRlCj7M; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="BXRlCj7M" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21661be2c2dso51976215ad.1 for ; Fri, 17 Jan 2025 15:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1737156298; x=1737761098; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oxsNgcMxesDh3QcaDVxAgFxJltijv+5tYVPijMLVSjk=; b=BXRlCj7M+1J4rBtFt5pU47mUKp42evuQZbrhPlt/reb3/U9wlNsL3JPp/IlW+SPmR+ RnlsfODe+fyYAfsCaExyCXxToeOJiFa3XQdSXMs7WRrTzAhZYma2eKpVJPfAo7lU6eyF bqfwzKVXegZCCSiuS5o0K0USOMENp7Y/iQRPWZyMpWQ+y0ZLy1y/rooT/p3zqs4SgBip LFn4aomXVLd/zUyDrN0SxkRemTQQxBWEGgibwXI+CMkP4QafwXUkKZs6yAU7bjVpgBFb 3LHSOoKOKJw7C+Gr44xWnavACKRQoudCSE3kgqgnzYWcssJjf2hJp5UNld5dT2ofAzTQ QJww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737156298; x=1737761098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oxsNgcMxesDh3QcaDVxAgFxJltijv+5tYVPijMLVSjk=; b=Ut+qsT7MYS7psmtgCKj9FlufwA0bl02uT3E5dMVASmnfyvigXCsSGrlxWnZAGM0oMw HakFEu8SbjmWwwParclZrdkIeb0wx3hTn8HYBhaDeEtWgnaVXqQF3lz0J/wI/BqX3O9O rIhYASvPfxZlJj4l/eli5sMCnPXQrAZjPnh4lu451qo2tSk85OWhBvs5pRgjGGpAcXNf hUi6p8Q4XXaKxwIQhrrV7SeB/RFV41lcKXymHH6CY0jkD9IQpTagEeQ7GuORVnuQdKEo wcJCib4DZvLYWEwPr9q2+FbPTawKl5QJyJn3ho0Z7l4nlIFwkt4zB51h1nc1kUZjGxq/ 7UGQ== X-Forwarded-Encrypted: i=1; AJvYcCVE2Znm1QU3Suc23/UcjPgo22emD2GFY9HLcw3O1zRP/47Za2CnHuE4vjNX9KssURRQBnyC4u10kp2t9K8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz82YMnvRf4iYQMGv3LOiOkwh3fnwSEDaCZXor4HuC2V7RepTbo Rj0LJE+kIgpmjCo/cnCIC6OvJyQ00LziEGSblLqJNJqCBRM3ixqdjtfqBcEdYws= X-Gm-Gg: ASbGncuo23E/y/EpWnNsM7VGIdA41XfVBT9xvS/Q4zeN4F8IJQXEpm71Y6+5r/2hqS/ 5LqmA/h2eTPPupgWK6Bff8VLTvSkQHDkiKz7KaJgbWZ0Ck4XDSVhMtIOJdfb6MMx7Fxn5iHgviV urACJVBQyWgK4ShrYru1T+7TKxNRr+yr2OJ2UTxlRWrkcLKKsF2pn7VJOZs8uEsklITkqx6X0hX nEyD+qlcE4Y69Y77SopNSnGJLgNEYmfoVnK5ntI0oaTV4UWO3fhXOWzUJtF6Fa0WA== X-Google-Smtp-Source: AGHT+IErvZN9mOlQYsXowWjE6t45soM1YqJtYsT65fUHxKopmzBIZgjHql715YRIJ64BOoR+/XyZZw== X-Received: by 2002:a17:902:ebcd:b0:212:6187:6a76 with SMTP id d9443c01a7336-21c354016c5mr79347345ad.14.1737156298429; Fri, 17 Jan 2025 15:24:58 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:d0ea:9b9e:5556:aa82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2d403c61sm20968205ad.207.2025.01.17.15.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 15:24:57 -0800 (PST) Date: Fri, 17 Jan 2025 15:24:55 -0800 From: Charlie Jenkins To: Cyril Bur Cc: palmer@dabbelt.com, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Jisheng Zhang Subject: Re: [PATCH v2 4/4] riscv: uaccess: use 'asm goto output' for get_user Message-ID: References: <20241118230112.2872978-1-cyrilbur@tenstorrent.com> <20241118230112.2872978-5-cyrilbur@tenstorrent.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241118230112.2872978-5-cyrilbur@tenstorrent.com> On Mon, Nov 18, 2024 at 11:01:12PM +0000, Cyril Bur wrote: > From: Jisheng Zhang > > 'asm goto output' generates noticeably better code since we don't need > to test the error etc, the exception just jumps to the error handling > directly. > > Signed-off-by: Jisheng Zhang > Signed-off-by: Cyril Bur Reviewed-by: Charlie Jenkins Tested-by: Charlie Jenkins