public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: perex@perex.cz, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: lola: Remove unused lola_(save|restore)_mixer
Date: Wed, 22 Jan 2025 02:16:11 +0000	[thread overview]
Message-ID: <Z5BU62Go409LFd81@gallifrey> (raw)
In-Reply-To: <20250122014301.447938-1-linux@treblig.org>

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> lola_restore_mixer() and lola_save_mixer() were added in 2011 by
> commit d43f3010b8fa ("ALSA: Add the driver for Digigram Lola
> PCI-e boards")
> but have remain unused.
> 
> Remove them.

NAK!
This lost the .c file change.
I'll do a v2.

Dave

> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  sound/pci/lola/lola.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/pci/lola/lola.h b/sound/pci/lola/lola.h
> index 0ff772cf66e6..25f72f9e3f9b 100644
> --- a/sound/pci/lola/lola.h
> +++ b/sound/pci/lola/lola.h
> @@ -499,8 +499,6 @@ int lola_init_mixer_widget(struct lola *chip, int nid);
>  void lola_free_mixer(struct lola *chip);
>  int lola_create_mixer(struct lola *chip);
>  int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute);
> -void lola_save_mixer(struct lola *chip);
> -void lola_restore_mixer(struct lola *chip);
>  int lola_set_src_config(struct lola *chip, unsigned int src_mask, bool update);
>  
>  /* proc */
> -- 
> 2.48.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

      reply	other threads:[~2025-01-22  2:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  1:43 [PATCH] ALSA: lola: Remove unused lola_(save|restore)_mixer linux
2025-01-22  2:16 ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5BU62Go409LFd81@gallifrey \
    --to=linux@treblig.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox