Re: [PATCH net-next v1 7/7] net: usb: lan78xx: Enable EEE support with phylink integration

Oleksij Rempel
2025-01-18T10:03:31Z

On Sat, Jan 18, 2025 at 08:22:15AM +0100, Oleksij Rempel wrote:
> On Fri, Jan 17, 2025 at 04:23:52PM +0000, Russell King (Oracle) wrote:
> > qca8k_set_mac_eee() sets the LPI enabled based off eee->eee_enabled.
> > It doesn't seem to change the register on link up/down, so I wonder
> > how the autoneg resolution is handled. Maybe it isn't, so maybe it's
> > buggy.
>
> The QCA8K_REG_EEE_CTRL_LPI_EN() bit is supported only for ports with
> integrated PHYs. There seems to be no validation for this case.

> Other problem with the code, lpi_en bit can be removed only one time.
> Executing tx_lpi off and tx_lpi on in a sequence will not work.

Please ignore this lat part, I'm wrong here.

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |