From: Keith Busch <kbusch@kernel.org>
To: Alyssa Ross <hi@alyssa.is>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
michael.christie@oracle.com, Tejun Heo <tj@kernel.org>,
Luca Boccassi <bluca@debian.org>,
stable@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] KVM: x86: switch hugepage recovery thread to vhost_task
Date: Wed, 22 Jan 2025 07:56:49 -0700 [thread overview]
Message-ID: <Z5EHMbv8uezcRM3l@kbusch-mbp> (raw)
In-Reply-To: <twoqrb4bdyujvnf432lqvm3eqzvhqsbotag3q3snecgqwm7lzw@izuns3gun2a6>
On Wed, Jan 22, 2025 at 12:38:25PM +0100, Alyssa Ross wrote:
> On Wed, Jan 15, 2025 at 12:03:27PM -0700, Keith Busch wrote:
> > On Wed, Jan 15, 2025 at 06:10:05PM +0100, Paolo Bonzini wrote:
> > > You can implement something like pthread_once():
> >
> > ...
> >
> > > Where to put it I don't know. It doesn't belong in
> > > include/linux/once.h. I'm okay with arch/x86/kvm/call_once.h and just
> > > pull it with #include "call_once.h".
> >
> > Thanks for the suggestion, I can work with that. As to where to put it,
> > I think the new 'struct once' needs to be a member of struct kvm_arch,
> > so I've put it in arch/x86/include/asm/.
> >
> > Here's the result with that folded in. If this is okay, I'll send a v2,
> > and can split out the call_once as a prep patch with your attribution if
> > you like.
>
> Has there been any progress here? I'm also affected by the crosvm
> regression, and it's been backported to the LTS stable kernel.
Would you be able to try the proposed patch here and reply with a
Tested-by if it's successful for you? I'd also like to unblock this,
whether this patch is in the right direction or try something else.
next prev parent reply other threads:[~2025-01-22 14:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 13:07 [PATCH] KVM: x86: switch hugepage recovery thread to vhost_task Paolo Bonzini
2024-11-08 16:53 ` Tejun Heo
2024-11-09 0:23 ` Luca Boccassi
2024-11-13 23:56 ` Sean Christopherson
2024-11-14 12:02 ` Paolo Bonzini
2024-11-14 15:38 ` Sean Christopherson
2024-11-15 16:59 ` Michal Koutný
2024-11-18 12:42 ` Paolo Bonzini
2024-11-25 9:01 ` Michal Koutný
2024-11-25 11:22 ` Paolo Bonzini
2024-12-19 17:32 ` Keith Busch
2024-12-19 17:42 ` Paolo Bonzini
2024-12-19 18:08 ` Keith Busch
2024-12-19 20:30 ` Paolo Bonzini
2024-12-19 22:23 ` Keith Busch
2024-12-19 22:57 ` Paolo Bonzini
2024-12-19 23:31 ` Keith Busch
2025-01-13 15:35 ` Keith Busch
2025-01-14 18:10 ` Paolo Bonzini
2025-01-15 3:06 ` Sean Christopherson
2025-01-15 16:51 ` Keith Busch
2025-01-15 17:10 ` Paolo Bonzini
2025-01-15 19:03 ` Keith Busch
2025-01-22 11:38 ` Alyssa Ross
2025-01-22 14:56 ` Keith Busch [this message]
2025-01-22 22:32 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5EHMbv8uezcRM3l@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=bluca@debian.org \
--cc=hi@alyssa.is \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=pbonzini@redhat.com \
--cc=regressions@lists.linux.dev \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox