From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A7791D432F; Thu, 23 Jan 2025 12:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737633698; cv=none; b=Dq9Wh4u6lSL5tCZNLF2GqCvRDsJur7ltLTJVmsFqXiCCNztj/+v6sckMWpzTZOCj5ki8W01sUrLekn2E6QY+z8dMkxFXYU8czzMCEBgmvp8i9NQPIMlmwr+HkaBEXz+/+xEJUS1nMbYPFW/k61yyIHjWc+zWKeh2XJDXdG/pM8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737633698; c=relaxed/simple; bh=PaoOFn6JXXsIq16ZOXpO7kHfAaEgKspiCBXQ/wULbpE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GnKOH3tbi6yLHlyDeut6Kbn6vT/QFkzCq97PbowcqDTbzSbcxZQIvWz8x622TsJawhC6hWjjjFcsLViAMyNtguFprNws5n7+nEFno/8ZdFUYO4EV5sTYCvZQ8SLUhaUnEwkshQZ/ciu5wwjMR+rf0z8rS0EAenEFpjORlQ693AI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B02DF1063; Thu, 23 Jan 2025 04:02:04 -0800 (PST) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06A7B3F5A1; Thu, 23 Jan 2025 04:01:34 -0800 (PST) Date: Thu, 23 Jan 2025 12:01:32 +0000 From: Sudeep Holla To: Viresh Kumar Cc: "Rafael J. Wysocki" , Cristian Marussi , linux-pm@vger.kernel.org, Vincent Guittot , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 24/33] cpufreq: scmi: Stop setting cpufreq_driver->attr field Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 23, 2025 at 05:06:00PM +0530, Viresh Kumar wrote: > The cpufreq core handles this for basic attributes now, the driver can skip > setting them. > I know this is boiler plate commit message but it made me go check if boosts are handled too even though I checked it in 01/33. So if possible, you can add "basic attributes including boost frequencies", that would be good, aligns with the change below and makes it easy to refer in the future if required. Not a must, I will leave that to you. Anyways, Acked-by: Sudeep Holla -- Regards, Sudeep