From: Carlos Llamas <cmllamas@google.com>
To: Aleksandr Nogikh <nogikh@google.com>
Cc: syzbot <syzbot+7015dcf45953112c8b45@syzkaller.appspotmail.com>,
Li Li <dualli@google.com>,
arve@android.com, brauner@kernel.org, gregkh@linuxfoundation.org,
joel@joelfernandes.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, maco@android.com,
sfr@canb.auug.org.au, surenb@google.com,
syzkaller-bugs@googlegroups.com, tkjos@android.com
Subject: Re: [syzbot] [kernel?] linux-next test error: KASAN: slab-use-after-free Write in binder_add_device
Date: Thu, 23 Jan 2025 16:49:07 +0000 [thread overview]
Message-ID: <Z5JzA2OMokMz4Mic@google.com> (raw)
In-Reply-To: <CANp29Y4ss7w4C+A2rgy45TqFbHvFoEAU9fq8JJxq_DJr74+WZg@mail.gmail.com>
On Thu, Jan 23, 2025 at 01:32:29PM +0100, Aleksandr Nogikh wrote:
> The problem began to appear after:
>
> commit 12d909cac1e1c4147cc3417fee804ee12fc6b984
> Author: Li Li <dualli@google.com>
> Date: Wed Dec 18 13:29:34 2024 -0800
>
> binderfs: add new binder devices to binder_devices
>
Correct. I tried to mark this commit with a #syz blame or something but
I couldn't find anything. The problem here is we add binderfs devices to
the binder_devices list but we don't remove them when these are kfreed
e.g. during umount.
This is then fairly easy to reproduce, something like:
$ mount -t binder binder /dev/binderfs
$ umount /dev/binderfs
$ mount -t binder binder /dev/binderfs
It should be a simply fix. I'll send a patch later today.
Thanks,
--
Carlos Llamas
next prev parent reply other threads:[~2025-01-23 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 11:08 [syzbot] [kernel?] linux-next test error: KASAN: slab-use-after-free Write in binder_add_device syzbot
2025-01-23 12:32 ` Aleksandr Nogikh
2025-01-23 16:49 ` Carlos Llamas [this message]
2025-01-27 18:50 ` Aleksandr Nogikh
2025-01-23 19:06 ` Carlos Llamas
2025-01-23 20:26 ` syzbot
2025-01-24 0:11 ` Carlos Llamas
2025-01-24 0:20 ` Carlos Llamas
2025-01-24 1:05 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5JzA2OMokMz4Mic@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=dualli@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maco@android.com \
--cc=nogikh@google.com \
--cc=sfr@canb.auug.org.au \
--cc=surenb@google.com \
--cc=syzbot+7015dcf45953112c8b45@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox