From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [tip: timers/urgent] hrtimers: Mark is_migration_base() with __always_inline
Date: Thu, 23 Jan 2025 22:22:00 +0200 [thread overview]
Message-ID: <Z5Kk6Gr3-j_6XV8b@smile.fi.intel.com> (raw)
In-Reply-To: <173765959806.31546.5482091923819197685.tip-bot2@tip-bot2>
On Thu, Jan 23, 2025 at 07:13:18PM -0000, tip-bot2 for Andy Shevchenko wrote:
> The following commit has been merged into the timers/urgent branch of tip:
>
> Commit-ID: 27af31e44949fa85550176520ef7086a0d00fd7b
> Gitweb: https://git.kernel.org/tip/27af31e44949fa85550176520ef7086a0d00fd7b
> Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> AuthorDate: Thu, 16 Jan 2025 18:07:45 +02:00
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitterDate: Thu, 23 Jan 2025 20:06:35 +01:00
>
> hrtimers: Mark is_migration_base() with __always_inline
>
> When is_migration_base() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
>
> kernel/time/hrtimer.c:156:20: error: unused function 'is_migration_base' [-Werror,-Wunused-function]
> 156 | static inline bool is_migration_base(struct hrtimer_clock_base *base)
> | ^~~~~~~~~~~~~~~~~
>
> Fix this by marking it with __always_inline.
>
> [ tglx: Use __always_inline instead of __maybe_unused and move it into the
> usage sites conditional ]
This works, thanks!
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-01-23 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 16:07 [PATCH v1 1/1] hrtimer: Mark is_migration_base() with __maybe_unused Andy Shevchenko
2025-01-23 10:57 ` [tip: timers/urgent] hrtimers: Mark is_migration_base() with __always_inline tip-bot2 for Andy Shevchenko
2025-01-23 14:39 ` Andy Shevchenko
2025-01-23 19:02 ` Thomas Gleixner
2025-01-23 19:13 ` tip-bot2 for Andy Shevchenko
2025-01-23 20:22 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5Kk6Gr3-j_6XV8b@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox