From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2071.outbound.protection.outlook.com [40.107.93.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964EF1D79B4 for ; Fri, 24 Jan 2025 06:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.71 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737699675; cv=fail; b=FxEAS/swufYhgvjLYiMRqrjQ3fGHUyjY6gF/8Hvq6zhhL9QyEXfA96AgPvhNDAWQvkWcNzNlC/wSUEF9uH8hxOKDrZxffaQFZYX02tcYpVX4j3pQLGR5EYhLx5H73DOACqXGi7JGdP4nV9oJQNpU/Es2wmIRtunzMRZHd2Jo23o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737699675; c=relaxed/simple; bh=N46cOTSWjKZmzJbXvVCvPmkhUOYj+YIvOKaAIsXDntY=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=mvnL8qCwdcVqlyJ8BdQ9aOdMTxhtNHYIJo0QThjt2WGDwNSVuwZcwbmr8SIwAtFlcSfEz8LABNQ+D5zmFf5GbiQoL9VIqLTzTebQKmlLV9CDhlwRfcL561znDeb4+BunVNLzd5vRLHNh45IfenHhrz1fbxnFbt9NpBMaXdKFGLo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=gRNL5fw3; arc=fail smtp.client-ip=40.107.93.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gRNL5fw3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QIQUQd4xezF6SBEUALjgK4w4vfGZJdK2eVmXcZebFdKWy8CEyZp0EcAOkKxGXXvQTtdyuhDHtK+FSPRcpvqQOPzGk+djiS5CcAgWnYgpuEA+8JTR0QLlITxpuMlk2Hp0m8Pym2FDJSC3sH5TytErRShLVfiOR1gLIGrhcoIiy0Lk81Z88U+N3v5o5QyICdkjsjf/Yw0bF6Lpy3n7EGGFAy2b25BRQeerhKORk/mRZQJPO0tNyabFKrIQPrc/VWNeALy7Sm8MJD590HEOnxYoS/EBk+UYC4RRgdqaQ2thAG3yjT5OwJrEH7e36brOM60wpBcSHPwEMO6mpWIFJ89ZLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8yY3WJ2YS0ITVbaxC8dwBV9a6cc4BFIKfsjn2SVjOag=; b=Ue7eMg5HYCMGOem+UJVWfLCl3HG/J1ffIXpdjzoOZ+5dYeNKi6nr0HibQSliH0uixSS41z9wPP7L7x8c3w4vu47SWHYmJ62dyiHVbyIYOmyxqushJMMsmaq75azaggdiLN2R6o9G2e08qA1N1IDZvGViWMp49wZkrjNM689QOkF1pQ/YGX1zo28yObSCC5DudTXMKIyK3wipxwPkVNSPWLtkhrLnD4cEsZlXEH/OBaELONC72q/QOhdvfsRAYi9Zz5pXNXdfqapP9snZQPOiv4Cjivoqsm7q8zX3gYhS7Z7Y8DXfONuwngmP67rtVg1JHiuU5ziU6UZUkfhux5l6RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8yY3WJ2YS0ITVbaxC8dwBV9a6cc4BFIKfsjn2SVjOag=; b=gRNL5fw3CO8Yd+Pn3XKsrztaa/LjHo3gt0kj11CWJl2duVjmgJgkqwghjbM6pyg9M4G3RK424DCUmSXovHvt/FMcWAuvV/ghXuX2BuUpKVFdnAFIMjR2KK6mDjxl78Jo5//J/VjUJdlpZp0TyEkUtYj53nP6itBTmOTv14yOfIm2WTILbHvIr4Q9bwbPv3XY8/PenyfrTU9f6MvnlBaYtcom7CKQ/YBu1uucL+y0mlCXVLq4NjyD+ePPosl6aERPEUIfj6WfqxeIbyQMIlVDt1hXZHjnaX5CQGelEcbxe5WCF6bfOCJMyvKaPdi+yt+EuYa2p4XN96AjjfO9sKg4tQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) by PH8PR12MB6723.namprd12.prod.outlook.com (2603:10b6:510:1ce::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.20; Fri, 24 Jan 2025 06:21:09 +0000 Received: from CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5]) by CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5%3]) with mapi id 15.20.8356.020; Fri, 24 Jan 2025 06:21:09 +0000 Date: Fri, 24 Jan 2025 07:21:04 +0100 From: Andrea Righi To: Changwoo Min Cc: Tejun Heo , David Vernet , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched_ext: Fix lock imbalance in dispatch_to_local_dsq() Message-ID: References: <20250123234220.36680-1-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI1P293CA0019.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::16) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6405:EE_|PH8PR12MB6723:EE_ X-MS-Office365-Filtering-Correlation-Id: a2fe6d02-6c96-4bd1-a721-08dd3c3f4b0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gdqjtVueJNYwnpyNo92pWMpfwYK1S8hLg+q9LWsyiiJ3UwWaxTpWtudkm7lv?= =?us-ascii?Q?MHkiQHpOeqfzKD12rdlRt+G/lNx+6ND8m+L6p+684xocP8mF25D4RHGeSnUV?= =?us-ascii?Q?gdFU2pUurQlPw0zE8NMYLncBB30C3pyG3l/jA0qKDG00pX9c8kR7015EuRRi?= =?us-ascii?Q?c1s21WXNPGOziRVPgOgwZa2WKkVkArnu3pk97zEO5n47ta6wt3Y+hyEjPBU9?= =?us-ascii?Q?0bRO8Xp0HRzuA7yJhYRMVhSsC1nKJq+8SwJ8fjxu3A1Kya7vwVgKt7vCxEPe?= =?us-ascii?Q?u8vPJ6b3K6hyaf+iAzpNTAennQiGxWzdsvCs3pMBDe48rYCukT8EvEMPywLi?= =?us-ascii?Q?+iyMOKK4S1pPzOcsoHJ/MMfmgFn6aNuvYOtS5gVS0M52fUIY+ZWheIOhCsAL?= =?us-ascii?Q?YCcrhRH5UR7yMEbJYNdTJufONDYz52FYAeVS7Oe9CYRP9zSZPDYyxtgBXW01?= =?us-ascii?Q?I9PcgZ269bOOzvZAUb1Ww60SU3yTaAquTKGufJ0ymvYsWxvy7cDB8bvOP7pV?= =?us-ascii?Q?3dEW0ZY7d7QSFLAQfJya6aoPXbyRKRba4C2bZ++FVptoSrdMa0sRZvjvmN80?= =?us-ascii?Q?hi1URs5sBqhIsJiHFhPdf18NcFQldKR+F7XwYVBlAR5iFzxocTQQ5IvrviEm?= =?us-ascii?Q?S68/jRV/TtPapuI1K/PV6goyAhC6+0yyjJro6g0uEA+nugfBoPoO4n49Cyfg?= =?us-ascii?Q?yeBhao4q008xJ8hgPjzNcxdnwa7PHNQh9dxSUo5d6kCsFN4m2kDFViZGJFVT?= =?us-ascii?Q?A4i+eTNTBWi7rdTULe3dqYyfTXNr9CoDdjkLrzsa5ezN0Psxj+5jCqsWsZqi?= =?us-ascii?Q?iE587oSV9kKVvXIrTltV/sbs2ckxk6ofELOGe/v0Rc5G4L2+lMWbhMS8hOdO?= =?us-ascii?Q?wnZn8nuWJ5cq8udFEsyBOtbiny3LSkswb4U0ny5eZvCxFqBN7iGc38zj2u3X?= =?us-ascii?Q?XeGmQx/IMN73KzG1URzd1xrIzHmjwYLE2YX6N08WSwXXofVg3epv7sGTngWy?= =?us-ascii?Q?SWfEtL9uxjNNZPNeSqaKtqabhpGGv12uLw57egfNP8dL2IiGW9sMOxaBJv1g?= =?us-ascii?Q?ipsf+36NUtowezACi7AoVS3OeMiWdvbGF65hSOU6Vt6w2Xw3Pb3WuujCzqUM?= =?us-ascii?Q?pjY3QNqRLZMhxDHBi0FHWcU6wIcAtIE6O0WiZ4Odzc2H6S43Ch1xbieisNz3?= =?us-ascii?Q?JTi30wCn6FIIPTjZKtoljauu42ZB1SwXhO4vZui/KFbYylYsPZ2POHH5ZLka?= =?us-ascii?Q?uNmf3EdOuse2EM+6Aq6zJLEfBWBTngix7V60fbD01TD0hSoCvJLziwrHcc66?= =?us-ascii?Q?cDgNSJPaG1J8ggIIGnRqzvc/HMS/1oo2jwG39XA7kCk6clKpQBPuTrXLfwbo?= =?us-ascii?Q?wTCUP5CRS+bZuey+gID9RpqFP8zJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6405.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CSe2jtUJjXbN0P5T8sZhCnBpI0QtsUEpbg22EGwHF/+hEmn8SvUAaoLvNvpA?= =?us-ascii?Q?YBwq1FWZitarq4Eg72A8NiRHlzUnV+CXhSAaW/YLDaxOUi98fVrd/wQQdzGP?= =?us-ascii?Q?vMSLCPh1zDG1YVm7M2VNnstT9orJ0vuTA4vs396d5zTQurXs8Dr8xwP8SWN4?= =?us-ascii?Q?Po2ZpXDVTZ9WGoh0Q8lDl7p5EwNwRzCAz5ckYPo0bkW05+ogQS8FamGOV0g2?= =?us-ascii?Q?70kwIqsPzRy9i3pAICVJNd9l8Lw9nI4rQLkQRQWPZHgdnbDiLWAI4sNg+GVF?= =?us-ascii?Q?e6JUfu62DIGU1uq8TBHH0lhuQkAmV3w4c6YQ09ETa6xAr8MOkxbYFSSmUpzW?= =?us-ascii?Q?AA+WPW+Xx53M7EXdiA52mr+Tvf5dU6dhRZZH0jQZbuYSeiundpfZKrHilO+9?= =?us-ascii?Q?M6hgCkvbZ29KfQb14d1BV0n7+7is69aLfovClMih76mYjZIy4ZcmnpJ+CTIC?= =?us-ascii?Q?RvXpgJICrRB1RGXsaTviQKRbPKo1C+t0vfrI6WA7CZhFeFzce62gHVaABk1B?= =?us-ascii?Q?cKrlyQ40shcZnDTQ8wRD63kfUwRqeHP+mnsaxxgbJ0kTdNApKbhuJsT/9kd3?= =?us-ascii?Q?tOWjw3Mdx+Pby4jUDxRPLHFAxvXbnMIaKYIwCpkfzfvATnQodCw/rZtiSrEo?= =?us-ascii?Q?246cZAoTjLuC0IhMbkqZtKvmGHelRnW9F1pdEmiolgRa1bigdFKfO61wsqnI?= =?us-ascii?Q?K1IG4G52GbG5Qwi99Qk7lGoisMdZoLWIQgxnOTE1pNILSg/75wBbqV8GvM6E?= =?us-ascii?Q?eOTrRTTLz56VI9TJWxI/6PxaK8XbhrL3uUzfpbLARAPQ3fT4RtCzHiZCRBme?= =?us-ascii?Q?DbG7qfC96lgf1kZmjV5doSAxdvXAH+J4bwShEEPcOgxSArCHuxBk9ARDn6cM?= =?us-ascii?Q?Cdso76GqQWv0w9bicJgkEa/v4S28gwR9E6ACQv17GpMm/a/ZJPlks6/7u51L?= =?us-ascii?Q?fAYR7O+GvWc8niTxVHK0jvnHY3oDvrcxaZEbL+Jv6QypJUeGDjEGbtdAxvMq?= =?us-ascii?Q?3d7DGP5pqhZ8d+pbxNLUQfj367bPfLxtVi6Xi6cQhvbmESBagrHzSFY+RyAA?= =?us-ascii?Q?D4meftX+Mw1Jg0xH96kFoDsM3S5qNsBNAIbMep0RBPvWA0TfZXfK7V3cDkMB?= =?us-ascii?Q?iq/A4VJhxcIbN0YD5QGYrC7j+UZ/B2EvyfakZ44sHagj2CiFG5N7sqHv9BTP?= =?us-ascii?Q?K9zzjkt/XLYIGwFtcukmjlJDJ4SjSouqiuJOIHEKrAAkL0oZkUoBK1mYOycP?= =?us-ascii?Q?eFE3DgUa+ucxzWD6E1Fch6Q8CPbdLHQ282aEsXFVEer56Ev2spL3BeB7XTVR?= =?us-ascii?Q?h19FtweB1owyfPBt1gkwmstfIrxbzpT+UzpuT6g9bCZ/WUSdrZyYkID1dVHL?= =?us-ascii?Q?yHFCvQfn2Q3apGe5UJR019l3r4CgwwRDuemekacLJDhmhvLNe96oVXc1twjo?= =?us-ascii?Q?weTrItirT8pwQE0aqpuWeIhb9DWk7tKUGSyuHTqYFZowaCG8q35dExIqu6mA?= =?us-ascii?Q?m8IVkRWQOcwlSXbi5dvlfPP8wO/5nFLns0DuR9dMSSIBulrbM17cp54SK1ku?= =?us-ascii?Q?d77ngMLOwbGQVpnyfukXpGyLqxtHrCDve9Hyj/TV?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2fe6d02-6c96-4bd1-a721-08dd3c3f4b0c X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2025 06:21:09.7119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LAdN1kZ3e1cBXvxO2wKtvjmjfARVgT2p/nm8m1j9dnyssEGUU50TsZdf8S1ILwwNcYdqEx4YVQqD6/ZaQ4g0+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6723 On Fri, Jan 24, 2025 at 11:21:33AM +0900, Changwoo Min wrote: > Hello Andrea, > > On 25. 1. 24. 08:42, Andrea Righi wrote: > > kernel/sched/ext.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c > > index a24d48cebfb7..7500b1a26757 100644 > > --- a/kernel/sched/ext.c > > +++ b/kernel/sched/ext.c > > @@ -2617,6 +2617,8 @@ static void dispatch_to_local_dsq(struct rq *rq, struct scx_dispatch_q *dst_dsq, > > /* if the destination CPU is idle, wake it up */ > > if (sched_class_above(p->sched_class, dst_rq->curr->sched_class)) > > resched_curr(dst_rq); > > + } else { > > + dst_rq = src_rq; > > } > > The fix makes sense to me. Since this is a very specific and > tricky case, it will be better to include detailed comments in > the else part so anyone can easily understand why the else part > is necessary. Good idea, I'll send a v2 including a comment in the else part. Thanks! -Andrea