Re: [PATCH v4 2/3] hwmon: (pmbus/adp1050): Add support for adp1051, adp1055 and ltp8800

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, Jan 24, 2025 at 11:17:45PM +0800, Cedric Encarnacion wrote:
> Introduce hardware monitoring support for the following devices:
> 
>     ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
>     ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
>     LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
> 
> The ADP1051 and ADP1055 are similar digital controllers for high
> efficiency DC-DC power conversion while the LTP8800 is a family of
> step-down μModule regulators that provides microprocessor core voltage
> from 54V power distribution architecture. All of the above components
> features telemetry monitoring of input/output voltage, input current,
> output power, and temperature over PMBus.

...

>  static const struct i2c_device_id adp1050_id[] = {
> -	{"adp1050"},
> +	{ .name = "adp1050", .driver_data = (kernel_ulong_t)&adp1050_info},
> +	{ .name = "adp1051", .driver_data = (kernel_ulong_t)&adp1051_info},
> +	{ .name = "adp1055", .driver_data = (kernel_ulong_t)&adp1055_info},
> +	{ .name = "ltp8800", .driver_data = (kernel_ulong_t)&ltp8800_info},

Seems like missing inner trailing space.

>  	{}
>  };

...

>  static const struct of_device_id adp1050_of_match[] = {
> -	{ .compatible = "adi,adp1050"},
> +	{ .compatible = "adi,adp1050", .data = &adp1050_info},
> +	{ .compatible = "adi,adp1051", .data = &adp1051_info},
> +	{ .compatible = "adi,adp1055", .data = &adp1055_info},
> +	{ .compatible = "adi,ltp8800", .data = &ltp8800_info},

Ditto.

>  	{}
>  };

-- 
With Best Regards,
Andy Shevchenko