* [PATCH v4 1/3] dt-bindings: hwmon: (pmbus/adp1050): Add adp1051, adp1055 and ltp8800
2025-01-24 15:17 [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Cedric Encarnacion
@ 2025-01-24 15:17 ` Cedric Encarnacion
2025-01-24 16:33 ` Conor Dooley
2025-01-24 15:17 ` [PATCH v4 2/3] hwmon: (pmbus/adp1050): Add support for " Cedric Encarnacion
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Cedric Encarnacion @ 2025-01-24 15:17 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-i2c, linux-doc, linux-hwmon
Cc: Guenter Roeck, Jean Delvare, Jonathan Corbet, Delphine CC Chiu,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Radu Sabau,
Uwe Kleine-König, Alexis Czezar Torreno, Cedric Encarnacion,
Andy Shevchenko
Add support for adp1051, adp1055, and ltp8800.
ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
---
.../bindings/hwmon/pmbus/adi,adp1050.yaml | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
index 10c2204bc3df..af7530093942 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml
@@ -10,16 +10,27 @@ maintainers:
- Radu Sabau <radu.sabau@analog.com>
description: |
- The ADP1050 is used to monitor system voltages, currents and temperatures.
+ The ADP1050 and similar devices are used to monitor system voltages,
+ currents, power, and temperatures.
+
Through the PMBus interface, the ADP1050 targets isolated power supplies
and has four individual monitors for input/output voltage, input current
and temperature.
Datasheet:
https://www.analog.com/en/products/adp1050.html
+ https://www.analog.com/en/products/adp1051.html
+ https://www.analog.com/en/products/adp1055.html
+ https://www.analog.com/en/products/ltp8800-1a.html
+ https://www.analog.com/en/products/ltp8800-2.html
+ https://www.analog.com/en/products/ltp8800-4a.html
properties:
compatible:
- const: adi,adp1050
+ enum:
+ - adi,adp1050
+ - adi,adp1051
+ - adi,adp1055
+ - adi,ltp8800
reg:
maxItems: 1
--
2.39.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 2/3] hwmon: (pmbus/adp1050): Add support for adp1051, adp1055 and ltp8800
2025-01-24 15:17 [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Cedric Encarnacion
2025-01-24 15:17 ` [PATCH v4 1/3] dt-bindings: hwmon: (pmbus/adp1050): Add adp1051, adp1055 and ltp8800 Cedric Encarnacion
@ 2025-01-24 15:17 ` Cedric Encarnacion
2025-01-24 16:23 ` Andy Shevchenko
` (3 more replies)
2025-01-24 15:17 ` [PATCH v4 3/3] hwmon: (pmbus/adp1050): Add regulator support for ltp8800 Cedric Encarnacion
2025-01-24 16:24 ` [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Andy Shevchenko
3 siblings, 4 replies; 10+ messages in thread
From: Cedric Encarnacion @ 2025-01-24 15:17 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-i2c, linux-doc, linux-hwmon
Cc: Guenter Roeck, Jean Delvare, Jonathan Corbet, Delphine CC Chiu,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Radu Sabau,
Uwe Kleine-König, Alexis Czezar Torreno, Cedric Encarnacion,
Andy Shevchenko
Introduce hardware monitoring support for the following devices:
ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
The ADP1051 and ADP1055 are similar digital controllers for high
efficiency DC-DC power conversion while the LTP8800 is a family of
step-down μModule regulators that provides microprocessor core voltage
from 54V power distribution architecture. All of the above components
features telemetry monitoring of input/output voltage, input current,
output power, and temperature over PMBus.
Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
---
Documentation/hwmon/adp1050.rst | 71 ++++++++++++++++++++++++++++++---
drivers/hwmon/pmbus/adp1050.c | 62 ++++++++++++++++++++++++++--
2 files changed, 124 insertions(+), 9 deletions(-)
diff --git a/Documentation/hwmon/adp1050.rst b/Documentation/hwmon/adp1050.rst
index 8fa937064886..32514084fbdc 100644
--- a/Documentation/hwmon/adp1050.rst
+++ b/Documentation/hwmon/adp1050.rst
@@ -13,6 +13,32 @@ Supported chips:
Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADP1050.pdf
+ * Analog Devices ADP1051
+
+ Prefix: 'adp1051'
+
+ Addresses scanned: I2C 0x70 - 0x77
+
+ Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADP1051.pdf
+
+ * Analog Devices ADP1055
+
+ Prefix: 'adp1055'
+
+ Addresses scanned: I2C 0x4B - 0x77
+
+ Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADP1055.pdf
+
+ * Analog Devices LTP8800-1A/-2/-4A
+
+ Prefix: 'ltp8800'
+
+ Addresses scanned: -
+
+ Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/LTP8800-1A.pdf
+ https://www.analog.com/media/en/technical-documentation/data-sheets/LTP8800-2.pdf
+ https://www.analog.com/media/en/technical-documentation/data-sheets/LTP8800-4A.pdf
+
Authors:
- Radu Sabau <radu.sabau@analog.com>
@@ -21,14 +47,17 @@ Authors:
Description
-----------
-This driver supprts hardware monitoring for Analog Devices ADP1050 Digital
-Controller for Isolated Power Supply with PMBus interface.
+This driver supports hardware monitoring for Analog Devices ADP1050, ADP1051,
+and ADP1055 Digital Controller for Isolated Power Supply with PMBus interface,
+and the LTP8800 step-down μModule regulators.
-The ADP1050 is an advanced digital controller with a PMBus™
+The ADP1050, ADP1051, and ADP1055 are advanced digital controllers with PMBus™
interface targeting high density, high efficiency dc-to-dc power
-conversion used to monitor system temperatures, voltages and currents.
-Through the PMBus interface, the device can monitor input/output voltages,
-input current and temperature.
+conversion used to monitor system temperatures, voltages and currents. The
+LTP8800 is a family of step-down μModule regulators that provides microprocessor
+core voltage from 54V power distribution architecture. Through the PMBus
+interface, the device can monitor input/output voltages, input current and
+temperature.
Usage Notes
-----------
@@ -49,16 +78,46 @@ Sysfs Attributes
in1_label "vin"
in1_input Measured input voltage
in1_alarm Input voltage alarm
+in1_crit Critical maximum input voltage
+in1_crit_alarm Input voltage high alarm
+in1_lcrit Critical minimum input voltage
+in1_lcrit_alarm Input voltage critical low alarm
in2_label "vout1"
in2_input Measured output voltage
in2_crit Critical maximum output voltage
in2_crit_alarm Output voltage high alarm
in2_lcrit Critical minimum output voltage
in2_lcrit_alarm Output voltage critical low alarm
+in2_max Critical maximum output voltage
+in2_max_alarm Output voltage critical max alarm
+in2_min Critical minimum output voltage
+in2_min_alarm Output voltage critical min alarm
curr1_label "iin"
curr1_input Measured input current.
curr1_alarm Input current alarm
+curr1_crit Critical maximum input current
+curr1_crit_alarm Input current high alarm
+curr2_label "iout1"
+curr2_input Measured output current
+curr2_alarm Output current alarm
+curr2_crit Critical maximum output current
+curr2_crit_alarm Output current high alarm
+curr2_lcrit Critical minimum output current
+curr2_lcrit_alarm Output current critical low alarm
+curr2_max Critical maximum output current
+curr2_max_alarm Output current critical max alarm
+power1_label "pout1"
+power1_input Measured output power
+power1_crit Critical maximum output power
+power1_crit_alarm Output power high alarm
temp1_input Measured temperature
temp1_crit Critical high temperature
temp1_crit_alarm Chip temperature critical high alarm
+temp1_max Critical maximum temperature
+temp1_max_alarm Temperature critical max alarm
+temp2_input Measured temperature
+temp2_crit Critical high temperature
+temp2_crit_alarm Chip temperature critical high alarm
+temp2_max Critical maximum temperature
+temp2_max_alarm Temperature critical max alarm
================= ========================================
diff --git a/drivers/hwmon/pmbus/adp1050.c b/drivers/hwmon/pmbus/adp1050.c
index ef46c880b168..2f75e8f1424d 100644
--- a/drivers/hwmon/pmbus/adp1050.c
+++ b/drivers/hwmon/pmbus/adp1050.c
@@ -23,19 +23,75 @@ static struct pmbus_driver_info adp1050_info = {
| PMBUS_HAVE_STATUS_TEMP,
};
+static struct pmbus_driver_info adp1051_info = {
+ .pages = 1,
+ .format[PSC_VOLTAGE_IN] = linear,
+ .format[PSC_VOLTAGE_OUT] = linear,
+ .format[PSC_CURRENT_IN] = linear,
+ .format[PSC_TEMPERATURE] = linear,
+ .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN
+ | PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT
+ | PMBUS_HAVE_TEMP
+ | PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_STATUS_IOUT
+ | PMBUS_HAVE_STATUS_INPUT
+ | PMBUS_HAVE_STATUS_TEMP,
+};
+
+static struct pmbus_driver_info adp1055_info = {
+ .pages = 1,
+ .format[PSC_VOLTAGE_IN] = linear,
+ .format[PSC_VOLTAGE_OUT] = linear,
+ .format[PSC_CURRENT_IN] = linear,
+ .format[PSC_TEMPERATURE] = linear,
+ .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN
+ | PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT
+ | PMBUS_HAVE_TEMP2 | PMBUS_HAVE_TEMP3
+ | PMBUS_HAVE_POUT
+ | PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_STATUS_IOUT
+ | PMBUS_HAVE_STATUS_INPUT
+ | PMBUS_HAVE_STATUS_TEMP,
+};
+
+static struct pmbus_driver_info ltp8800_info = {
+ .pages = 1,
+ .format[PSC_VOLTAGE_IN] = linear,
+ .format[PSC_VOLTAGE_OUT] = linear,
+ .format[PSC_CURRENT_IN] = linear,
+ .format[PSC_TEMPERATURE] = linear,
+ .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN
+ | PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT
+ | PMBUS_HAVE_TEMP
+ | PMBUS_HAVE_POUT
+ | PMBUS_HAVE_STATUS_VOUT
+ | PMBUS_HAVE_STATUS_INPUT
+ | PMBUS_HAVE_STATUS_TEMP,
+};
+
static int adp1050_probe(struct i2c_client *client)
{
- return pmbus_do_probe(client, &adp1050_info);
+ struct pmbus_driver_info *info;
+
+ info = i2c_get_match_data(client);
+ if (!info)
+ return -ENODEV;
+
+ return pmbus_do_probe(client, info);
}
static const struct i2c_device_id adp1050_id[] = {
- {"adp1050"},
+ { .name = "adp1050", .driver_data = (kernel_ulong_t)&adp1050_info},
+ { .name = "adp1051", .driver_data = (kernel_ulong_t)&adp1051_info},
+ { .name = "adp1055", .driver_data = (kernel_ulong_t)&adp1055_info},
+ { .name = "ltp8800", .driver_data = (kernel_ulong_t)<p8800_info},
{}
};
MODULE_DEVICE_TABLE(i2c, adp1050_id);
static const struct of_device_id adp1050_of_match[] = {
- { .compatible = "adi,adp1050"},
+ { .compatible = "adi,adp1050", .data = &adp1050_info},
+ { .compatible = "adi,adp1051", .data = &adp1051_info},
+ { .compatible = "adi,adp1055", .data = &adp1055_info},
+ { .compatible = "adi,ltp8800", .data = <p8800_info},
{}
};
MODULE_DEVICE_TABLE(of, adp1050_of_match);
--
2.39.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 3/3] hwmon: (pmbus/adp1050): Add regulator support for ltp8800
2025-01-24 15:17 [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Cedric Encarnacion
2025-01-24 15:17 ` [PATCH v4 1/3] dt-bindings: hwmon: (pmbus/adp1050): Add adp1051, adp1055 and ltp8800 Cedric Encarnacion
2025-01-24 15:17 ` [PATCH v4 2/3] hwmon: (pmbus/adp1050): Add support for " Cedric Encarnacion
@ 2025-01-24 15:17 ` Cedric Encarnacion
2025-01-24 16:24 ` [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Andy Shevchenko
3 siblings, 0 replies; 10+ messages in thread
From: Cedric Encarnacion @ 2025-01-24 15:17 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-i2c, linux-doc, linux-hwmon
Cc: Guenter Roeck, Jean Delvare, Jonathan Corbet, Delphine CC Chiu,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Radu Sabau,
Uwe Kleine-König, Alexis Czezar Torreno, Cedric Encarnacion,
Andy Shevchenko
Add regulator support for the single-channel LTP8800-1A/-2/-4A
150A/135A/200A DC/DC µModule Regulator.
Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
---
drivers/hwmon/pmbus/Kconfig | 9 +++++++++
drivers/hwmon/pmbus/adp1050.c | 10 ++++++++++
2 files changed, 19 insertions(+)
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 419469f40ba0..a890cf3aef91 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -67,6 +67,15 @@ config SENSORS_ADP1050
This driver can also be built as a module. If so, the module will
be called adp1050.
+config SENSORS_ADP1050_REGULATOR
+ bool "Regulator support for ADP1050 and compatibles"
+ depends on SENSORS_ADP1050 && REGULATOR
+ help
+ If you say yes here you get regulator support for Analog Devices
+ LTP8800-1A, LTP8800-4A, and LTP8800-2. LTP8800 is a family of DC/DC
+ µModule regulators that can provide microprocessor power from 54V
+ power distribution architecture.
+
config SENSORS_BEL_PFE
tristate "Bel PFE Compatible Power Supplies"
help
diff --git a/drivers/hwmon/pmbus/adp1050.c b/drivers/hwmon/pmbus/adp1050.c
index 2f75e8f1424d..a835ecf5c7fc 100644
--- a/drivers/hwmon/pmbus/adp1050.c
+++ b/drivers/hwmon/pmbus/adp1050.c
@@ -11,6 +11,12 @@
#include "pmbus.h"
+#if IS_ENABLED(CONFIG_SENSORS_ADP1050_REGULATOR)
+static const struct regulator_desc adp1050_reg_desc[] = {
+ PMBUS_REGULATOR_ONE("vout"),
+};
+#endif /* CONFIG_SENSORS_ADP1050_REGULATOR */
+
static struct pmbus_driver_info adp1050_info = {
.pages = 1,
.format[PSC_VOLTAGE_IN] = linear,
@@ -65,6 +71,10 @@ static struct pmbus_driver_info ltp8800_info = {
| PMBUS_HAVE_STATUS_VOUT
| PMBUS_HAVE_STATUS_INPUT
| PMBUS_HAVE_STATUS_TEMP,
+#if IS_ENABLED(CONFIG_SENSORS_ADP1050_REGULATOR)
+ .num_regulators = 1,
+ .reg_desc = adp1050_reg_desc,
+#endif
};
static int adp1050_probe(struct i2c_client *client)
--
2.39.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A
2025-01-24 15:17 [PATCH v4 0/3] Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A Cedric Encarnacion
` (2 preceding siblings ...)
2025-01-24 15:17 ` [PATCH v4 3/3] hwmon: (pmbus/adp1050): Add regulator support for ltp8800 Cedric Encarnacion
@ 2025-01-24 16:24 ` Andy Shevchenko
3 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2025-01-24 16:24 UTC (permalink / raw)
To: Cedric Encarnacion
Cc: devicetree, linux-kernel, linux-i2c, linux-doc, linux-hwmon,
Guenter Roeck, Jean Delvare, Jonathan Corbet, Delphine CC Chiu,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Radu Sabau,
Uwe Kleine-König, Alexis Czezar Torreno
On Fri, Jan 24, 2025 at 11:17:43PM +0800, Cedric Encarnacion wrote:
> This patch is a continuation of this series:
>
> Link: https://lore.kernel.org/20241120035826.3920-1-cedricjustine.encarnacion@analog.com
>
> which is a combined series from two original patch series for each of the
> above family of devices. Both LTP8800 and ADP1051/55 have similar set of
> registers. The series was v2 of one and v3 of another. Hence, as suggested,
> this patch proceeds to v4 which succeeds the highest.
Cool series! With small issue addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for patches 2 & 3 (no DT covered, not my area)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread