From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6C821C19F for ; Fri, 24 Jan 2025 15:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737732363; cv=none; b=Mlqzhd76o83OLkAUNCIxo8Fb98amCDkbBjO+VTsIc40l6/+UzImNzHBNadrLXNDLTGeqV+v/sqHWOtSm1VNa71wPkuP4j+mCE8W2eFC5HYebuxT/7i8k40mwkO7oUVrPpxQLPXJ1Vg6rjyt/InxivcvPN5PYIfdfSLq59L9DKLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737732363; c=relaxed/simple; bh=6GHxWl2UV8gfYP1EZFQe/Gt4LQDsnl2G+0aHzs0dZ2w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VGRdeu1h6UwF65xGHdjGwolXrPMZl7FOyCg5iLAp1PtBeEAnDpny4W1rJbUInwPAmRcgro781szMFFTnn/mC9ovJqV57H8NM3cQUKSPKxll64Nlw10XOPjbamm3Bh3QDUs018JrXLfQXzEpft39x/1Y7VClvxcBz5HPidm46oNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=tKTHwNHQ; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="tKTHwNHQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yk0WtuB7IBBdB2ZubHqj5SIqZBKyHzKI9J09Po15jvk=; b=tKTHwNHQ4yuj7LOxZkoipl3w3L +pmwpEagZ8nSo9vzYEWpJgTlFO3b3MJK6WY859s2lsog9Jcv+r1Ejwpr7vQllnZjACwkrD+0REPZj JPwFC180N1a1Q6qfTtZW7OLxMDJBLWTp+IDZokMfewC1Y6Yq/cdYhpk0CogSjJytiSWVMjvVsODKM /PrjietXElqRu9sOkSDsG53qNOHdDt3LFofeDz8wGa0sI9AkoKpJ0mU6B8EzjH+1cbceDegqB0NI2 pgEXNx89wQ5DFGzUgE8py24EFw/RyMqTDon+lpwNofSx1dw6qDFWpwp8Dj2+F+qnfdzqzrLk4K5dv 47fZxoTQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37958) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tbLZE-0002SG-0p; Fri, 24 Jan 2025 15:25:56 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tbLZB-00074j-1R; Fri, 24 Jan 2025 15:25:53 +0000 Date: Fri, 24 Jan 2025 15:25:53 +0000 From: "Russell King (Oracle)" To: Yuntao Liu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ruanjinjie@huawei.com, kees@kernel.org, masahiroy@kernel.org, ardb@kernel.org Subject: Re: [PATCH -next] arm32/boot/compressed: Force hidden visibility for all symbol references Message-ID: References: <20250124082030.764417-1-liuyuntao12@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124082030.764417-1-liuyuntao12@huawei.com> Sender: Russell King (Oracle) On Fri, Jan 24, 2025 at 08:20:30AM +0000, Yuntao Liu wrote: > Eliminate all GOT entries in the decompressor binary, by forcing hidden > visibility for all symbol references, which informs the compiler that > such references will be resolved at link time without the need for > allocating GOT entries. One question. Why. I don't think this is desirable. We don't want the linker to fully resolve references at link time - we specifically want a GOT so that at run time the decompressor can resolve the references irrespective of where the decompressor is loaded - in other words, allowing the decompressor to be loaded anywhere in memory. We do not link the decompressor for any specific address, and thus the only way the decompressor can work is by fixing up the GOT. Unless you can demonstrate that the GOT is no longer required, then based on your commit description... hard NAK. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!