From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CDB31D8DFB for ; Fri, 24 Jan 2025 19:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737747630; cv=none; b=oQRa6a3eNWSdBzKVOIQ7nns+lKsP47yEwr472Z40i9dP/8olfc5Hq8mowUhlHym5UJIeo3pztxT0qVFlyuarRuYtX0Huc0ZGrRArP4WWamG/0p7bX6YSQDUVyz3ilUt4P5d7MyCTOdCQFjItRxkZVe+6QvTu3WF8lkoNrQjloHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737747630; c=relaxed/simple; bh=7u/oXjBRZp/xICilidPMGfoO3yKFUNQrNcrjM+JLEOQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=A67Hb2ZAAXu4EfeknT42Jx5JqyQV3I7szD7DT4B/QvKSA8cVeP9QOLQ0QEwut7aJ6Kbi5EIpDiEGPQWlFr965oSYudIRNNthuwWguSD6/OQbPHODEGbjgG2bp7k0ufjIOynFa7N8pGkkCZQ2rVEh0+AMNcKyAkpeyzgEh8D0m10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tGCEBmVB; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tGCEBmVB" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-219f8263ae0so47318675ad.0 for ; Fri, 24 Jan 2025 11:40:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737747628; x=1738352428; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:from:to:cc:subject:date:message-id:reply-to; bh=XeTFUke24YztL2UFTa1EA42MEpaJFIIZjeHmRdx9I0M=; b=tGCEBmVBW03gAbx7+KQlmgYSZMvK8u8SmYISov6WgHorPoEbbBNHZ0xaWmGm+HVjeX GccmBZtA0oPkLdoSFdZPjqfcbVRcuAlOb42D0CqqK0HMCpAPMUPz8sjSfJP2U6Ee2i1/ PnvNHtUZl9zyPsJTeqarTq09Sc37B5nDW4y3DfwuxawW1c9NOtgLH7n/H3bomQyVts6j E7R2uEDqR71HSrwtrg4TPUT1fGq9r44nEJ5WG+D65tWlN3k8V/gUJ9dqj5M/7ZX9M1Ty VY5Z6jS/+5B/Ql+PELxs63tkuL+nlfxISRNRyTdvSsyAhKGN7G74c7fifH024aDuZSvq 3a4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737747628; x=1738352428; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XeTFUke24YztL2UFTa1EA42MEpaJFIIZjeHmRdx9I0M=; b=e/YVcrpYIr9i4Qz1Q1mi9NhsSLIBifsxFJWWyLOlrCddChSbXoVxpIx9Vq6VKS4uz1 nyADGv0yE328fJhYQPaRPDD1bYWFCSgFbgY0Stszg84EK2L7Gftii0ocqIjxq30MBrIK oifswguaXU6CUEvrntNWi4M1fe19oKubvdbk9n6H8W/9laue1Kyrw1QeVxjcplAZVTGU iDODFdCnbDXP8iB9QmRRghvSfO9pEQ85YSc1Wz+J0BF7tF5gWgVjSfvFh90VCYE9GgyA Aa1Tzcyujypwz9v/evaFEU1xLyn3mb5Lk11k3MPVhQWxq1Djz9L1AXqljX8e08O1nEqd tjSQ== X-Forwarded-Encrypted: i=1; AJvYcCUPtJ6xtydYmeIeYeeTG6xXMGZ7dAG85he9ydTAvSaJsu/vvO9LNhZhJ4L3VqtEBrffYyIFNYYNdA+1sG0=@vger.kernel.org X-Gm-Message-State: AOJu0YzYZLdBMH3ZwDXnMwMyav8Iz3tVuFxhV8gXxabZ4EgL61nU6UWy tuH1SLrAeJpXDxEqDT03S4+rMH6TYZHOu99N2z7WmV8Ni5gREz2WwBCzuaieCQ== X-Gm-Gg: ASbGnct7zOTHP0dHYVmWSbo5I0sheKOwuQunE+/2jG8R8CrMuVmY64FTFTozuY0/0K8 VRaTdIpdx/Pn/TyYB6/SPr6XSdTkbn2inzZ0xvyJ1lZXCCjiPTyeXa48kkUdmKsySOa+lSuyW30 rHRtm0J+k9xUNHWtbMg5JTjBzv+IhCeimeZvDrs0gxK4FZTe+jI1z85zZZGt2QICooQtwMdCARV 0jfhx0ETWqbJ7bm3B6lyWa4yAAR59C+WDW3y4iaSu34KOzmZLNuI6mnoPKguj5T2AtiRXX8VZ1I 6nYepNXx3TW3ML29dHP3H38pFiEGZmIxiqBGgfudMyfK9yaSMiA= X-Google-Smtp-Source: AGHT+IED3i4wnCoiLFROaAx+kXZsYkw8NBVlPE2QiqDLo+oCmVgIvJn05HRKiZA5a7lTiHsXuu3C/w== X-Received: by 2002:a17:902:ce8a:b0:216:32c4:f7f5 with SMTP id d9443c01a7336-21c3540c7a1mr484270375ad.19.1737747628323; Fri, 24 Jan 2025 11:40:28 -0800 (PST) Received: from google.com (28.67.125.34.bc.googleusercontent.com. [34.125.67.28]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414db35sm20118915ad.195.2025.01.24.11.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 11:40:26 -0800 (PST) Sender: Benson Leung Date: Fri, 24 Jan 2025 19:40:23 +0000 From: Benson Leung To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, abhishekpandit@chromium.org, dan.carpenter@linaro.org Cc: bleung@chromium.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, akuchynski@google.com, ukaszb@chromium.org Subject: [PATCH 1/2] usb: typec: thunderbolt: Fix loops that iterate TYPEC_PLUG_SOP_P and TYPEC_PLUG_SOP_PP Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Fixes these Smatch static checker warnings: drivers/usb/typec/altmodes/thunderbolt.c:116 tbt_altmode_work() warn: why is zero skipped 'i' drivers/usb/typec/altmodes/thunderbolt.c:147 tbt_enter_modes_ordered() warn: why is zero skipped 'i' drivers/usb/typec/altmodes/thunderbolt.c:328 tbt_altmode_remove() warn: why is zero skipped 'i' Fixes: 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode") Signed-off-by: Benson Leung Reported-by: Dan Carpenter --- drivers/usb/typec/altmodes/thunderbolt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/altmodes/thunderbolt.c b/drivers/usb/typec/altmodes/thunderbolt.c index 1b475b1d98e7..94e47d30e598 100644 --- a/drivers/usb/typec/altmodes/thunderbolt.c +++ b/drivers/usb/typec/altmodes/thunderbolt.c @@ -112,7 +112,7 @@ static void tbt_altmode_work(struct work_struct *work) return; disable_plugs: - for (int i = TYPEC_PLUG_SOP_PP; i > 0; --i) { + for (int i = TYPEC_PLUG_SOP_PP; i >= 0; --i) { if (tbt->plug[i]) typec_altmode_put_plug(tbt->plug[i]); @@ -143,7 +143,7 @@ static int tbt_enter_modes_ordered(struct typec_altmode *alt) if (tbt->plug[TYPEC_PLUG_SOP_P]) { ret = typec_cable_altmode_enter(alt, TYPEC_PLUG_SOP_P, NULL); if (ret < 0) { - for (int i = TYPEC_PLUG_SOP_PP; i > 0; --i) { + for (int i = TYPEC_PLUG_SOP_PP; i >= 0; --i) { if (tbt->plug[i]) typec_altmode_put_plug(tbt->plug[i]); @@ -324,7 +324,7 @@ static void tbt_altmode_remove(struct typec_altmode *alt) { struct tbt_altmode *tbt = typec_altmode_get_drvdata(alt); - for (int i = TYPEC_PLUG_SOP_PP; i > 0; --i) { + for (int i = TYPEC_PLUG_SOP_PP; i >= 0; --i) { if (tbt->plug[i]) typec_altmode_put_plug(tbt->plug[i]); } -- 2.48.1.262.g85cc9f2d1e-goog