From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D48721A43C for ; Fri, 24 Jan 2025 19:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737747645; cv=none; b=T9FAaA07ZJkneJG6F5d2a3wWgzSu/Y7viykNnZ1SZCo1UgFu74ETAlVDYfdX3FANIx5feUYeopyUgYyWuL/KgncugHYO4Cp0V3Z7yKSduy7WzhkVTB/pFEDXEej2ha7yKK8bNJttSdAJ5meNwYJQlPzSPFJO+TfLQoLMvpaNhc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737747645; c=relaxed/simple; bh=QwYO9PZxCThzcCpITbcXVs1XiBBnSgAirneVfxCQzwQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=LhD2xlOCwEcKwArw1ov/94FVfkrQ6EcQ3xZto5obukiPZlOwY6CUA36tQknw5YkeBUjcflwph5oS3KGoxNSD8je9dADm7CoucJDk0T+As2HiNJe4VqkAB1ffrb8AWpqcCu1xYJPmsL7H62A/XD2ypmj491S7MT1akITy5Fk9beY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r8iGu4Sr; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r8iGu4Sr" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21631789fcdso49036505ad.1 for ; Fri, 24 Jan 2025 11:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737747643; x=1738352443; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:from:to:cc:subject:date:message-id:reply-to; bh=RsA2Td0GmZhvsNv3upCcErafZhW9TcZYUo0FDnBPQBg=; b=r8iGu4Sr/GQUJmhf6uELTcKf7ZHAwBRsKre/QpKLe/GD0HXoS734flNQpnWs+mPWij P40DE+OfMjTAryITZUPjQpMO3DH2S55rjTQMjT/TATItjNtMuNufQJqEA1jDjQ3BGBk4 3OKC2GKbcc+Ep6GoYE8n/V4EuI5TJMAk/aG5wcCiGtSS0MOgtGDme+Sr9Ic2oC8CnsUI AygUPE/ROlUzzvzVhg5iUXO7uJjHDUi8RNUQWfGk7p+G4Aq9kOCQLjVFXBsd24ZPg8fU HrR+H0j5/01kWltSBeQ9/zVR9dGJSRXpf1JXldFyzNxAHMnXFjfnW5GhXe2mPua2sIo6 5K5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737747643; x=1738352443; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RsA2Td0GmZhvsNv3upCcErafZhW9TcZYUo0FDnBPQBg=; b=MmDoBcTa9ejAloAucfLssv4skpt85LpOKu1UKmfYJVVz7rXbMH9T4h5j9LuCMc6QWZ i+xpjlWzZxTJzPb3Z1+o0BwS+0plRWIn5ByFrkwGWuzTv29sZKwq4xJo9jRklt/SrHGe +ADEk1D4xJNHStfCokJg8+/ypWPaxChHGrd3VadMrlVyPGHe1sN89cvWsCKor5bNKdYV FD6WgY19jobSbRH+gSpZqi1wkHHPt/vd96KTfg7C4Nu8NJqwo8CSIVJvy3q94W70qPjV pDLUTFR4JY9IY3TsriUoJ3xcn7tEBCAeKBRd+JPjMABpcUhuzvv+EKbiJa5PZ3P80roF kaow== X-Forwarded-Encrypted: i=1; AJvYcCX2t+mp4I6ubIl83T4QSH3Wnbw8qPGIVKd9i6xWx7M2ihD421TcYwyLcPoEFQo3ekSbLAPTeDA2WHBghvs=@vger.kernel.org X-Gm-Message-State: AOJu0YwbidzrC1r6OJzAuBAGJQ9GXpc5wHr0tHyx1oXUQHCJcEC1qqAc ZYpcUYOK4r99hjRlfPZ1TpwrIdaQCizEx5AEKsXRS4sVvdtSuIz7aJkBh/NtIA== X-Gm-Gg: ASbGncsYjlESHihAxov4FBdccHsAIIbPCQpPJtjLB/lQM7TbwGFhIa4JS21UUj1cWT7 CwXPuvsVxk9KycAqsRUpFboLfIgz6B0h94DXc2SUG0/K6bkK8WYibemJs9YkllRbJJU6m+u8CTT v7Br0CCiUa3PQ8MThDJ4Mqbx2P2Ty0VyqbY3p6E2Y+4H/T31rc1qhAOBXffTkkr5LD4kv/+PUuH 4tUarf2GU2UYCbfKyxaHNJ1zPaaRGcCrqMcCDN/5/LfHGnUVkeggoAJoHvSaSr0REOgrRXdF0GM ymPJuUlVMD9iin3NxAaW3CvbuKu5ay3k8fbGEein X-Google-Smtp-Source: AGHT+IHi8ugXNTLktZ75i6e/hZMghmmljaGGFz8gyT88jOcuSFXoV3Q30l2pcd5HlYB7doPvxH4tkQ== X-Received: by 2002:a05:6a21:6b17:b0:1e4:745c:4965 with SMTP id adf61e73a8af0-1eb696de77bmr13239928637.8.1737747643397; Fri, 24 Jan 2025 11:40:43 -0800 (PST) Received: from google.com (28.67.125.34.bc.googleusercontent.com. [34.125.67.28]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a78e351sm2298237b3a.180.2025.01.24.11.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 11:40:42 -0800 (PST) Sender: Benson Leung Date: Fri, 24 Jan 2025 19:40:38 +0000 From: Benson Leung To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, abhishekpandit@chromium.org, dan.carpenter@linaro.org Cc: bleung@chromium.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, akuchynski@google.com, ukaszb@chromium.org Subject: [PATCH 2/2] usb: typec: thunderbolt: Remove IS_ERR check for plug Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Fixes these Smatch static checker warnings: drivers/usb/typec/altmodes/thunderbolt.c:354 tbt_ready() warn: 'plug' is not an error pointer Fixes: 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode") Signed-off-by: Benson Leung Reported-by: Dan Carpenter --- drivers/usb/typec/altmodes/thunderbolt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/altmodes/thunderbolt.c b/drivers/usb/typec/altmodes/thunderbolt.c index 94e47d30e598..6eadf7835f8f 100644 --- a/drivers/usb/typec/altmodes/thunderbolt.c +++ b/drivers/usb/typec/altmodes/thunderbolt.c @@ -351,10 +351,10 @@ static bool tbt_ready(struct typec_altmode *alt) */ for (int i = 0; i < TYPEC_PLUG_SOP_PP + 1; i++) { plug = typec_altmode_get_plug(tbt->alt, i); - if (IS_ERR(plug)) + if (!plug) continue; - if (!plug || plug->svid != USB_TYPEC_TBT_SID) + if (plug->svid != USB_TYPEC_TBT_SID) break; plug->desc = "Thunderbolt3"; -- 2.48.1.262.g85cc9f2d1e-goog