From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Carlos Song <carlos.song@nxp.com>, Arnd Bergmann <arnd@arndb.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: imx-lpi2c: select CONFIG_I2C_SLAVE
Date: Sun, 26 Jan 2025 12:02:26 +0100 [thread overview]
Message-ID: <Z5YWQr5fMcSIUIs0@shikoro> (raw)
In-Reply-To: <20250122064906.1220557-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Wed, Jan 22, 2025 at 07:48:36AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The addition of target mode causes a build failure when CONFIG_I2C_SLAVE
> is turned off:
>
> drivers/i2c/busses/i2c-imx-lpi2c.c:1273:10: error: 'const struct i2c_algorithm' has no member named 'reg_target'
> 1273 | .reg_target = lpi2c_imx_register_target,
> | ^~~~~~~~~~
> drivers/i2c/busses/i2c-imx-lpi2c.c:1274:10: error: 'const struct i2c_algorithm' has no member named 'unreg_target'
> 1274 | .unreg_target = lpi2c_imx_unregister_target,
> | ^~~~~~~~~~~~
>
> Select the Kconfig symbol like we do for other similar drivers.
>
> Fixes: 1ee867e465c1 ("i2c: imx-lpi2c: add target mode support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-01-26 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 6:48 [PATCH] i2c: imx-lpi2c: select CONFIG_I2C_SLAVE Arnd Bergmann
2025-01-24 4:59 ` Carlos Song
2025-01-26 11:02 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5YWQr5fMcSIUIs0@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=carlos.song@nxp.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox